From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id BE9B438460B1 for ; Fri, 19 Apr 2024 21:55:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE9B438460B1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=chromium.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BE9B438460B1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713563705; cv=none; b=hEneQLmun/KDnYAKdiY02zSPMo99U+YhhgDXqeIs2kRv9W8d8YraM5dkapyISWL86NVakgCbMvcJo2BsdCPO/P/Hy6UFZtJDMHLaiINy+ndxIY7t2wAo+ZdMN/NzXCeybHd7iaw2oexY7BMKLYi9qcNSgDrLKw2MoudJBM6PDcA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713563705; c=relaxed/simple; bh=LKPPfGCDWpIUtrc07dVEnEui8/pCxSWUcFYWbSqbNH4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=qZNG8ktnDFsyiGzaRJiZmQmQMioRv2E1zbzKCN5DHVbZJJY+rn8N1Wm6sBYMrLfWNpLYSzdwvyXxV4GYs5Jz6e8Uzx1AP1YfU9O3tOJ8p0ADEnIeiOgt2flM32F72Dh6J4+jJ1iN1/ZGNGI2k7YG7xl5L4qs1wKLc9xPNgs4U6k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6ed112c64beso2301814b3a.1 for ; Fri, 19 Apr 2024 14:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713563702; x=1714168502; darn=gcc.gnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VCK253zW//nlW+Q/En14LlLKTsCmeu1seZQKN03WXZs=; b=O3diM5HzN6aADnYR6UBVxRDo2ZxjW1orugmNWG35gYUlSdg0oqfYeRLQ4mlAyDi64m ZCE16XGiwT+F4hb6d4Bb6hmn6j79ly9qJZ4rq0FJApW1C/cCFsNXs51NIE8RDHvxfukI /cWghHI0Jw7P+VWuodFsGowB/YRr2R9BBjJdA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713563702; x=1714168502; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VCK253zW//nlW+Q/En14LlLKTsCmeu1seZQKN03WXZs=; b=BDFdc9RMJsCDDNJLj67AjAQ7K5WLNf6uO84cYlf9YM8BThDnQHMK/Ap/Ou3pBWYl9n YMStZA1vV+Ckj7VKHvnOvmOLaflzmStlxzc0dnOQKj429btC8gYq416Ip+3OyJIEGE2V E8LsOk0hiVEk9vuc/BpY71wIdFAPMrRc4AQzi9RgFGjPPlz6hn5fo0mmoRZk5eSZYGJW enNAYpROXTABkW0XQTghjUiE1Mjo7F8WZJbF49f9PCbnwcCwCOL61/mj3ujT41jRofA6 a2AGHgpE0BSv8cornHfMfIipyk8rr3IlqmXmtHNmW9J+oIrLUsYdWuPlQwvnE7/QyGsC 42cA== X-Forwarded-Encrypted: i=1; AJvYcCWM8v5RmBAiRTyPw581kykTLDRRmv9hEBADPMLi40xY/WwWkleKsSW+WYcOmWQbWqYUPOSqnUHmC8O4AAQO5/Dpw9jZDMQhGQ== X-Gm-Message-State: AOJu0YyjLgVyl/wSnQr4ZJ61H6uqWH97e9rz3tD4WdUuP7+bRIayqfb/ Bc0U4fifo/kDQxx8RT9t0UiZ++FK7HfZpwE+Lp859Rt4xm1nHUe8MJtxY1JeANr37IZ+mzx8AnY = X-Google-Smtp-Source: AGHT+IGShaSiJ/IwJH7y8JnfQzXdWys/11wAIJa1PtwNMttZezdPcT8sqniaoNL0nrCwXHrqMcIa5g== X-Received: by 2002:a05:6a20:3ca0:b0:1a3:6833:1cf5 with SMTP id b32-20020a056a203ca000b001a368331cf5mr4410903pzj.29.1713563702333; Fri, 19 Apr 2024 14:55:02 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id fj32-20020a056a003a2000b006eac4297ed3sm3719393pfb.20.2024.04.19.14.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 14:55:01 -0700 (PDT) Date: Fri, 19 Apr 2024 14:55:01 -0700 From: Kees Cook To: Qing Zhao Cc: josmyers@redhat.com, richard.guenther@gmail.com, uecker@tugraz.at, siddhesh@gotplt.org, gcc-patches@gcc.gnu.org Subject: Re: [RFC][PATCH v1 0/4] Allow flexible array members in unions and alone in structures [PR53548] Message-ID: <202404191408.7A7FC945CF@keescook> References: <20240419184317.2138890-1-qing.zhao@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240419184317.2138890-1-qing.zhao@oracle.com> X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Apr 19, 2024 at 06:43:13PM +0000, Qing Zhao wrote: > Therefore, GCC needs to explicitly allow such extensions directly for C99 > flexible arrays, since flexable array member in unions or alone in structs > are common code patterns in active use by the Linux kernel (and other projects). Thank you for fixing this! :) This will make conversions much much easier for the Linux kernel (and future userspace programs). I've tested these patches and everything behaves like I'd expect. -Kees -- Kees Cook