From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C8F22385840D for ; Tue, 23 Apr 2024 18:28:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C8F22385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C8F22385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713896902; cv=none; b=QFuwcB/jBFP/q4xVr53PQJiDaBy7GcJ6jmJIDUyrbYjksz5MpLIjFlWBA/2g5BQgWYqBgDXCBn0RxEne3iong+b//Raa/fGolgbHyEEhdwB4/iBEdYEwOCBx1OLViNF7e0lyrGnhXMr2mvVENJPDY4dJy+71978+1P3BCt/Uygs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713896902; c=relaxed/simple; bh=Pi3Q6OCcQjluw+nTJjTljTnWrwy2lzNKheiuDe+W0tE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ViiOPhZ8+iN+jRJG3l5LGaAbbHkroc/zW5fzswxa+2Z+fojxzdKJUoiQnniZ09QM0FrDeZSTAOfvibcajzl7G+uy2ItAyCPMkc/YcDckxEaMGCacDJhyHn1qFjYTocROv+4KAeDOQ847oFiXnjK7JvJV2XjdetZ3IzsB9OEDcKQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713896899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8tbBX/hnhLSRHrVHC6n0MNzfo7q/XFoZ8CTVcPHPebk=; b=XqNJOqi+pWtNIBgQJzBUc+UfhT3wbmyVq54ZpirAEt1MZ97HRd9Lq1qyxsDzdHOaygSxir WTuVxrTKO3rqVl0KQHhmISOmtw+GOXz1L7orFdXjnfkmRTaqiaMEnP6/KNm3ipK+GUVcrP V1K+/Ks6AJkVML36zfd7oKrmj63vj34= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-p3CTUo8_M6e-hRq30uXviw-1; Tue, 23 Apr 2024 14:28:18 -0400 X-MC-Unique: p3CTUo8_M6e-hRq30uXviw-1 Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-3c5ed72fe10so7442358b6e.3 for ; Tue, 23 Apr 2024 11:28:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713896897; x=1714501697; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8tbBX/hnhLSRHrVHC6n0MNzfo7q/XFoZ8CTVcPHPebk=; b=t/GdftJ5Q46I4zvyg3bbeTsLFtg9IrhF2foN0b2eN0iKzV7WxhiTC9022yI57lWQLG 7H4aaEGAepUkXmZhDMgd1AzTrVB34qNY9ONg92oZYGMYfLRwtLUERLZGyYeHUSDhBZKX vIWmNi0EnSe2fFQyeRA6JpINeeTBfeSSN+LI7EJXR66h+okFBIrofZHIb7Qbi6NTnBSX uceMBKy+Y0EpTOJHby8r/U2zddMD0NI8McDYxE9a0YAAPZhdYJCvrUkktsS1pSXCfJCe t+Mmno+H7c9OGEZzqMvRF3pI8iZsISz6dAmRBt+AgNQ+CThT90Lp4UiUXCGNdnQNASib 4lUg== X-Gm-Message-State: AOJu0YyQqry9KBSq6EHswuXys7JYZAzCTqllJJGj99Nr0bXNa3+fgR5c BZXTuzzEV+/3l1oP5emkHq4EpKfpoiZRZCSq8J+oNpuEaLrskUGTtmupoU6DsMzmRQWSMa+5KV8 mAuIjDvAcXR3jT2YQS2i5hvw4FMZQw4arQVhwLQgMFwK0Aj+aQF1YsbdZA8DKAwGdQb2V+NjKSs x61J1AM0lnD0fAO9t7KjYVK7RU+gDut+I1IZwq X-Received: by 2002:a05:6808:1491:b0:3c7:4e35:7e22 with SMTP id e17-20020a056808149100b003c74e357e22mr190429oiw.1.1713896896764; Tue, 23 Apr 2024 11:28:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8D8UvMP592y+uFaTtAEZnNufjGhq9t88SCm97TfRAGwvUAOyAchFYNTsFtQzeeqO2eupWAA== X-Received: by 2002:a05:6808:1491:b0:3c7:4e35:7e22 with SMTP id e17-20020a056808149100b003c74e357e22mr190409oiw.1.1713896896333; Tue, 23 Apr 2024 11:28:16 -0700 (PDT) Received: from localhost.localdomain (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id i8-20020a0cf388000000b0069b7bc51271sm5336568qvk.123.2024.04.23.11.28.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 11:28:15 -0700 (PDT) From: Patrick Palka To: gcc-patches@gcc.gnu.org Cc: jason@redhat.com, Patrick Palka Subject: [PATCH] c++/modules testsuite: avoid expensive ggc-min-expand=0 Date: Tue, 23 Apr 2024 14:28:13 -0400 Message-ID: <20240423182814.3195778-1-ppalka@redhat.com> X-Mailer: git-send-email 2.45.0.rc0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- The below testcase uses --param=ggc-min-expand=0 which forces a full GC during every collection point and in turn takes over two minutes to run and ends up being the main bottleneck of the modules.exp testsuite. This patch speeds up this test without (hopefully) significantly affecting its coverage by using =1 instead of =0 which forces a full GC each time the heap grows by 1%, which means exponentially fewer GCs. After this patch the modules.exp testsuite finishes in 2m55s instead of 3m40s with -j8 on my machine. gcc/testsuite/ChangeLog: * g++.dg/modules/pr99023_a.X: Use ggc-min-expand=1 instead of =0. * g++.dg/modules/pr99023_b.X: Likewise. --- gcc/testsuite/g++.dg/modules/pr99023_a.X | 2 +- gcc/testsuite/g++.dg/modules/pr99023_b.X | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/g++.dg/modules/pr99023_a.X b/gcc/testsuite/g++.dg/modules/pr99023_a.X index c872d15f792..96bb4a2ab5a 100644 --- a/gcc/testsuite/g++.dg/modules/pr99023_a.X +++ b/gcc/testsuite/g++.dg/modules/pr99023_a.X @@ -1,5 +1,5 @@ // PR c++/99023, ICE -// { dg-additional-options {-x c++-system-header initializer_list -fmodules-ts --param ggc-min-expand=0} } +// { dg-additional-options {-x c++-system-header initializer_list -fmodules-ts --param ggc-min-expand=1} } // { dg-prune-output {linker input file unused} } diff --git a/gcc/testsuite/g++.dg/modules/pr99023_b.X b/gcc/testsuite/g++.dg/modules/pr99023_b.X index ca5f32e5bcc..955378ad88f 100644 --- a/gcc/testsuite/g++.dg/modules/pr99023_b.X +++ b/gcc/testsuite/g++.dg/modules/pr99023_b.X @@ -1,5 +1,5 @@ // PR c++/99023, ICE -// { dg-additional-options {-x c++-system-header iostream -fmodules-ts -flang-info-include-translate= --param ggc-min-expand=0} } +// { dg-additional-options {-x c++-system-header iostream -fmodules-ts -flang-info-include-translate= --param ggc-min-expand=1} } // { dg-prune-output {linker input file unused} } -- 2.45.0.rc0