From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 0B1CF384AB51 for ; Tue, 7 May 2024 08:00:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B1CF384AB51 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0B1CF384AB51 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715068868; cv=none; b=hxSifKs6QyDZfWdzdzH5g71FJ/XoSEIMqRhPekqKDJGFN3WZchdxoF+aO75Agi+cldz62pbzdDiKUSwq9TKRVwqRycmN+X0BC9V6orIAK97U22WrScSYjztAm6R3D8uCvpDMvWZ9wjplIWZ17DkUxv/1xgYy2L6y3IZl4Q5sZKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715068868; c=relaxed/simple; bh=XORDJ06AFQA9Mbj5+m4kIySpGnrcOlJtDRev/PVN4Vg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Ewwix1uVC3YWu1BI5ga91oC++79sPqI/cUYkYrbiAi6MBV9gy0IkI8lrJMLgS7sOsSe+o0m+nsII0k1tzdcAHXkDupDF2lgdAbaQoQSe4CpLS4Ed8wZwT5AVBu1YSQdMQ9uhNuqCLF9Gewe1aR8eYvlRh79RUq4H1cCIfPFQ+JI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-34d96054375so1773406f8f.2 for ; Tue, 07 May 2024 01:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1715068839; x=1715673639; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=u+dUOJAjI4K3bSuThxQIQY0CtZJvFQIybJ80Fu0NQ3w=; b=DMsBs7Ni/LYNB987oLpYF/TvuMOsYPwclq7WhT1lbWVTJLztcyG9Q6Zz41gZk5lPsu i3fD0bA1caVE4aJcKT/Cpzx29lHYvsQ2uCJTC6yAJnc0cyLZxdVL15dquqZFhuST2xJE VbuB5SomOXWPN5lyROXbFKAUcUlvvpF6DrXdCswZ9DEyyK4Gyttia/mbzP/EteYKQj6Z uYbXBS452tsnTp0TvfLhT8koUfSAg+sCc+e+rqp1BPzidH8i7ia/Xtl3Ia6/5M4NMT+V V72dps3ESBH0LRXlkF7ODAZwv42jRlQQB6W5yKXfR31hsHcTD+YXfIwHmS9Rf3nYYOOa KjTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715068839; x=1715673639; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u+dUOJAjI4K3bSuThxQIQY0CtZJvFQIybJ80Fu0NQ3w=; b=s4D/QvTvGj4BWXEtpUBkYyaH3M1I91VLz+tQCVUUQmCVVRNInOWwFGifHGN0erF6MS QAlJsk0cSnFg5rybTDkP1GECJwtSIlbsIlXBnrTEtq0FUKCOEbFGiyaGAtRQHjW9/htC biLjB7r98hxePZrmu4mcqjwJUeaLDkPxRTmvlT5FplwE0OLKUeSNguY5GAkHB0uTD12X f2CIvSyEtuGxMvJJPe1+go0vP29O24A7/k1V+5llyjVe448iRcDEXKPjx2MowaMYAP/I ThOgqtxJZiDJ8c3MCV5vx8KZGyX+nehWpjJXWll7Z+g0SK9opkjRdQCTt5FER/x61VpX u1Eg== X-Gm-Message-State: AOJu0YwCBE3IFC3eaEI62ap8DlbqfWjHUNEGgGLt458DkONh8mEtmnpM oszYe/7uxtA3cVVPWK5V1VonScuFv990uoUq/ga7iUPb/CEGV/hJgkcK2PX1/1iVH8XIi0vs87E = X-Google-Smtp-Source: AGHT+IH11PNBCUJf5dwpCKYBFL9d57QskJ0LyDcK5C1KUA3JYlb3airwvM2dN5bxsdLzjzRpkaDjbw== X-Received: by 2002:a5d:5142:0:b0:34d:b4db:9927 with SMTP id u2-20020a5d5142000000b0034db4db9927mr9521343wrt.50.1715068838774; Tue, 07 May 2024 01:00:38 -0700 (PDT) Received: from localhost.localdomain ([2001:861:3382:1a90:11a6:1c9d:5099:b1e8]) by smtp.gmail.com with ESMTPSA id q5-20020adff945000000b0034f5925edacsm2915857wrr.30.2024.05.07.01.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 01:00:38 -0700 (PDT) From: =?UTF-8?q?Marc=20Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Piotr Trojanek Subject: [COMMITTED] ada: Remove redundant guard against empty list of actions Date: Tue, 7 May 2024 10:00:37 +0200 Message-ID: <20240507080037.37999-1-poulhies@adacore.com> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Piotr Trojanek Code cleanup. gcc/ada/ * exp_ch4.adb (Useful): Remove redundant check for empty list, because iteration with First works also for empty list; rename local variable from L to Action. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/exp_ch4.adb | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/gcc/ada/exp_ch4.adb b/gcc/ada/exp_ch4.adb index 5fa47c9b6e7..505c4b3151a 100644 --- a/gcc/ada/exp_ch4.adb +++ b/gcc/ada/exp_ch4.adb @@ -12930,8 +12930,7 @@ package body Exp_Ch4 is -- to Opnd /= Shortcut_Value. function Useful (Actions : List_Id) return Boolean; - -- Return True if Actions is not empty and contains useful nodes to - -- process. + -- Return True if Actions contains useful nodes to process -------------------- -- Make_Test_Expr -- @@ -12951,22 +12950,20 @@ package body Exp_Ch4 is ------------ function Useful (Actions : List_Id) return Boolean is - L : Node_Id; + Action : Node_Id; begin - if Present (Actions) then - L := First (Actions); + Action := First (Actions); - -- For now "useful" means not N_Variable_Reference_Marker. - -- Consider stripping other nodes in the future. + -- For now "useful" means not N_Variable_Reference_Marker. Consider + -- stripping other nodes in the future. - while Present (L) loop - if Nkind (L) /= N_Variable_Reference_Marker then - return True; - end if; + while Present (Action) loop + if Nkind (Action) /= N_Variable_Reference_Marker then + return True; + end if; - Next (L); - end loop; - end if; + Next (Action); + end loop; return False; end Useful; -- 2.43.2