From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 8F9403858D1E for ; Tue, 7 May 2024 13:36:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F9403858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F9403858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715088979; cv=none; b=UFTsb0ehxkjUOAKECuwvEd37UJJVQEhVGiAr1RKg0iFJMiWpXU+Phab/k6NBBMFhweYoc0qdTmkN11OVVAmOrElA/6KocBlgY5zc0i1gRzuDRGDOQwbfFV3Dd2W4Kb8enfzDGxbHShd+bSPilVJPc7s4uvf1rOkcw0R1+SoTGbk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715088979; c=relaxed/simple; bh=Dfx37EsKIS0uSXiDn93aZGqmfb6jXBZrnZ4PlCPT1bg=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=DhkF3SRByRdzHIn66SdwcANCH4TQF98HGlq3h05cXu8UjfDtqctKkyggrNODUuRLaq9z631Um//xVKvvzEJlkbUe02DU2Jo8EOigkx+qVV8M/l8lzDjET7TOwUepFjuMnCfj/APYuYZHdpNIP/egwruhE9RCTJ5B1753ix4Woak= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.5.241] (unknown [10.168.5.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 690C920A8E for ; Tue, 7 May 2024 13:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715088973; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=NCKhpCiDNxgVSxsigwpxoxXfIu6fRh7hRGIQddegikA=; b=ouw/WMz11AKVATJdRyQk3yZR9XY53+tyJT/jslYLosKszEWrHaM4B9peabYVGChWLWQl7q wHm8I1RB/EsFPhKSgRME2ue7WXjkJCDDDZdvmaune2SCmmvutReoizsTLci2vFkTSgNn/d VbHMzz6vMJJ2GliG0YVS55myyrW4F+w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715088973; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=NCKhpCiDNxgVSxsigwpxoxXfIu6fRh7hRGIQddegikA=; b=/XqtnUQOPv1iA8gHY2eTXjx3Zx0Psv/4iHlNhoPHx+sg9rlqNdoYL7a1G+w/e3lOTwhOEw TPo6mOen9gRvvbCA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715088973; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=NCKhpCiDNxgVSxsigwpxoxXfIu6fRh7hRGIQddegikA=; b=ouw/WMz11AKVATJdRyQk3yZR9XY53+tyJT/jslYLosKszEWrHaM4B9peabYVGChWLWQl7q wHm8I1RB/EsFPhKSgRME2ue7WXjkJCDDDZdvmaune2SCmmvutReoizsTLci2vFkTSgNn/d VbHMzz6vMJJ2GliG0YVS55myyrW4F+w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715088973; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=NCKhpCiDNxgVSxsigwpxoxXfIu6fRh7hRGIQddegikA=; b=/XqtnUQOPv1iA8gHY2eTXjx3Zx0Psv/4iHlNhoPHx+sg9rlqNdoYL7a1G+w/e3lOTwhOEw TPo6mOen9gRvvbCA== Date: Tue, 7 May 2024 15:36:13 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix guard for IDF pruning by dominator MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Level: X-Spamd-Result: default: False [-0.02 / 50.00]; MISSING_MID(2.50)[]; BAYES_HAM(-1.23)[89.44%]; NEURAL_HAM_LONG(-1.00)[-0.995]; NEURAL_HAM_SHORT(-0.20)[-0.979]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; MISSING_XM_UA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_NONE(0.00)[]; MIME_TRACE(0.00)[0:+] X-Spam-Score: -0.02 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,MISSING_MID,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20240507133613.DnumfX6taVFNHWZ16g3lY9_jjAVr2xkB_FuQAPQtOkI@z> When insert_updated_phi_nodes_for tries to skip pruning the IDF to blocks dominated by the nearest common dominator of the set of definition blocks it compares against ENTRY_BLOCK but that's never going to be the common dominator, instead it will be at most its single successor. Re-bootstrap and regtest running on x86_64-unknown-linux-gnu. * tree-into-ssa.cc (insert_updated_phi_nodes_for): Skip pruning when the nearest common dominator is the successor of ENTRY_BLOCK. --- gcc/tree-into-ssa.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/tree-into-ssa.cc b/gcc/tree-into-ssa.cc index 705e4119ba3..858c3840475 100644 --- a/gcc/tree-into-ssa.cc +++ b/gcc/tree-into-ssa.cc @@ -3262,7 +3262,7 @@ insert_updated_phi_nodes_for (tree var, bitmap_head *dfs, common dominator of all the definition blocks. */ entry = nearest_common_dominator_for_set (CDI_DOMINATORS, db->def_blocks); - if (entry != ENTRY_BLOCK_PTR_FOR_FN (cfun)) + if (entry != single_succ (ENTRY_BLOCK_PTR_FOR_FN (cfun))) EXECUTE_IF_SET_IN_BITMAP (idf, 0, i, bi) if (BASIC_BLOCK_FOR_FN (cfun, i) != entry && dominated_by_p (CDI_DOMINATORS, -- 2.35.3