From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20600.outbound.protection.outlook.com [IPv6:2a01:111:f403:260d::600]) by sourceware.org (Postfix) with ESMTPS id E48533858D1E for ; Wed, 8 May 2024 02:26:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E48533858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E48533858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:260d::600 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1715135169; cv=pass; b=cnGlCohNNVg/BfpyQ9jYMA63p3n+S3+xEmcJMkMYJTl8yrYZRbHbdrfI2Q93vGUo1yy4qpHaBwxfK86fHeS5SxkVoTC+iiZ7IdBr/2ut9V2j1myCveu8VOsJzSlkJl7ZAKRu0MleGiiI4gPCUHsfSk1KDKHZFxVq8ATHVjcBEgI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1715135169; c=relaxed/simple; bh=uoacBJLDLgviLy17XxzyRWQIttQWaq1JRtWtY8CbVOI=; h=DKIM-Signature:From:To:Subject:MIME-Version:Message-ID:Date; b=sLM2wbfvWOY/Q8MfgEQGKs3Vo+4H2zCBEospkx+tC/JJLuM5tu4gu0T+XDbzfBlF2IRd6l+rSfaAHfWRgCpBeYthhR7cdu84SJnX/TMVa9drxQ7sFgdjOBazRv95Eg8QqGWQmW1TCftsP79grFoeIOA2eE5d58swsELvjg6HIoI= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dQTqBEHXqsw0a/hle4HkmozZLuYQtbhT+/HnjljxOnwF80tungJTm/35y1CKiVXSsbjpxYZ0MlsW1+k9b1KLZH6ySJoIJj7+B7H/Cew77Z/ygs4kyZtJBUHRTVNUrRGZL0O4XiKG/KSS9Vuz4yDM1eER9ZCHGYeOniRpYYYYWx+9/TwHUp+4mmE9SX6GicLGxyNRFpyT+wOBbfJx8Bp/dTny2pzPnwyPRfzRDxU+tFAnVnyT7YQj4Hce98pDowlUHBKQ0UjZq/jMgYAyWLDG+jpm80FjoR8PzR65YBJx7DaL9I/pcHJ761Jh4vjuuW9pzeKy4YTAyBnOOEdL3gMwqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GClRy3W7v8YyrYkM1gfXgWLyMPz+5Nc0VMkKFh4SRO0=; b=nnizaC2WEIlCseIs2nipzS3873K5V76vX+nsn9fuKWRvYrEU77lYcZ7/mjKi1jyAjYzoHOVNzOzJNI6j5h6Gjw6swaZ7X8yzsjO2+qgP577EfiCFxSDiCQmsAae1x3V/MLkCVhX/1kIEOigMt2Zjqbg0uq435Q3nC2TrwRq+HfIdu8WQfHuryjU8EeXoBwBwvN+IbfNskfC+eDsj//nzr2mU9KwA4sbjKqLMUwkqHorBk3wAEJwFXENtXM6mgW2JHPreOXiHxb3p8AfN1pJ5feX7D9j+XD5J3p4mIDhnKz5bXmzGPBXmqgJvgpie4LcQF+YvrFqAqZ2AvGIuLcuG5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 195.60.68.100) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=axis.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GClRy3W7v8YyrYkM1gfXgWLyMPz+5Nc0VMkKFh4SRO0=; b=DTQQnrcPuHMwIL/ur4IZcDFGkXKI7T49FFaMeUQCN+phXN8C/alvWdlkNtYaG5TN4jht9950mPRT9IXLlx/8+UoeclCVIugBhRnj6w2k+JmFKtdgjydSLRZswfGlL3MoAm+piRmbHVp0F2qO7CIzXg3kFzXl2SUxTtLUhu5k5vs= Received: from AM0PR02CA0088.eurprd02.prod.outlook.com (2603:10a6:208:154::29) by AS8PR02MB8826.eurprd02.prod.outlook.com (2603:10a6:20b:53d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Wed, 8 May 2024 02:26:02 +0000 Received: from AMS1EPF00000046.eurprd04.prod.outlook.com (2603:10a6:208:154:cafe::fb) by AM0PR02CA0088.outlook.office365.com (2603:10a6:208:154::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.45 via Frontend Transport; Wed, 8 May 2024 02:26:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=axis.com; Received-SPF: Pass (protection.outlook.com: domain of axis.com designates 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; pr=C Received: from mail.axis.com (195.60.68.100) by AMS1EPF00000046.mail.protection.outlook.com (10.167.16.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7544.18 via Frontend Transport; Wed, 8 May 2024 02:26:02 +0000 Received: from se-mail01w.axis.com (10.20.40.7) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 May 2024 04:26:01 +0200 Received: from se-intmail01x.se.axis.com (10.0.5.60) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 8 May 2024 04:26:01 +0200 Received: from pchp3.se.axis.com (pchp3.se.axis.com [10.88.21.53]) by se-intmail01x.se.axis.com (Postfix) with ESMTP id DFDB730B6; Wed, 8 May 2024 04:26:01 +0200 (CEST) Received: by pchp3.se.axis.com (Postfix, from userid 171) id E338220432; Wed, 8 May 2024 04:26:01 +0200 (CEST) From: Hans-Peter Nilsson To: In-Reply-To: <20240410231632.26E9820442@pchp3.se.axis.com> (message from Hans-Peter Nilsson on Thu, 11 Apr 2024 01:16:32 +0200) Subject: [COMMITTED] Revert "Revert "testsuite/gcc.target/cris/pr93372-2.c: Handle xpass from combine improvement"" combine improvement MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20240405020601.C492220432@pchp3.se.axis.com> <20240409201810.GM19790@gate.crashing.org> <20240410231632.26E9820442@pchp3.se.axis.com> Message-ID: <20240508022601.E338220432@pchp3.se.axis.com> Date: Wed, 8 May 2024 04:26:01 +0200 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF00000046:EE_|AS8PR02MB8826:EE_ X-MS-Office365-Filtering-Correlation-Id: d09be6eb-e752-491f-5765-08dc6f0634b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|36860700004|82310400017|376005; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?BlZ5cc+m6cDof2uYyr+Q2dZI7Ahtfuixwu/tNCi7zDIs2Ga0pHfobDok/k?= =?iso-8859-1?Q?uw3uPRNkzzRb11EuIf7M2839mca5FvHjJSa/QNWxZFlGekG5/fmZwIn0AE?= =?iso-8859-1?Q?Hy5yESj+RJEL6wbLOu8fR3pyGWQeJcbahd10JWK9PVKZVxOZ/uSSKKkg8I?= =?iso-8859-1?Q?0csE+9e8JNTygpsWiMVZDaWOLSsqojgFCAaWTUYNByTobdzVeZ+a2HEhkT?= =?iso-8859-1?Q?LyoWjAfj/LNW/blEawnUyWpxPkHWz01K3qHop3WpmYXqOBhK0z1I3FKn91?= =?iso-8859-1?Q?SxE6irRQanuUKOit4aJeMwrYHWlxUcWsgbARuTAQPmdVyAYYVeUxu53wQa?= =?iso-8859-1?Q?sK1RDqZDjbXesPdOkv1P354WjivOTgt25GGHfXtan4ejGho+C5BCz53Tuq?= =?iso-8859-1?Q?PVNCvjXQLt04WoQ3aEUW4fkCH8Ii5JsVs602ky54lA+Pj4EmOY5Z5E89UG?= =?iso-8859-1?Q?Fj3V7/aY3UR3qbU5r+mBaKKps4PFj9ASm477sxirwlMbj7MDyotLkuTzN9?= =?iso-8859-1?Q?6xwXDuVmscO1JpD2OmQwZCETy9z5m2NsG2IzLmKvkmGaSO7gpGheN9nO1p?= =?iso-8859-1?Q?hvFpHht454frKGY8eoI9ef/urnRwurjzBLsWgvjaM0hgHssoIP0uIBKSiG?= =?iso-8859-1?Q?1zjySxW0mk6Rrl67pmsNcKkd6J70rW+iGyL5VXx+8ELI0YgctUvsVLXaS3?= =?iso-8859-1?Q?AbW0+lCy32Ds6ujxytORhhsdQZUcdkaPp2NbNCZgygW/Rgh57NhTudFl9v?= =?iso-8859-1?Q?XWGw+NTvJl9U/HkCig9TWgn05Uf2g5s9aeiKYLbyb1fjNqh1ghlgvt/3Cq?= =?iso-8859-1?Q?n33NKTvHGhXsfOc/3LonRlPxiCph07VKMms5aFbIfboC+66vBx2OG8eg9b?= =?iso-8859-1?Q?+j0i20bGxcIhYuzcDQsYljs9QGeq8x1gfAxFHgai0TRYy/mLRYWHVstxZ6?= =?iso-8859-1?Q?bG1JuaaIEsc/opwAnyQ5IM1EBL5U1RPeg4A5hOEZ0QbT19A4mIpYmmShmy?= =?iso-8859-1?Q?0Y97et74f1OJOVBK5dAt6O+tTEeAG9zILOwzLRkUBEphCRU5nGCzIH0Qx6?= =?iso-8859-1?Q?Cy1leqAAYsBfttnYwy1TWE5HJR8NJb+7RS4CXu8s27Kzgy7n73ZOoqCPEF?= =?iso-8859-1?Q?/JRZRRxgMKsAeB/MuglD/zqslWqYXrGDopooauQchQp7vp6CdxexinkD7o?= =?iso-8859-1?Q?5691gt9JN5e11M6Gj+HYAQU2cAeaUaGfwgOUzwggkWl9JZncf1ikNr+oSX?= =?iso-8859-1?Q?z84X3s98WuPMiYdoaN9COgn173lmKmRAgXOQU0ScbMv/e0GoZYrIuBwpp3?= =?iso-8859-1?Q?AEA7T7LXiDcjAaYVodpAherPaXrtkbe6+UZGOADTTLVglNLwWRt3HE+dAw?= =?iso-8859-1?Q?dHo1hu9cnAl6hJlcPJU7BQcz2iJi5Hs0RS7oUMdVZgT/Bxmovr4Fa33ISh?= =?iso-8859-1?Q?+ug25YxsLn0D+0sX?= X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(1800799015)(36860700004)(82310400017)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 02:26:02.4151 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d09be6eb-e752-491f-5765-08dc6f0634b6 X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF00000046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR02MB8826 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Hans-Peter Nilsson > Date: Thu, 11 Apr 2024 01:16:32 +0200 I committed this revert of a revert, as r15-311, as the prerequisite was also revert-reverted, in r15-268. -- >8 -- This reverts commit 39f81924d88e3cc197fc3df74204c9b5e01e12f7. --- gcc/testsuite/gcc.target/cris/pr93372-2.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/gcc/testsuite/gcc.target/cris/pr93372-2.c b/gcc/testsuite/gcc.target/cris/pr93372-2.c index 912069c018d5..2ef6471a990b 100644 --- a/gcc/testsuite/gcc.target/cris/pr93372-2.c +++ b/gcc/testsuite/gcc.target/cris/pr93372-2.c @@ -1,19 +1,20 @@ /* Check that eliminable compare-instructions are eliminated. */ /* { dg-do compile } */ /* { dg-options "-O2" } */ -/* { dg-final { scan-assembler-not "\tcmp|\ttest" { xfail *-*-* } } } */ -/* { dg-final { scan-assembler-not "\tnot" { xfail cc0 } } } */ -/* { dg-final { scan-assembler-not "\tlsr" { xfail cc0 } } } */ +/* { dg-final { scan-assembler-not "\tcmp|\ttest" } } */ +/* { dg-final { scan-assembler-not "\tnot" } } */ +/* { dg-final { scan-assembler-not "\tlsr" } } */ +/* We should get just one move, storing the result into *d. */ +/* { dg-final { scan-assembler-times "\tmove" 1 } } */ int f(int a, int b, int *d) { int c = a - b; - /* Whoops! We get a cmp.d with the original operands here. */ + /* We used to get a cmp.d with the original operands here. */ *d = (c == 0); - /* Whoops! While we don't get a test.d for the result here for cc0, - we get a sequence of insns: a move, a "not" and a shift of the - subtraction-result, where a simple "spl" would have done. */ + /* We used to get a suboptimal sequence, but now we get the optimal "sge" + (a.k.a "spl") re-using flags from the subtraction. */ return c >= 0; } -- 2.30.2 brgds, H-P