From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C35F5384640C for ; Thu, 9 May 2024 17:42:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C35F5384640C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C35F5384640C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715276582; cv=none; b=mbpVe9XCyFp0UKua/6HirvrU/BGyR6jQ7YypzqledNWMtEaord8PDK8zYKVh8kRb8w6rH3ej+UWqIDiOZEvvmxQGVeUrdmCN7+HgY4jRVrCzcepB+BuqMvaB9CWdxK//nk1O+xe3S5Yb0GhO7f4ksIFVPCAgQEe0MjYxIKZcJ0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715276582; c=relaxed/simple; bh=qUcp0GRzFYFmyc2abvGxdWTllynWgmmk8Lr8Q/D0Tuw=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=f9vvo3JY8+wwOJwcKGRY1Xf7mOvYU16lWiZuq7MLDz9eM8MefGvpO4hm4cUd5CNX91dJamUj+LnGDGruyfnrYzJS5IT9nFDFlZ/I6xrewBHkqdNBb7B/8PGDJO84SHCkyra8EYMias2XWvwp4hro6SRcpkYO/tJi6aPhY6D4ftI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715276574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FujElb0Xi3PU7woB8GXNGJ8rpQ1x8xjakAmhJtxTHVM=; b=Sa1usGJm6MyLJgnT6YPEACUNh85R1s5YG1AEEinyB7iTpRrL1D0ozfDE6n32qJZl4J6jed aRojtTWw4ePmd2bhBYStk7J7XzQHUdoA9fPQqtJgcc0Hg9YuAXX0a/HBz4hCrMjkKuKDMY zO4fWrXPYVf3JcT5O4n8ziqKwf5R/mA= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-c4bEYuA4PL6-WIImx56zLA-1; Thu, 09 May 2024 13:42:52 -0400 X-MC-Unique: c4bEYuA4PL6-WIImx56zLA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 62DD6380212C for ; Thu, 9 May 2024 17:42:51 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.22.18.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B767746820; Thu, 9 May 2024 17:42:51 +0000 (UTC) From: David Malcolm To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [PATCH 15/21] analyzer: fix -Wanalyzer-va-arg-type-mismatch false +ve on int types [PR111289] Date: Thu, 9 May 2024 13:42:30 -0400 Message-Id: <20240509174236.2278921-16-dmalcolm@redhat.com> In-Reply-To: <20240509174236.2278921-1-dmalcolm@redhat.com> References: <20240509174236.2278921-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Backported from commit r14-9076-g5651ad62b08096 (moving new tests from c-c++-common to gcc.dg). gcc/analyzer/ChangeLog: PR analyzer/111289 * varargs.cc (representable_in_integral_type_p): New. (va_arg_compatible_types_p): Add "arg_sval" param. Handle integer types. (kf_va_arg::impl_call_pre): Pass arg_sval to va_arg_compatible_types_p. gcc/testsuite/ChangeLog: PR analyzer/111289 * gcc.dg/analyzer/stdarg-pr111289-int.c: New test. * gcc.dg/analyzer/stdarg-pr111289-ptr.c: New test. Signed-off-by: David Malcolm --- gcc/analyzer/varargs.cc | 38 ++++++++-- .../gcc.dg/analyzer/stdarg-pr111289-int.c | 69 +++++++++++++++++++ .../gcc.dg/analyzer/stdarg-pr111289-ptr.c | 39 +++++++++++ 3 files changed, 142 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/analyzer/stdarg-pr111289-int.c create mode 100644 gcc/testsuite/gcc.dg/analyzer/stdarg-pr111289-ptr.c diff --git a/gcc/analyzer/varargs.cc b/gcc/analyzer/varargs.cc index aeea73a3899..6e13271969a 100644 --- a/gcc/analyzer/varargs.cc +++ b/gcc/analyzer/varargs.cc @@ -961,13 +961,43 @@ public: } }; -/* Return true if it's OK to copy a value from ARG_TYPE to LHS_TYPE via +static bool +representable_in_integral_type_p (const svalue &sval, const_tree type) +{ + gcc_assert (INTEGRAL_TYPE_P (type)); + + if (tree cst = sval.maybe_get_constant ()) + return wi::fits_to_tree_p (wi::to_wide (cst), type); + + return true; +} + +/* Return true if it's OK to copy ARG_SVAL from ARG_TYPE to LHS_TYPE via va_arg (where argument promotion has already happened). */ static bool -va_arg_compatible_types_p (tree lhs_type, tree arg_type) +va_arg_compatible_types_p (tree lhs_type, tree arg_type, const svalue &arg_sval) { - return compat_types_p (arg_type, lhs_type); + if (compat_types_p (arg_type, lhs_type)) + return true; + + /* It's OK if both types are integer types, where one is signed and the + other type the corresponding unsigned type, when the value is + representable in both types. */ + if (INTEGRAL_TYPE_P (lhs_type) + && INTEGRAL_TYPE_P (arg_type) + && TYPE_UNSIGNED (lhs_type) != TYPE_UNSIGNED (arg_type) + && TYPE_PRECISION (lhs_type) == TYPE_PRECISION (arg_type) + && representable_in_integral_type_p (arg_sval, lhs_type) + && representable_in_integral_type_p (arg_sval, arg_type)) + return true; + + /* It's OK if one type is a pointer to void and the other is a + pointer to a character type. + This is handled by compat_types_p. */ + + /* Otherwise the types are not compatible. */ + return false; } /* If AP_SVAL is a pointer to a var_arg_region, return that var_arg_region. @@ -1031,7 +1061,7 @@ kf_va_arg::impl_call_pre (const call_details &cd) const { tree lhs_type = cd.get_lhs_type (); tree arg_type = arg_sval->get_type (); - if (va_arg_compatible_types_p (lhs_type, arg_type)) + if (va_arg_compatible_types_p (lhs_type, arg_type, *arg_sval)) cd.maybe_set_lhs (arg_sval); else { diff --git a/gcc/testsuite/gcc.dg/analyzer/stdarg-pr111289-int.c b/gcc/testsuite/gcc.dg/analyzer/stdarg-pr111289-int.c new file mode 100644 index 00000000000..33d83169c3e --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/stdarg-pr111289-int.c @@ -0,0 +1,69 @@ +#include +#include +#include + +typedef unsigned int mode_t; + +extern void openat (int, const char *, int, mode_t); + +/* Signed vs unsigned of same integral type. */ + +static void +test_1 (char const *name, ...) +{ + va_list arg; + va_start (arg, name); + + mode_t mode = va_arg (arg, mode_t); /* { dg-bogus "-Wanalyzer-va-arg-type-mismatch" } */ + + va_end (arg); + openat (-42, name, 0, mode); +} + +void +call_test_1 () +{ + test_1 ("nonexist.ent/", 0600); +} + +/* Not the same size: small enough for int promotion. */ + +int16_t global_2; + +static void +test_2 (char const *name, ...) +{ + va_list arg; + va_start (arg, name); + + global_2 = va_arg (arg, int16_t); /* { dg-warning "promoted to 'int'" } */ + + va_end (arg); +} + +void +call_test_2 () +{ + test_2 ("nonexist.ent/", 42); +} + +/* Not the same size: too big for int promotion. */ + +long long global_3; + +static void +test_3 (char const *name, ...) +{ + va_list arg; + va_start (arg, name); + + global_3 = va_arg (arg, long long); /* { dg-warning "'va_arg' expected 'long long int' but received 'int' for variadic argument 1 of 'arg'" } */ + + va_end (arg); +} + +void +call_test_3 () +{ + test_3 ("nonexist.ent/", 42); +} diff --git a/gcc/testsuite/gcc.dg/analyzer/stdarg-pr111289-ptr.c b/gcc/testsuite/gcc.dg/analyzer/stdarg-pr111289-ptr.c new file mode 100644 index 00000000000..7bdbf256d59 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/stdarg-pr111289-ptr.c @@ -0,0 +1,39 @@ +#include + +static void * +test_1 (const char *fmt, ...) +{ + va_list arg; + va_start (arg, fmt); + + void *p = va_arg (arg, void *); /* { dg-bogus "-Wanalyzer-va-arg-type-mismatch" } */ + + va_end (arg); + + return p; +} + +void * +call_test_1 () +{ + return test_1 ("fmt", "foo"); +} + +static char * +test_2 (const char *fmt, ...) +{ + va_list arg; + va_start (arg, fmt); + + char *p = va_arg (arg, char *); /* { dg-bogus "-Wanalyzer-va-arg-type-mismatch" } */ + + va_end (arg); + + return p; +} + +char * +call_test_2 (void *q) +{ + return test_2 ("fmt", q); +} -- 2.26.3