From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 89306384CB97 for ; Thu, 9 May 2024 17:42:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89306384CB97 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 89306384CB97 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715276572; cv=none; b=oDjr1hyTj5bEGamioc6zqxOtyfECVuY8jTA4hN+4vyqfj2Lg3vz9XygpNV25s+bE8rjSiafis6OCofH4+gzdSuAVuUOU3/SJoVBew6VwURM7S8E/7jTtL30ruBGsei+6rOtte4m9IBgIb919tX7JMwb0oK0AzbJ6jsv4irnBgEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715276572; c=relaxed/simple; bh=4+BWAAr6LsmKuYmtwHZkUjevpy6thRwA0HxNuJyKhZM=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=iRuK1u4rX35SSJFYILc7oAY+UU3iMtxcrDSCBxodMDLiKwHPoRs6ImmCZUongGOwft6xX8wNUAzSx94DTrB+I8/LYF2sALgA6pQ6cg+kisrWrUlnkAKe/sOw3D5rQa3eHoasSSAo0MXDoygPGcsYsrBMcMV6QZz4X7TQrl6DuCE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715276571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sszevDOkw/A4wVGO+QG1sxSvUP+3gFpapFYuMq/BYQ0=; b=Jm4K28eKa3kNh2GLi5tA9s2lRRwSo7wT7ixcLkGoNCPcbpnNSzIQpXSKboEccX/DZ2Qlr0 EQcSgRI0yag3dR2OrxDiSfIKNtpSpmeZNAZyCw2i/TfwPhDf04TQ3hswUR2sEPACc9kUZR 0PfVpv+cbQ1a6asY9ZZ7bi1pgDxh5y8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-n23FO_17M5G9qHTLKITVtQ-1; Thu, 09 May 2024 13:42:49 -0400 X-MC-Unique: n23FO_17M5G9qHTLKITVtQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 783EA801211 for ; Thu, 9 May 2024 17:42:49 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.22.18.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F8F1746820; Thu, 9 May 2024 17:42:49 +0000 (UTC) From: David Malcolm To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [PATCH 07/21] analyzer: fix ICE on zero-sized arrays [PR110882] Date: Thu, 9 May 2024 13:42:22 -0400 Message-Id: <20240509174236.2278921-8-dmalcolm@redhat.com> In-Reply-To: <20240509174236.2278921-1-dmalcolm@redhat.com> References: <20240509174236.2278921-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: gcc/analyzer/ChangeLog: PR analyzer/110882 * region.cc (int_size_in_bits): Fail on zero-sized types. gcc/testsuite/ChangeLog: PR analyzer/110882 * gcc.dg/analyzer/pr110882.c: New test. (cherry picked from commit r14-2955-gc62f93d1e0383d) Signed-off-by: David Malcolm --- gcc/analyzer/region.cc | 6 +++++- gcc/testsuite/gcc.dg/analyzer/pr110882.c | 18 ++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/analyzer/pr110882.c diff --git a/gcc/analyzer/region.cc b/gcc/analyzer/region.cc index f982ce67509..c1bfecabd15 100644 --- a/gcc/analyzer/region.cc +++ b/gcc/analyzer/region.cc @@ -395,7 +395,11 @@ int_size_in_bits (const_tree type, bit_size_t *out) } tree sz = TYPE_SIZE (type); - if (sz && tree_fits_uhwi_p (sz)) + if (sz + && tree_fits_uhwi_p (sz) + /* If the size is zero, then we may have a zero-sized + array; handle such cases by returning false. */ + && !integer_zerop (sz)) { *out = TREE_INT_CST_LOW (sz); return true; diff --git a/gcc/testsuite/gcc.dg/analyzer/pr110882.c b/gcc/testsuite/gcc.dg/analyzer/pr110882.c new file mode 100644 index 00000000000..80027184053 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/pr110882.c @@ -0,0 +1,18 @@ +/* { dg-additional-options "-Wno-analyzer-too-complex" } */ + +struct csv_row { + char *columns[0]; +}; + +void +parse_csv_line (int n_columns, const char *columns[]) +{ + for (int n = 0; n < n_columns; n++) { + columns[n] = ((void *)0); + } +} + +void parse_csv_data (int n_columns, struct csv_row *entry) +{ + parse_csv_line(n_columns, (const char **)entry->columns); +} -- 2.26.3