Re: [PATCH] Fortran: improve attribute conflict checking [PR93635]

[Harald Anlauf <anlauf@gmx.de>]

Am 10.05.24 um 21:48 schrieb Harald Anlauf:
> Hi Mikael,
> 
> Am 10.05.24 um 11:45 schrieb Mikael Morin:
>> Le 09/05/2024 à 22:30, Harald Anlauf a écrit :
>>> I'll stop here...
>>>
>> Thanks. Go figure, I have no problem reproducing today.
>> It's PR99798 (and there is even a patch for it).
> 
> this patch has rotten a bit: the type of gfc_reluease_symbol
> has changed to bool, this can be fixed.
> 
> Unfortunately, applying the patch does not remove the ICEs here...

Oops, I take that back!  There was an error on my side applying the
patch; and now it does fix the ICEs after correcting that hickup....

> 
>>> We currently do not recover well from errors, and the prevention
>>> of corrupted namespaces is apparently a goal we aim at.
>>>
>> Yes, and we are not there yet. But at least there is a sensible error
>> message before the crash.
> 
> True.  But having a sensible error before ICEing does not improve
> user experience either.
> 
> Are you planning to work again on PR99798?
> 
> Cheers,
> Harald
> 
>>> Cheers,
>>> Harald
>>>
>>>>> The patch therefore does not require any testsuite update and
>>>>> should not give any other surprises, so it should be very safe.
>>>>> The plan is also to leave the PR open for the time being.
>>>>>
>>>>> Regtesting on x86_64-pc-linux-gnu.  OK for mainline?
>>>>>
>>>>> Thanks,
>>>>> Harald
>>>>>
>>>>
>>>>
>>>
>>
>>
> 
>