* [PATCH] RISC-V: testsuite: Drop march-string in cpymemsi-1.c
@ 2024-05-16 7:59 Christoph Müllner
2024-05-16 8:03 ` Kito Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Müllner @ 2024-05-16 7:59 UTC (permalink / raw)
To: gcc-patches, Kito Cheng, Jim Wilson, Palmer Dabbelt,
Andrew Waterman, Philipp Tomsich, Jeff Law, Vineet Gupta
Cc: Christoph Müllner
The test cpymemsi-1.c is a "dg-do run" test, which does not have
any restrictions for the enabled extensions.
Let's drop the "gc" requirement, so that the test can also be
executed on non-f and non-d targets.
gcc/testsuite/ChangeLog:
* gcc.target/riscv/cpymemsi-1.c: Drop march-string.
Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
---
gcc/testsuite/gcc.target/riscv/cpymemsi-1.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c b/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c
index 983b564ccaf..aee54d9aa00 100644
--- a/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c
+++ b/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c
@@ -1,6 +1,5 @@
/* { dg-do run } */
-/* { dg-options "-march=rv32gc -save-temps -g0 -fno-lto" { target { rv32 } } } */
-/* { dg-options "-march=rv64gc -save-temps -g0 -fno-lto" { target { rv64 } } } */
+/* { dg-options "-save-temps -g0 -fno-lto" } */
/* { dg-additional-options "-DRUN_FRACTION=11" { target simulator } } */
/* { dg-timeout-factor 2 } */
--
2.44.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: testsuite: Drop march-string in cpymemsi-1.c
2024-05-16 7:59 [PATCH] RISC-V: testsuite: Drop march-string in cpymemsi-1.c Christoph Müllner
@ 2024-05-16 8:03 ` Kito Cheng
2024-05-16 8:07 ` Christoph Müllner
0 siblings, 1 reply; 3+ messages in thread
From: Kito Cheng @ 2024-05-16 8:03 UTC (permalink / raw)
To: Christoph Müllner
Cc: gcc-patches, Kito Cheng, Jim Wilson, Palmer Dabbelt,
Andrew Waterman, Philipp Tomsich, Jeff Law, Vineet Gupta
Just one minor question
> diff --git a/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c b/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c
> index 983b564ccaf..aee54d9aa00 100644
> --- a/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c
> +++ b/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c
> @@ -1,6 +1,5 @@
> /* { dg-do run } */
> -/* { dg-options "-march=rv32gc -save-temps -g0 -fno-lto" { target { rv32 } } } */
> -/* { dg-options "-march=rv64gc -save-temps -g0 -fno-lto" { target { rv64 } } } */
> +/* { dg-options "-save-temps -g0 -fno-lto" } */
I know -save-temps -g0 already exists, but I am wondering why we need
those 2 options here?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: testsuite: Drop march-string in cpymemsi-1.c
2024-05-16 8:03 ` Kito Cheng
@ 2024-05-16 8:07 ` Christoph Müllner
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Müllner @ 2024-05-16 8:07 UTC (permalink / raw)
To: Kito Cheng
Cc: gcc-patches, Kito Cheng, Jim Wilson, Palmer Dabbelt,
Andrew Waterman, Philipp Tomsich, Jeff Law, Vineet Gupta
On Thu, May 16, 2024 at 10:03 AM Kito Cheng <kito.cheng@gmail.com> wrote:
>
> Just one minor question
>
> > diff --git a/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c b/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c
> > index 983b564ccaf..aee54d9aa00 100644
> > --- a/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c
> > +++ b/gcc/testsuite/gcc.target/riscv/cpymemsi-1.c
> > @@ -1,6 +1,5 @@
> > /* { dg-do run } */
> > -/* { dg-options "-march=rv32gc -save-temps -g0 -fno-lto" { target { rv32 } } } */
> > -/* { dg-options "-march=rv64gc -save-temps -g0 -fno-lto" { target { rv64 } } } */
> > +/* { dg-options "-save-temps -g0 -fno-lto" } */
>
> I know -save-temps -g0 already exists, but I am wondering why we need
> those 2 options here?
I copied from gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c.
But you are right, we could drop these as well
(gcc/testsuite/gcc.target/powerpc/block-cmp-8.c also did so).
I'll retest/resend without the whole dg-options line.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-16 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-16 7:59 [PATCH] RISC-V: testsuite: Drop march-string in cpymemsi-1.c Christoph Müllner
2024-05-16 8:03 ` Kito Cheng
2024-05-16 8:07 ` Christoph Müllner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).