From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 7077C3870938 for ; Fri, 24 May 2024 13:43:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7077C3870938 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7077C3870938 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716558204; cv=none; b=PE2T7dW6ipGGyFhVj58IjTcVJEPKp8D1vK2LzkgnvCH8kPf1aWdR//kKqV4TXC3TgppDBtCNq7dMdDG/ukz7ZpP9tv2GnJZN1/RGDwCgOaHU++VdbUFOW6XD0gkyqA2haZ1uPQHhMF/M2tcC+ZKJlI6xglpQAjO5r6KmPFu7sYY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716558204; c=relaxed/simple; bh=j45NmqClFUwy5Xn06uuHTtoXTHMwnAEUYV4v605Gl4I=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=GpSowAbefhUGV/xsvmA/1SRrSIzbS2Sa95cjTABUcCH7y42frxMC3OUAX6N8HbYhapjuid5orwi/D+RMiaZajvmeLTwKd2WyYJtqC2QgSEDJHZFR36pQNHpqPWsnY6gMDW+54mldFBinC74Li5s6MCl6q5yRL196Hm1Urz4uCh0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 73C39220E3 for ; Fri, 24 May 2024 13:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716558201; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=cZjsXOWbElVwsb17CE6GT3euTgxyQmIfke6IGBharFM=; b=ZH45Li8r79wCN28chXQKpgwWyfGsLJ9LbfCTlCj2iB6BetTRDxa67KzYtLWiE7e9BxQ25J UngY+50v8T9nsOLBn8dLkqMpEEXJx7NKINA6VpbLYiPjd0W8koHgULQhQA1uIlgOzHMziN jYHr63QSuecHZzdGV+8z9UsZArq82Fk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716558201; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=cZjsXOWbElVwsb17CE6GT3euTgxyQmIfke6IGBharFM=; b=5e7weP2f+OOXovSqRgyM8QnZhUd9PHT4pFAVdihAobvKv8N/8axVTcvT/g3qI3jk1T+run qI70PmXCVfgNYgAQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZH45Li8r; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=5e7weP2f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716558201; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=cZjsXOWbElVwsb17CE6GT3euTgxyQmIfke6IGBharFM=; b=ZH45Li8r79wCN28chXQKpgwWyfGsLJ9LbfCTlCj2iB6BetTRDxa67KzYtLWiE7e9BxQ25J UngY+50v8T9nsOLBn8dLkqMpEEXJx7NKINA6VpbLYiPjd0W8koHgULQhQA1uIlgOzHMziN jYHr63QSuecHZzdGV+8z9UsZArq82Fk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716558201; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=cZjsXOWbElVwsb17CE6GT3euTgxyQmIfke6IGBharFM=; b=5e7weP2f+OOXovSqRgyM8QnZhUd9PHT4pFAVdihAobvKv8N/8axVTcvT/g3qI3jk1T+run qI70PmXCVfgNYgAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5A01613A3D for ; Fri, 24 May 2024 13:43:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id pshXFHmZUGbPHQAAD6G6ig (envelope-from ) for ; Fri, 24 May 2024 13:43:21 +0000 Date: Fri, 24 May 2024 15:43:20 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH 5/5] RISC-V: tree-optimization/65518 - extend fix to SLP MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Message-Id: <20240524134321.5A01613A3D@imap1.dmz-prg2.suse.org> X-Spam-Level: X-Spamd-Result: default: False [-4.42 / 50.00]; BAYES_HAM(-2.91)[99.63%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[tree-vect-stmts.cc:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 73C39220E3 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: -4.42 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This extends the PR65518 workaround to also apply for single-lane SLP. * tree-vect-stmts.cc (get_group_load_store_type): For SLP also check for the PR65518 single-element interleaving case as done in vect_grouped_load_supported. --- gcc/tree-vect-stmts.cc | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index 1c30a0388ca..a01099d3456 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -2154,6 +2154,23 @@ get_group_load_store_type (vec_info *vinfo, stmt_vec_info stmt_info, } overrun_p = true; } + + /* If this is single-element interleaving with an element + distance that leaves unused vector loads around punt - we + at least create very sub-optimal code in that case (and + blow up memory, see PR65518). */ + if (loop_vinfo + && *memory_access_type == VMAT_CONTIGUOUS + && SLP_TREE_LOAD_PERMUTATION (slp_node).exists () + && single_element_p + && maybe_gt (group_size, TYPE_VECTOR_SUBPARTS (vectype))) + { + if (dump_enabled_p ()) + dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location, + "single-element interleaving not supported " + "for not adjacent vector loads\n"); + return false; + } } } else -- 2.35.3