From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=SHBL=M7=kernel.crashing.org=segher@sourceware.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
	by sourceware.org (Postfix) with ESMTP id 7F0E9384477D
	for <gcc-patches@gcc.gnu.org>; Tue, 28 May 2024 22:10:23 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F0E9384477D
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F0E9384477D
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=63.228.1.57
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716934226; cv=none;
	b=lEXiXp+mePVGElRGjAL+2yZy2sA9OvAKSgtIGYx9BcF9bfESRpqRsE9opfBNXbi5PS9itbkvqt4J/EjXW7BnkXPMmcEfsWWwNY+BRtaIms9jt2Et4iHeNJNLaTvUm0EFyIquLEsIwuU+vsW/FvG0o4Oq7IdTqomBmxbfwrpsz6w=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1716934226; c=relaxed/simple;
	bh=oJVPxjQ5IhRq0yYgXU9ACorRZwIgtC2LQeG3dfKLIig=;
	h=Date:From:To:Subject:Message-ID:Mime-Version; b=ioY7wfYmIk4b+yql17I09R2nSvka90ELChpxKCEKlZkF1pog/j2mWH5/2YvderAfsq3+OZdw3538ti8bBrRk9xN94rji82RVbqx7wHBKrBZovzB8hL0hErx5mMExx7ONP+eLTXMY5cZCs3j69lb1MzsJOfaoUsuWaeWehKqnurQ=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from gate.crashing.org (localhost.localdomain [127.0.0.1])
	by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 44SM9M1k030186;
	Tue, 28 May 2024 17:09:23 -0500
Received: (from segher@localhost)
	by gate.crashing.org (8.14.1/8.14.1/Submit) id 44SM9MvS030185;
	Tue, 28 May 2024 17:09:22 -0500
X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f
Date: Tue, 28 May 2024 17:09:22 -0500
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Richard Biener <richard.guenther@gmail.com>
Cc: "Kewen.Lin" <linkw@linux.ibm.com>, HAO CHEN GUI <guihaoc@linux.ibm.com>,
        gcc-patches <gcc-patches@gcc.gnu.org>, David <dje.gcc@gmail.com>,
        Peter Bergner <bergner@linux.ibm.com>,
        Andrew Pinski <pinskia@gmail.com>
Subject: Re: [PATCHv3] Optab: add isfinite_optab for __builtin_isfinite
Message-ID: <20240528220922.GV19790@gate.crashing.org>
References: <936073f2-dfd4-4650-9b28-b905d97be477@linux.ibm.com> <CAFiYyc3wE=xDkrZuvf1KTtdRKVaaW-dYW+ZtRYC1P6+6NMTZ2Q@mail.gmail.com> <61a832c7-795b-581a-aec4-7c88c5e26360@linux.ibm.com> <CAFiYyc2hTa1N5sagLTLBVQp05-6mO9Zy6rmX47eWtPbBk7x9oQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAFiYyc2hTa1N5sagLTLBVQp05-6mO9Zy6rmX47eWtPbBk7x9oQ@mail.gmail.com>
User-Agent: Mutt/1.4.2.3i
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Tue, May 28, 2024 at 02:09:50PM +0200, Richard Biener wrote:
> On Tue, May 28, 2024 at 9:09 AM Kewen.Lin <linkw@linux.ibm.com> wrote:
> > As Haochen's previous reply, I think there are three cases:
> >   1) no optab defined, fold in a generic way;
> >   2) optab defined, SUCC, expand as what it defines;
> >   3) optab defined, FAIL, generate a library call;
> >
> > From above, I had the concern that ports may assume FAILing can
> > fall back with the generic folding, but it's not actually.
> 
> Hmm, but it should.  Can you make that work?

That certainly would be the least surprising!


Segher