From: Segher Boessenkool <segher@kernel.crashing.org>
To: Ajit Agarwal <aagarwa1@linux.ibm.com>
Cc: Alex Coplan <alex.coplan@arm.com>,
Richard Sandiford <richard.sandiford@arm.com>,
"Kewen.Lin" <linkw@linux.ibm.com>,
Michael Meissner <meissner@linux.ibm.com>,
Peter Bergner <bergner@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, rs6000, aarch64, middle-end] Add implementation for different targets for pair mem fusion
Date: Thu, 30 May 2024 16:34:23 -0500 [thread overview]
Message-ID: <20240530213423.GZ19790@gate.crashing.org> (raw)
In-Reply-To: <53ba46de-6c01-4c68-bd98-1ba6950a793a@linux.ibm.com>
Hi!
On Fri, May 31, 2024 at 01:21:44AM +0530, Ajit Agarwal wrote:
> Code is implemented with pure virtual functions to interface with target
> code.
It's not a pure function. A pure function -- by definition -- has no
side effects. These things have side effects.
What you mean is this is *an implementation* for C++ functions without
a generic implementation. An obfuscation some people (like me) would
say. But please call things what they are! So not "pure function".
That has a meaning, and this isn't it.
> * config/aarch64/aarch64-ldp-fusion.cc: Add target specific
> implementation of additional virtual functions added in pair_fusion
> struct.
This does not belong in this patch. Do not send "rs6000" patches that
touch anything outside of config/rs6000/ and similar, certainly not in
config/something-else/!
This would be WAY easier to review (read: AT ALL POSSIBLE) if you
included some detailed rationale and design document.
Segher
next prev parent reply other threads:[~2024-05-30 21:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 19:51 Ajit Agarwal
2024-05-30 21:34 ` Segher Boessenkool [this message]
2024-05-31 8:14 ` Richard Sandiford
2024-05-31 14:19 ` Segher Boessenkool
2024-05-31 9:53 ` Richard Sandiford
2024-05-31 10:28 ` Richard Sandiford
2024-05-31 13:54 ` Ajit Agarwal
2024-05-31 14:38 ` Richard Sandiford
2024-05-31 16:59 ` Ajit Agarwal
2024-06-02 5:52 ` Ajit Agarwal
2024-06-03 8:37 ` Richard Sandiford
2024-06-03 11:05 ` Ajit Agarwal
2024-06-03 11:33 ` Richard Sandiford
2024-06-03 13:47 ` Ajit Agarwal
2024-06-03 14:17 ` Richard Sandiford
2024-06-03 14:34 ` Ajit Agarwal
2024-06-03 14:54 ` Richard Sandiford
2024-06-03 15:58 ` Ajit Agarwal
2024-06-04 16:00 ` Ajit Agarwal
2024-06-02 13:16 ` Ajit Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530213423.GZ19790@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=aagarwa1@linux.ibm.com \
--cc=alex.coplan@arm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=meissner@linux.ibm.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).