From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 5FDE73857340 for ; Tue, 11 Jun 2024 22:25:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5FDE73857340 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5FDE73857340 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718144748; cv=none; b=EGYuQFIhJH0jKb9kIuoBkjasZ6JMrPSyw5l1et1vC3EwMOwhOEfNneYOmZL4mLlTarpb6BmRoZoYFCp3vr7kiTyX4eehek0/I7DBu+1MztCzv7IJK0SgjIVVz50VzAiopwNR3qERlCTU83JY7r1PHMNKmu/nXZmS9oOKe8PX4w4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718144748; c=relaxed/simple; bh=jAJZAOKP+zsDxVfuVEJfVIPtt/OeSt4oACRfJZIn2NY=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=jBYrsnBE0EqnkzUTzkPrqhPYxkXgqyD8IsURNJNETNuNgs+r2h1QzIKmpJl0WzOaEYgzy4WSY1ZDyuChStTrX3p4Cgd/emw1hXJcnPRMAizRbk7V0m+m+vZPc13yQ39desCgShPBM72lsAVD8feHK+LBA4cIqSHGKMkW+gd11ao= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1f8395a530dso2253195ad.0 for ; Tue, 11 Jun 2024 15:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1718144744; x=1718749544; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=I15sjQ8qhpPmMyN2Fg0+j+9ph88nQBIL9toTFBtANc8=; b=kw2nLPABbb3WjSlWz6oRTpowIw8OPm9dlF5RyZ9qloRe2KnpqqdGBctcK+Frfya/iF IVDlcQVidhSxN0CEznOejKyLFu4n8VWw18hnEVWtL8cGh6+l77CL4OgLrwN1GG5jbd0d oj6y1Z+oUc12oDj1YSKfzxIAbx6icY2YynvThjVjJ5+Ur4+zxjK5b+l+jQ/yXM6VDupB XTRhj+QNIBOXmfh31EHtKqA7ejF24RzY2chWja5Ech4s6Ki3BRT7aD7wW9IDed7E+V9n SftP32Z8Fw3sYXcHLR3GolxhDlz5aEjlUzBQdt/O1YYyU0vTVrPMHxBpMsXjeds+6MlU /v/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718144744; x=1718749544; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I15sjQ8qhpPmMyN2Fg0+j+9ph88nQBIL9toTFBtANc8=; b=f5tV/x3Duh+Tx4rH+xvrp4rrqqaJQnyNqCnxadoyRGUHtH67EfGy4QMUanG6aQQxJV YzMRSAfo6tq566BsX6nZDMj/ep6ElpET9VfBpvL/uE4iZ/4qt6tIVO1F25P9hM3RsBLY L1LB46TgiDBnCoYz6O48pYBF1G05aqwiK2V7YdyRDAvoSBGn/WxCRzGP5bg1k4WDwf35 t9t//wmer4C4QFcGdWGq25e4m/966hQlA6CAO2BksV6FlXnAXJeIjTNktBm51RROh4sH 4xaIWa470LbNzlwFv9GRRfZDosfCqENOgLjtHvb0/5xoqztcWfVZuORFkQ8xWxNhN3GT cksQ== X-Gm-Message-State: AOJu0Yx3blGBZNeF+LXUZSETC/jxtqT/4j9qe5iCHcTq878tFBNhreuj pshPJBYYyhH47qJ5GNrTQ9hTqhkQrjS805g7KPTojpXKmBlkoTLoevoa/JpmDJxm8g7oBRrP6f+ M X-Google-Smtp-Source: AGHT+IEipg1wfO5+MgHWfcAqnSmP7a8vyCTcYCHwd34U3fwL+ugB48sLfboEZGSpVAAksHY3qGTjvg== X-Received: by 2002:a17:902:c944:b0:1e4:c8b3:dbaf with SMTP id d9443c01a7336-1f83b671d6bmr2619925ad.33.1718144743953; Tue, 11 Jun 2024 15:25:43 -0700 (PDT) Received: from ewlu.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6f298102bsm69163425ad.73.2024.06.11.15.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 15:25:43 -0700 (PDT) From: Edwin Lu To: gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com, Edwin Lu Subject: [PATCH 0/2] Fix ICE with vwsll combine on 32bit targets Date: Tue, 11 Jun 2024 15:25:30 -0700 Message-Id: <20240611222532.2986116-1-ewlu@rivosinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The following testcases have been failing on rv32 targets since r15-953-gaf4bf422a69: FAIL: gcc.target/riscv/rvv/autovec/binop/vwsll-1.c (internal compiler error: in maybe_legitimize_operand, at optabs.cc:8056) FAIL: gcc.target/riscv/rvv/autovec/binop/vwsll-1.c (test for excess errors) Fix the bug and also robustify our emit_insn by making an assertion check unconditional I'm not sure if this ICE warrants its own separate testcase since it is already being tested. I do have a minimal testcase on hand if we would like to add one. Edwin Lu (2): RISC-V: Fix vwsll combine on rv32 targets RISC-V: Move mode assertion out of conditional branch in emit_insn gcc/config/riscv/autovec-opt.md | 1 + gcc/config/riscv/riscv-v.cc | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) -- 2.34.1