From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 4188A3870899 for ; Thu, 13 Jun 2024 00:57:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4188A3870899 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4188A3870899 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=63.228.1.57 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718240231; cv=none; b=U/Ki9fMOOZemdK7Vt9V1QiNKKcLafMwqWI0A2xrdDJpeOtwTsuaUj3ekRUdL020muHwoAKCXR2+6HllZZgy0p3f7D3sA3JhWXcqk1P3dCVzbQxdmp9sw0H7conitABjtjZFpgKTkeU+LPHx6q9lBXUrhC7N0ImSCknA2hvrFerA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718240231; c=relaxed/simple; bh=DWpMg/xXG4L03PcD8zsTF1P9oztEfQUqCGV3UFYhg5E=; h=Date:From:To:Subject:Message-ID:Mime-Version; b=JBRRh1KjjtaXX2nXSg45MV9/PlhmlBqSqQSn2DBL/XV+KlgB6YF3DUK8oQUmxugNqT2+bUwbH8zwqc/Ra8p4pixnwNWRL48MA1K4KC+MFzlUYO5UndxB0wg6su8My9lk00L2joE3XPsE8HJlKTZ2EwN0UYzwStFFKRYu76KEJg4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 45D0u93Y030570; Wed, 12 Jun 2024 19:56:09 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 45D0u9h7030569; Wed, 12 Jun 2024 19:56:09 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 12 Jun 2024 19:56:09 -0500 From: Segher Boessenkool To: Peter Bergner Cc: "Kewen.Lin" , GCC Patches Subject: Re: [PATCH] testsuite: Fix pr66144-3.c test to accept multiple equivalent insns. [PR115262] Message-ID: <20240613005609.GI19790@gate.crashing.org> References: <20240612200002.GH19790@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jun 12, 2024 at 07:02:31PM -0500, Peter Bergner wrote: > On 6/12/24 3:00 PM, Segher Boessenkool wrote: > >> /* { dg-do compile { target { powerpc64*-*-* } } } */ > > > > Probably should be an "lp64" instead? > > Actually, there is nothing inherently 64-bit about the test case. > I removed the target test altogether and it executes just fine on > our BE system in both 32-bit and 64-bit modes, so I'll just drop > the target test as part of the patch. Ha, even better! > >> /* { dg-require-effective-target powerpc_vsx } */ > > > > This isn't needed either. > > Maybe not strictly needed, but it shields us from users who force > some options to be used via RUNTESTFLAGS env var that can cause the > test case to FAIL. I'm going to leave this for someone else to > clean up. Users can make most tests fail in interesting and exciting ways like that, heh. In general, only realistic settings are supported: things for which hardware exists, an OS exists for, etc. With any other settings many things can fail, and that is Just Fine. Thanks again, Segher