From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 5C9323882059 for ; Thu, 13 Jun 2024 20:56:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C9323882059 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5C9323882059 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718312202; cv=none; b=Bfpis6FXy6q80W0XdsHDkkCHvUTXbVvdN8wWQD1O/lPLKa2cFhxV+qLNA6bkFPLJkciXwbnTX26Sd/8qWuCt5igH912LDrZKC80Dsv5/wRnk5s7RYP7hJhCEaSwsVJfh9HrxelAKIq4v3BmljHHVuHE2NZozp4mzGTixNfNnQNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718312202; c=relaxed/simple; bh=+mSDUrwemMI5pr5QiBSrRHEWUP60ei3IYbfkhqlIJUo=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=lt6Fv8//9/wa78y0TQwzXSojXLMPKqFPTkb/+1vCMpFyxCgEuzSOdXEKL3Dwdtb1AOdpinJw6FPy5qtNSP4fptESsC9ioDM96Wzu2SnHwO+yohsu/NbfDLz+DYMv//3pNM5nhKsyRBl4qxocVpzcqWHdFUk1s5FhxQAOYw2UCBE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1f47f07acd3so14123485ad.0 for ; Thu, 13 Jun 2024 13:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1718312199; x=1718916999; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NlPQahFBn1sJThGYGGnERRPRXKjgpQ9KA8yafy1gLkg=; b=v0bZ7wTlN9+/Wonb3jIgsl+Qj0bb3DHcBduOZeYtOBVrAxRbB51p5hme4dvL7k6VSu Bkcs0MYg2M8XD3QVxDKhKSZ/y6l3F0T3eDDMvga5BiMOjISSKj0OZ1tnBuQl3Q69LLDp 7oIswtsYHk8/e0dgZ0YPkDRiHm8DaqIXOn+51CD8BsagwBC4yxNNERB4MAPSf1zKj3Jd B2NPzLVA5jX44Qw+srPDGRN5j72RqwEBUmYZZbr9yi11+JxjxOAKSFzZBlmXHpslDpKa pmwbuf7Rq1EMACNt0aCbmh+jiDe36KZFV3IHTV6zMz0Guv7/qTH169AOjuXF8M411KiH aFWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718312199; x=1718916999; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NlPQahFBn1sJThGYGGnERRPRXKjgpQ9KA8yafy1gLkg=; b=PMXN1ID5Bd8WAMAiR6yc619LNuu/HdAtMJoyQK3qUIWGaCmUVQffJNkogTHbJudGLo cqoR+ap9BZs+yLUZ5UtAoOLhuf/4OHIYNZRqRSKFAvrHijlMc19DNQ4TYxKuBmbV5L+2 TWoWnbb5gSvr+6KcQCmQVpu0YxVPK4HQCX3qcEQKJNMcM7w0WHrzGXV51qkwzY7tY+1E hjZWGrZn3d8K/KCimlPVkhlbAe02AZwCYJBKuRRZffxEaBLccIKXXxT85S9MmZiH+gOO LHiJ6cagUO3gwTKa4a2+iA2aN0qS05JEzm7elnRJoJoJV6ddH3DXFh+hepFFu/wQtZG6 avkA== X-Gm-Message-State: AOJu0YxcDLiCLn6up6z64/6GWYHP1X7ys8Yqd0gUs1p38pFYMCD4knRl MPCFzpwoVfIQb1eVmaOwn7L5RAv0k0kfoWu5oJjaFHPxkNlOncydEIsNb/DL8W9NfPXpwaiYF4A B X-Google-Smtp-Source: AGHT+IGx3iO6q4vIwjKYIpjiey093U0/szhiMPY8anExTaQIPsbnsAyB6xahJuWoNJ9/4F0DZth5iQ== X-Received: by 2002:a17:902:f54c:b0:1f8:62b2:6225 with SMTP id d9443c01a7336-1f862b26253mr7967685ad.28.1718312198952; Thu, 13 Jun 2024 13:56:38 -0700 (PDT) Received: from ewlu.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855e55c80sm18508355ad.21.2024.06.13.13.56.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 13:56:38 -0700 (PDT) From: Edwin Lu To: gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com, Edwin Lu Subject: [PATCH V2 0/2] Fix ICE with vwsll combine on 32bit targets Date: Thu, 13 Jun 2024 13:56:24 -0700 Message-Id: <20240613205626.244598-1-ewlu@rivosinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The following testcases have been failing on rv32 targets since r15-953-gaf4bf422a69: FAIL: gcc.target/riscv/rvv/autovec/binop/vwsll-1.c (internal compiler error: in maybe_legitimize_operand, at optabs.cc:8056) FAIL: gcc.target/riscv/rvv/autovec/binop/vwsll-1.c (test for excess errors) Fix the bug and also robustify our emit_insn by making an assertion check unconditional I'm not sure if this ICE warrants its own separate testcase since it is already being tested. I do have a minimal testcase on hand if we would like to add one. V2: Remove subreg condition and change assert to internal error Edwin Lu (2): RISC-V: Fix vwsll combine on rv32 targets RISC-V: Move mode assertion out of conditional branch in emit_insn gcc/config/riscv/autovec-opt.md | 3 +-- gcc/config/riscv/riscv-v.cc | 25 +++++++++++++++++++------ 2 files changed, 20 insertions(+), 8 deletions(-) -- 2.34.1