From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 15F26388211C for ; Fri, 14 Jun 2024 00:54:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 15F26388211C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 15F26388211C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::633 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718326461; cv=none; b=ZdAyzyV/RQQdQedC/AjJAi+nOfx+WmTCLnGKHor/0+27J6DSpFgC4JfjNzoOVprUYr0whpnW0kaT1WWLjcT/rAaud9NK1BOd0o9781GchbfiOheXzWe0mm5klHiVJg8pL4e9TM+BXEU75IH9lwh3nBfIDnrfarJEJmyjEgXHNIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718326461; c=relaxed/simple; bh=gwjnIV7JK9KtlhKAV7zZXwL/7yZVdKwkU+/MjuSsjzQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=RpXYONnBjU1Dbigj33Sk+H9NctcPyRgLASTXMWGTJ19lu1ghjfScxY4MEg6nb6gjJWxltxAL8ovn6LgO+C9JIzcjsaQyWiZSdwVQa8UiLWon9siF42Vspka0aUC651tS+xSvGnvlNe5G7tCEuwGjnXaZLQkxhgFRfVmraXGfANE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1f4a0050b9aso15116685ad.2 for ; Thu, 13 Jun 2024 17:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718326457; x=1718931257; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3HJV7V05nw3aGLV9wlzOSepiZPuhe7nEP2sSQoP5zi8=; b=PfzQbThHhIk27ouLtPuOIPYiMPzsW9/vPPoP4pziuiINZLeoTbHYcqWL8a4SQLSRcM M0YasVFe5u9jeNXsOg0OWdZUna3A35CUEcQeXQOOOm01F9tNpu3o2y6WQ/332YWlTvPb C5bvKbOzIyVby/CcQOKCBW5vti8fFLlCYbQbNAftNJfhhRdCrl8rUnz1LlbwT5Yll0ro aZFK/Y4oTTekgtB9vrLVFHfw5zfn7Ld9lj5hNvsAs2LcdjRWKdXOfW0V/sqzsNMCr6mT EZVkRVZtEPD+NmKao+sFrAHd3WbjuzhpeEybu94NlqjXMHIj8JLcYF9M7R2CeZtuWtZ4 n1Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718326457; x=1718931257; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3HJV7V05nw3aGLV9wlzOSepiZPuhe7nEP2sSQoP5zi8=; b=nsxflj64bLdW4o92kGLCMfzSlqITX4pU96wQMdmIcxIoDXzL9nLts7iZ9oIDQn6vc2 SAMwJoIUr79ahuyAdp/+UbOyj/hA59kcLKCewxhDtIXMYeNwA5IZWOdHWDkQQ/fr8URO enZxhAeyYLg6qjwr9+59Dvntp+w6sva1IWBhcr1OCllI7HDJ0dHImz8aLpYCChClnP8w umil7XSIvZZ7YgNMijMfIU3X2gOi5jfbh6BPMDSc/Eb+lsan3LZ/RKYh64FRni/mM3o4 sMW0pq7bPiVHw5t//PTMfM50A0miHiFhDvstkOp/0KRc4P7VnXimmPeHN5NVXsk14slZ sGYA== X-Gm-Message-State: AOJu0YzgzZsMNLdSRkv4u/yDHbdyjhiVfxMVKFJfnW96zBq8Ye5NtgLx GWBdz5t+RLsb+NsHAX2uwqCfUSD32mX71aUWSdhgcULD6TXlbtMtwH5AYg== X-Google-Smtp-Source: AGHT+IFyx5gk8JEJ3bW+BDdvmDU5nhQLwAxoUX3dRKJPX6NYDLpt+X6GXGttUo9C2OUU+4ISb+TtaA== X-Received: by 2002:a17:902:ce8a:b0:1f7:34be:f9b7 with SMTP id d9443c01a7336-1f8625d5496mr15809245ad.14.1718326456737; Thu, 13 Jun 2024 17:54:16 -0700 (PDT) Received: from fedora.hsd1.ca.comcast.net ([2601:646:8002:f840::59da]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f1a4f2sm20457415ad.241.2024.06.13.17.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 17:54:16 -0700 (PDT) From: Collin Funk To: gcc-patches@gcc.gnu.org Cc: Collin Funk Subject: [PATCH] build: Fix missing variable quotes Date: Thu, 13 Jun 2024 17:53:55 -0700 Message-ID: <20240614005409.238318-1-collin.funk1@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When dlopen and pthread_create are in libc the variable is set to "none required", therefore running configure will show the following errors: ./configure: line 8997: test: too many arguments ./configure: line 8999: test: too many arguments ./configure: line 9003: test: too many arguments ./configure: line 9005: test: =: unary operator expected ChangeLog: * configure.ac: Quote variable result of AC_SEARCH_LIBS. * configure: Regenerate. Signed-off-by: Collin Funk --- configure | 10 +++++----- configure.ac | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/configure b/configure index 51576a41f30..6e95b27d9df 100755 --- a/configure +++ b/configure @@ -8994,15 +8994,15 @@ if test "$ac_res" != no; then : fi -if test $ac_cv_search_dlopen = -ldl; then +if test "$ac_cv_search_dlopen" = -ldl; then CRAB1_LIBS="$CRAB1_LIBS -ldl" -elif test $ac_cv_search_dlopen = no; then +elif test "$ac_cv_search_dlopen" = no; then missing_rust_dynlibs="libdl" fi -if test $ac_cv_search_pthread_create = -lpthread; then +if test "$ac_cv_search_pthread_create" = -lpthread; then CRAB1_LIBS="$CRAB1_LIBS -lpthread" -elif test $ac_cv_search_pthread_crate = no; then +elif test "$ac_cv_search_pthread_crate" = no; then missing_rust_dynlibs="$missing_rust_dynlibs, libpthread" fi @@ -19746,7 +19746,7 @@ config.status configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" -Copyright (C) 2012 Free Software Foundation, Inc. +Copyright (C) Free Software Foundation, Inc. This config.status script is free software; the Free Software Foundation gives unlimited permission to copy, distribute and modify it." diff --git a/configure.ac b/configure.ac index 5eda8dcdbf7..88576b31bfc 100644 --- a/configure.ac +++ b/configure.ac @@ -2045,15 +2045,15 @@ missing_rust_dynlibs=none AC_SEARCH_LIBS([dlopen], [dl]) AC_SEARCH_LIBS([pthread_create], [pthread]) -if test $ac_cv_search_dlopen = -ldl; then +if test "$ac_cv_search_dlopen" = -ldl; then CRAB1_LIBS="$CRAB1_LIBS -ldl" -elif test $ac_cv_search_dlopen = no; then +elif test "$ac_cv_search_dlopen" = no; then missing_rust_dynlibs="libdl" fi -if test $ac_cv_search_pthread_create = -lpthread; then +if test "$ac_cv_search_pthread_create" = -lpthread; then CRAB1_LIBS="$CRAB1_LIBS -lpthread" -elif test $ac_cv_search_pthread_crate = no; then +elif test "$ac_cv_search_pthread_crate" = no; then missing_rust_dynlibs="$missing_rust_dynlibs, libpthread" fi -- 2.45.2