From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id D1CB13882658 for ; Fri, 14 Jun 2024 19:43:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1CB13882658 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D1CB13882658 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=116.202.254.214 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718394238; cv=none; b=QtvpYhrUxb00ay+N977Oum/iO8YmE973gR+RdZdFDwY9cksJJP/pfglBkpXc5/WDLq1FEgEXWpw2P1xcCu2t/1GrXqv7Rr7LZoY6wECbCQNybl1OqqtD/7OvT1FpWmPaZumrYlUL4b0t4gLZxt6cOiQ4w1yrUsNKFVYg3TWY+c4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718394238; c=relaxed/simple; bh=faOXhuMP6QC5unHoHlKew2+vbaRa3oHOr1Vm48EwjZU=; h=To:From:Subject:Date:Message-ID:Mime-Version; b=cersLylIEp2ksD+KwFA1ScCWRJIIZtrfATi1ECuXikLAydQIUp/Vv3lDMfoYc4O0rENrmkQMXJqgmF7MHPE+/2AbwMmD05bvUKQigCwNnqPi/JzyayehjiKNPgfpNYIWuSpwokp6+qFcgBcQfqVmSKQfy7FXF8psSJ8i7IDlHH0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1sICq3-0005B1-MJ for gcc-patches@gcc.gnu.org; Fri, 14 Jun 2024 21:43:55 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Harald Anlauf Subject: Re: [Patch, Fortran, 96418] Fix Test coarray_alloc_comp_4.f08 ICEs Date: Fri, 14 Jun 2024 21:43:47 +0200 Message-ID: References: <20240611161238.14634f57@vepi2> <20240614092256.48442c03@vepi2> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Content-Language: en-US In-Reply-To: <20240614092256.48442c03@vepi2> Cc: fortran@gcc.gnu.org X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20240614194347.EGwHJu5ZkEYNl64jOKf_ntGcmQo9dUej8dB4N2pAVZ8@z> Hi Andre, the patch looks fairly simple and obvious, so OK from my side. *** Regarding the testsuite: since you renamed one of the testcases gfortran.dg/coarray_alloc_comp_* and moved it to gfortran.dg/coarray/, I checked and noticed that there are other similar runtime tests for coarrays (while some are compile-time only tests). Do we plan to "clean" this up and move more/all related runtime tests to the coarray/ subdirectory? What is the general opinion on this? *** Thanks for the patch! Harald Am 14.06.24 um 09:22 schrieb Andre Vehreschild: > Hi all, > > I messed up renaming of the coarray_alloc_comp-test. This is fixed in the second > version of the patch. Sorry for the inconvenience. > > Additionally I figured that this patch also fixed PR fortran/103112. > > Regtests ok on x86_64 Fedora 39. Ok for mainline? > > Regards, > Andre > > On Tue, 11 Jun 2024 16:12:38 +0200 > Andre Vehreschild wrote: > >> Hi all, >> >> attached patch has already been present in 2020, but lost my attention. It >> fixes an ICE in the testsuite. The old mails description is: >> >> attached patch fixes PR96418 where the code in the testsuite when compiled >> with -fcoarray=single lead to an ICE. The reason was that the coarray object >> was derefed as an array, but it was no array. Introducing the test for the >> descriptor removes the ICE. >> >> Regtests ok on x86_64-linux/Fedora 39. Ok for mainline? >> >> Regards, >> Andre >> -- >> Andre Vehreschild * Email: vehre ad gmx dot de > > > -- > Andre Vehreschild * Email: vehre ad gmx dot de