From: Edwin Lu <ewlu@rivosinc.com>
To: gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com, Edwin Lu <ewlu@rivosinc.com>
Subject: [PATCH V3 0/2] Fix ICE with vwsll combine on 32bit targets
Date: Mon, 17 Jun 2024 11:33:15 -0700 [thread overview]
Message-ID: <20240617183317.2656046-1-ewlu@rivosinc.com> (raw)
The following testcases have been failing on rv32 targets since
r15-953-gaf4bf422a69:
FAIL: gcc.target/riscv/rvv/autovec/binop/vwsll-1.c (internal compiler
error: in maybe_legitimize_operand, at optabs.cc:8056)
FAIL: gcc.target/riscv/rvv/autovec/binop/vwsll-1.c (test for excess
errors)
Fix the bug and also robustify our emit_insn by making an assertion
check unconditional
I'm not sure if this ICE warrants its own separate testcase since it is
already being tested. I do have a minimal testcase on hand if we would
like to add one.
V2: Remove subreg condition and change assert to internal error
V3: Update the _trunc_scalar splitter as well
Edwin Lu (2):
RISC-V: Fix vwsll combine on rv32 targets
RISC-V: Move mode assertion out of conditional branch in emit_insn
gcc/config/riscv/autovec-opt.md | 6 ++----
gcc/config/riscv/riscv-v.cc | 25 +++++++++++++++++++------
2 files changed, 21 insertions(+), 10 deletions(-)
--
2.34.1
next reply other threads:[~2024-06-17 18:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 18:33 Edwin Lu [this message]
2024-06-17 18:33 ` [PATCH V3 1/2] RISC-V: Fix vwsll combine on rv32 targets Edwin Lu
2024-06-17 23:31 ` Jeff Law
2024-06-18 22:34 ` [Committed " Edwin Lu
2024-06-17 18:33 ` [PATCH V3 2/2] RISC-V: Move mode assertion out of conditional branch in emit_insn Edwin Lu
2024-06-17 23:33 ` Jeff Law
2024-06-18 22:34 ` [Committed " Edwin Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617183317.2656046-1-ewlu@rivosinc.com \
--to=ewlu@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).