public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Marc Poulhiès" <poulhies@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Doug Rupp <rupp@adacore.com>
Subject: [COMMITTED 11/22] ada: Revert conditional installation of signal handlers on VxWorks
Date: Fri, 21 Jun 2024 10:58:07 +0200	[thread overview]
Message-ID: <20240621085819.2485987-11-poulhies@adacore.com> (raw)
In-Reply-To: <20240621085819.2485987-1-poulhies@adacore.com>

From: Doug Rupp <rupp@adacore.com>

The conditional installation resulted in a semantic change, and
although it is likely what is ultimately wanted (since HW interrupts
are being reworked on VxWorks). However it must be done in concert
with other modifications for the new formulation of HW interrupts and
not in isolation.

gcc/ada/

	* init.c [vxworks] (__gnat_install_handler): Revert to
	installing signal handlers without regard to interrupt_state.

Tested on x86_64-pc-linux-gnu, committed on master.

---
 gcc/ada/init.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/gcc/ada/init.c b/gcc/ada/init.c
index acb8c7cc57e..93e73f53c64 100644
--- a/gcc/ada/init.c
+++ b/gcc/ada/init.c
@@ -2100,14 +2100,10 @@ __gnat_install_handler (void)
 
   /* For VxWorks, install all signal handlers, since pragma Interrupt_State
      applies to vectored hardware interrupts, not signals.  */
-  if (__gnat_get_interrupt_state (SIGFPE) != 's')
-     sigaction (SIGFPE,  &act, NULL);
-  if (__gnat_get_interrupt_state (SIGILL) != 's')
-     sigaction (SIGILL,  &act, NULL);
-  if (__gnat_get_interrupt_state (SIGSEGV) != 's')
-     sigaction (SIGSEGV, &act, NULL);
-  if (__gnat_get_interrupt_state (SIGBUS) != 's')
-     sigaction (SIGBUS,  &act, NULL);
+  sigaction (SIGFPE,  &act, NULL);
+  sigaction (SIGILL,  &act, NULL);
+  sigaction (SIGSEGV, &act, NULL);
+  sigaction (SIGBUS,  &act, NULL);
 
 #if defined(__leon__) && defined(_WRS_KERNEL)
   /* Specific to the LEON VxWorks kernel run-time library */
-- 
2.45.1


  parent reply	other threads:[~2024-06-21  8:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21  8:57 [COMMITTED 01/22] ada: Spurious style error with mutiple square brackets Marc Poulhiès
2024-06-21  8:57 ` [COMMITTED 02/22] ada: Fix for Default_Component_Value with declare expressions Marc Poulhiès
2024-06-21  8:57 ` [COMMITTED 03/22] ada: Fix assertion failure on predicate involving access parameter Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 04/22] ada: Predefined arithmetic operators incorrectly treated as directly visible Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 05/22] ada: Fix gnatcheck violation reported after a recent cleanup Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 06/22] ada: Generic formal/actual matching -- misc cleanup Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 07/22] ada: Fix incorrect handling of packed array with aliased composite components Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 08/22] ada: Fix internal error on case expression used as index of array component Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 09/22] ada: Fix missing index check with declare expression Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 10/22] ada: Cannot override inherited function with controlling result Marc Poulhiès
2024-06-21  8:58 ` Marc Poulhiès [this message]
2024-06-21  8:58 ` [COMMITTED 12/22] ada: Small cleanup in processing of primitive operations Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 13/22] ada: Change error message on invalid RTS path Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 14/22] ada: Crash when using user defined string literals Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 15/22] ada: Fix crash in GNATbind during error reporting Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 16/22] ada: Apply fixes to Examine_Array_Bounds Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 17/22] ada: Reject ambiguous function calls in interpolated string expressions Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 18/22] ada: Implement fast modulo reduction for nonbinary modular multiplication Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 19/22] " Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 20/22] ada: Fix bogus Address Sanitizer stack-buffer-overflow on packed record equality Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 21/22] ada: Fix bogus Address Sanitizer stack-buffer-overflow on packed array copy Marc Poulhiès
2024-06-21  8:58 ` [COMMITTED 22/22] ada: Fix internal error on protected type with -gnatc -gnatR Marc Poulhiès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621085819.2485987-11-poulhies@adacore.com \
    --to=poulhies@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rupp@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).