From: Jason Merrill <jason@redhat.com>
To: gcc-patches@gcc.gnu.org
Subject: [pushed] c++: #pragma target and deferred instantiation [PR115403]
Date: Thu, 25 Jul 2024 19:54:23 -0400 [thread overview]
Message-ID: <20240725235505.3394071-1-jason@redhat.com> (raw)
Tested x86_64-pc-linux-gnu, applying to trunk.
Also built highway to check.
-- 8< --
My patch for 109753 applies the current #pragma target/optimize to a
function when we compile it, which was a problem for a template
instantiation deferred until EOF, where different #pragmas are active. So
let's only do this for artificial functions.
PR c++/115403
PR c++/109753
gcc/cp/ChangeLog:
* decl.cc (start_preparsed_function): Only call decl_attributes for
artificial functions.
gcc/testsuite/ChangeLog:
* g++.dg/ext/pragma-target1.C: New test.
---
gcc/cp/decl.cc | 7 +++++--
gcc/testsuite/g++.dg/ext/pragma-target1.C | 6 ++++++
2 files changed, 11 insertions(+), 2 deletions(-)
create mode 100644 gcc/testsuite/g++.dg/ext/pragma-target1.C
diff --git a/gcc/cp/decl.cc b/gcc/cp/decl.cc
index 6b686d75a49..279af21eed0 100644
--- a/gcc/cp/decl.cc
+++ b/gcc/cp/decl.cc
@@ -17882,8 +17882,11 @@ start_preparsed_function (tree decl1, tree attrs, int flags)
doing_friend = true;
}
- /* Adjust for #pragma target/optimize. */
- decl_attributes (&decl1, NULL_TREE, 0);
+ /* Adjust for #pragma target/optimize if this is an artificial function that
+ (probably) didn't go through grokfndecl. We particularly don't want this
+ for deferred instantiations, which should match their template. */
+ if (DECL_ARTIFICIAL (decl1))
+ decl_attributes (&decl1, NULL_TREE, 0);
if (DECL_DECLARED_INLINE_P (decl1)
&& lookup_attribute ("noinline", attrs))
diff --git a/gcc/testsuite/g++.dg/ext/pragma-target1.C b/gcc/testsuite/g++.dg/ext/pragma-target1.C
new file mode 100644
index 00000000000..0ce2438da2f
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/pragma-target1.C
@@ -0,0 +1,6 @@
+// PR c++/115403
+// { dg-do compile { target x86_64-*-* } }
+
+template <typename> __attribute__((always_inline)) inline void AssertEqual() {}
+void TestAllF16FromF32() { AssertEqual<float>(); }
+#pragma GCC target "sse4.1"
base-commit: 29341f21ce1eb7cdb8cd468e4ceb0d07cf2775e0
--
2.45.2
next reply other threads:[~2024-07-25 23:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 23:54 Jason Merrill [this message]
2024-07-26 17:56 ` Patrick Palka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240725235505.3394071-1-jason@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).