public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: gcc-patches@gcc.gnu.org
Cc: fortran@gcc.gnu.org
Subject: Re: [Fortran, Patch, PR110033, v1] Fix associate for coarrays
Date: Thu, 15 Aug 2024 19:39:54 +0200	[thread overview]
Message-ID: <55c51d9a-db46-4895-83b0-89a186e63a21@gmx.de> (raw)
Message-ID: <20240815173954.sFo9ULP7-C9tOYcTTB6ct5fIuz3s0fCVswA0NRUiZ44@z> (raw)
In-Reply-To: <20240815173523.4d01e6ec@vepi2>

Hi Andre,

Am 15.08.24 um 17:35 schrieb Andre Vehreschild:
> Hi Harald, hi Paul,
> 
> thanks for the ok and the suggestions/recommendations on the testcase. I added
> that and commit as: gcc-15-2935-gdbf4c574b92

I didn't notice this while skimming over the patch, but
gcc-testresults has:

../../src-master/gcc/fortran/resolve.cc: In function ‘bool 
resolve_operator(gfc_expr*)’:
../../src-master/gcc/fortran/resolve.cc:4649:22: error: too many 
arguments for format [-Werror=format-extra-args]
  4649 |           gfc_error ("Inconsistent coranks for operator at %%L 
and %%L",
       | 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


The format strings should have contained %L's, not %%L.

A follow-up fix is pre-approved.

Cheers,
Harald



  reply	other threads:[~2024-08-15 17:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-12 12:11 Andre Vehreschild
2024-08-14 10:51 ` Paul Richard Thomas
2024-08-14 19:21 ` Harald Anlauf
2024-08-14 19:21   ` Harald Anlauf
2024-08-15 15:35   ` Andre Vehreschild
2024-08-15 17:39     ` Harald Anlauf [this message]
2024-08-15 17:39       ` Harald Anlauf
2024-08-15 18:30       ` Andre Vehreschild
2024-08-15 18:50         ` Jakub Jelinek
2024-08-15 19:01           ` Andre Vehreschild
2024-08-15 20:52           ` [committed] fortran: Fix bootstrap in resolve.cc [PR116387] Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55c51d9a-db46-4895-83b0-89a186e63a21@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).