From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id D12403857032 for ; Fri, 21 Mar 2025 12:34:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D12403857032 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D12403857032 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742560495; cv=none; b=xcPOI+FbDw1vkowY0G4T9VVRxDxolH3GBS2SNo5fljKI8zowbkOkK+VWNBR7YcOYYFvAUNt/jFgdXW5M0kGD36YAH8hYsMvmE+d14hMmt9Sm35g/mi9LVtn31/HGMZlgPXbvqurLYYD+Zk+OJnMM4zrFKBY12x9K6t93A0S+pAk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742560495; c=relaxed/simple; bh=FVLanDoIJRi0dmNNWnIHcO64tOsbDsyccS7O0lCx5uQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=RjMbigI8YoQDsAN/a6nySFbG5zislH1cKlQolaZUMILKuc7MMhpDmmDAMwGE7bdz2q5M+3p1T8ziX9GMhFnzcIfyruLVCyJoKL06ns0nPyFqR8XRplvqCnz4DUnFGbjRNcZpkzpsxzYXSn6tJJSrRA0xGYiM35DkhdAQDavsAXA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D12403857032 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=gplnJs+6 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-43d04ea9d9aso8921865e9.3 for ; Fri, 21 Mar 2025 05:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1742560425; x=1743165225; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6Nasp3KlTE6aUIfN3O2gBS0rPluGz3ZwAJOt6fcaXZg=; b=gplnJs+6tTUqbCwLxtxR/mA1KeaDzVIk3prGIKlAKAI4QwyxxdkBS+cpiL13riONri RsvlL0wlNDvNkbqzj8WXeT+kiFT0jGmXzdEVaHXFiYUBDCgo6LWtIqMXuQx7P5KHDy9+ TxUOKC9gKsdTOGDQQx+kbTcNk/3j2dlXteY6bW2uCxqZC2UVRjmoJ1Qd6HZVBhQOEL4i 1iUtda2OOMWHf/YO7Okmgr0g7+85G1ZBRMHGoebPh3Iesqrv4TWPgTqbC2z636EiRj/Q uUiwT3w3MSqHIqeJnUt/EB4RA++R0ptsGypZ595vQbbbXhdMRZgBET9LYMq9FWLI30qf SHMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742560425; x=1743165225; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6Nasp3KlTE6aUIfN3O2gBS0rPluGz3ZwAJOt6fcaXZg=; b=bnVbAGtI+E5hzZjAb0L2nCXlfr5tx+7fX4RL4mVos/njbHWSxXu4GQTzuf01Bhbz0s lE6hoMgpMsl/dSPRPdxzmYMyAybigrH5xKeZ4JXL+Fcx3P03tH6Yk6+rPaF9tD8NkXo2 Ao47uErs3x9leWyPdOI5RZKRBtVyRvZarE4puDiKDu/hKAV/m6o+oNMMP382hq5hnxSk q5L7qXHrZJKrcXSMenJV0ZjspbOi+ryb61P3+qR1q6vwBFYDoc0p6wzsnIBaffxEzjhm BqBwcBVZeLeIaQN3ARfvhpUEenBNLLWB5Ps9H6UrqVRDB0SB3DiyNyLNzNMiPW3V6zpg A73g== X-Gm-Message-State: AOJu0YyoxjFQZ+RQQhbrKIdNo5zGNLAXtCdSdgxirWi1SKIDYSM1XKmy iYw9+XtkxhflZZic57jX3Z8qK0aDq1b6TeQTZa7DUOS4zaRlGpSMBnEg9mpCFrZel5kpFteZUz6 4Jg== X-Gm-Gg: ASbGncvO1+GMpKjmT5Mb7kmE2be/riga7TS9hWF0LuqxEDX5k1iZtYguGLpuH9B0z6C F4zOuiUo5B8QyuuU7JtOrgUN7JM+CUT4rTnyBya9GqQ5yOM9lgAOG3f2EGjrKlWS6Lot+GtGpac 7DnBa5xzGa209L7f3c2MuMgn+kUV9vZYfn4TDJl7fug9eFIn6NSoxQhTDZM553EJfWhKHp4Sqfr 2YvPH6VhOnOdW26izpFJKwT7W5XLtXOGc2+t3nbs6DRlgjZedrNk/Q5z7Jv5BlAN1wO49NJAK6Y DY6hybM2CuFMe/9VARdrIesnZ+GhmxvdKmhACTqPnf6nZ7kjGXzhgNte X-Google-Smtp-Source: AGHT+IEPtbJNieZUe+ETyqdegdyFFfig3QfcEEvWrqGR5fRzQWtUfJX3l/4neILvIZpWxxZwg3uDYw== X-Received: by 2002:a05:600c:138a:b0:43d:224:86b5 with SMTP id 5b1f17b1804b1-43d509e38eemr27322635e9.4.1742560425290; Fri, 21 Mar 2025 05:33:45 -0700 (PDT) Received: from platypus.lan ([2a04:cec0:1901:7a99:be55:efb3:1ec6:8ea7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d440ed4d9sm76950305e9.33.2025.03.21.05.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 05:33:44 -0700 (PDT) From: arthur.cohen@embecosm.com To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Arthur Cohen Subject: [COMMITTED 084/146] gccrs: typecheck: Add note about erorring out on additional trait bounds. Date: Fri, 21 Mar 2025 13:06:25 +0100 Message-ID: <20250321123226.184882-85-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250321123226.184882-1-arthur.cohen@embecosm.com> References: <20250321123226.184882-1-arthur.cohen@embecosm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Arthur Cohen If additional trait bounds aren't auto traits, then the typechecker must error out (Rust-GCC#3008) gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-type.cc: Add TODO note. --- gcc/rust/typecheck/rust-hir-type-check-type.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gcc/rust/typecheck/rust-hir-type-check-type.cc b/gcc/rust/typecheck/rust-hir-type-check-type.cc index e9859a71f83..e9207effafb 100644 --- a/gcc/rust/typecheck/rust-hir-type-check-type.cc +++ b/gcc/rust/typecheck/rust-hir-type-check-type.cc @@ -757,6 +757,11 @@ TypeCheckType::visit (HIR::TraitObjectType &type) std::vector specified_bounds; for (auto &bound : type.get_type_param_bounds ()) { + // TODO: here we need to check if there are additional bounds that aren't + // auto traits. this is an error. for example, `dyn A + Sized + Sync` is + // okay, because Sized and Sync are both auto traits but `dyn A + Copy + + // Clone` is not okay and should error out. + if (bound->get_bound_type () != HIR::TypeParamBound::BoundType::TRAITBOUND) continue; -- 2.45.2