From: Surya Kumari Jangala <jskumari@linux.vnet.ibm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: vmakarov@redhat.com, Peter Bergner <bergner@linux.ibm.com>
Subject: [PATCH] ira: update allocated_hardreg_p[] in improve_allocation() [PR110254]
Date: Fri, 21 Jul 2023 15:43:51 +0530 [thread overview]
Message-ID: <202aea78-0a16-c78b-206c-824ba7bab65d@linux.vnet.ibm.com> (raw)
The improve_allocation() routine does not update the
allocated_hardreg_p[] array after an allocno is assigned a register.
If the register chosen in improve_allocation() is one that already has
been assigned to a conflicting allocno, then allocated_hardreg_p[]
already has the corresponding bit set to TRUE, so nothing needs to be
done.
But improve_allocation() can also choose a register that has not been
assigned to a conflicting allocno, and also has not been assigned to any
other allocno. In this case, allocated_hardreg_p[] has to be updated.
2023-07-21 Surya Kumari Jangala <jskumari@linux.ibm.com>
gcc/
PR rtl-optimization/PR110254
* ira-color.cc (improve_allocation): Update array
---
diff --git a/gcc/ira-color.cc b/gcc/ira-color.cc
index 1fb2958bddd..5807d6d26f6 100644
--- a/gcc/ira-color.cc
+++ b/gcc/ira-color.cc
@@ -3340,6 +3340,10 @@ improve_allocation (void)
}
/* Assign the best chosen hard register to A. */
ALLOCNO_HARD_REGNO (a) = best;
+
+ for (j = nregs - 1; j >= 0; j--)
+ allocated_hardreg_p[best + j] = true;
+
if (internal_flag_ira_verbose > 2 && ira_dump_file != NULL)
fprintf (ira_dump_file, "Assigning %d to a%dr%d\n",
best, ALLOCNO_NUM (a), ALLOCNO_REGNO (a));
next reply other threads:[~2023-07-21 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 10:13 Surya Kumari Jangala [this message]
2023-08-01 5:20 ` [PING][PATCH] " Surya Kumari Jangala
2023-08-02 13:23 ` Vladimir Makarov
2023-08-18 16:51 ` Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202aea78-0a16-c78b-206c-824ba7bab65d@linux.vnet.ibm.com \
--to=jskumari@linux.vnet.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).