From: "Martin Liška" <mliska@suse.cz>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] options: Fix variable tracking option processing.
Date: Mon, 11 Oct 2021 15:21:20 +0200 [thread overview]
Message-ID: <202e07b3-e8d5-85e2-c0a5-8a40a61d7175@suse.cz> (raw)
In-Reply-To: <CAFiYyc2AbWrSOV+pWa2muC5YVfw2PfwYLAZAqF8GemY5aP9iVQ@mail.gmail.com>
On 10/11/21 15:05, Richard Biener wrote:
>> + if (!opts_set->x_flag_var_tracking)
>> + opts->x_flag_var_tracking = optimize >= 1;
> That's still not equivalent to the old code for -fvar-tracking-uninit which
> sets opts->x_flag_var_tracking to 1 and the old code checked that
> for AUTOINIT_VALUE but you override it here for -O0.
>
Do you mean the newly added code:
+ if (!opts_set->x_flag_var_tracking)
+ opts->x_flag_var_tracking = optimize >= 1;
that should be equivalent to:
- if (flag_var_tracking == AUTODETECT_VALUE)
- flag_var_tracking = optimize >= 1;
? Or do I miss something?
Thanks,
Martin
next prev parent reply other threads:[~2021-10-11 13:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 11:01 Martin Liška
2021-10-11 13:05 ` Richard Biener
2021-10-11 13:21 ` Martin Liška [this message]
2021-10-11 13:45 ` Richard Biener
2021-10-12 15:21 ` Martin Liška
2021-10-13 8:47 ` Richard Biener
2021-10-13 11:59 ` Martin Liška
2021-10-13 12:50 ` Richard Biener
2021-10-13 13:12 ` Martin Liška
2021-10-13 13:29 ` Richard Biener
2021-10-14 11:10 ` Martin Liška
2021-10-14 12:07 ` Richard Biener
2021-10-15 15:22 ` Martin Liška
2021-10-19 9:12 ` Richard Biener
2021-10-19 9:34 ` Martin Liška
2021-10-19 10:53 ` Richard Biener
2021-10-20 8:51 ` Martin Liška
2021-10-21 9:57 ` Richard Biener
2021-10-21 13:14 ` Martin Liška
2021-10-21 13:17 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202e07b3-e8d5-85e2-c0a5-8a40a61d7175@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).