From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 049EA3858D38 for ; Thu, 11 Apr 2024 14:53:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 049EA3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 049EA3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712847225; cv=none; b=XVLmPyO2a2YAdLxR5037oeWj6EMKNnxPMvZq/ffv5cpUx2DHTUaEL9okQJFnFLd9fbNEM/8gRjxsApVRoT0eYqqMA1jvsXpw6s5Dpt67WSO5B+R5cmQjWiLUehXUlREoFqRH8NbsEI6liFyyitpIDO7+ZUyNCf/CzcQNJM4Cg00= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712847225; c=relaxed/simple; bh=yP5bI2jKwgWXeytx3Wvc/24Uygc0izWieNEwS2gx2tM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: Mime-Version:Subject:Date:Message-Id:To; b=xZEHvmFLaZVBQIX6lUSH9Wy43dowe1S5IlYceQkuLI4iFwkXUemNlPll58URO0IaQqMgiU/1vprnhWoaE7WzIUgHlpGhbyuo/yKCRY3fd2XxhnHbOIj/MG1HJKJBoP0MHKRsqQjWKYSPLc5giYEk/lbowpwRvg4LK+PfQOFY+L0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E9E595CEC6; Thu, 11 Apr 2024 14:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712847223; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F+Y75ibT1ndwaiBJEwPbOU3uqRpuSdxgwNoZOEX+cYY=; b=Wa1j4nROvUiLpIxdT57UAaNly+MfunJAguBEPv3jByNAHvgMw071IfCsPQbKsm3N0UbUQL OfaAqBkVBW+RxsRFQZ4MvnAggwBp02+HeNp5VeOvWyOmSQjcHgI3CfLrnQSqN2nPSQk82g bZ/Jt6Ala7syhOzFy8Bl+iyiixJbehs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712847223; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F+Y75ibT1ndwaiBJEwPbOU3uqRpuSdxgwNoZOEX+cYY=; b=zS6ooOnE6QYIlBlrmAETswOffAYFvrqyglYXDjicP848JVbAlPmVcWQ+HPHbDm8L9dJ30d Iae17qsG1mKIZZDg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WulC2FZU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xwyWh5GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712847222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F+Y75ibT1ndwaiBJEwPbOU3uqRpuSdxgwNoZOEX+cYY=; b=WulC2FZU/vU+RJwcHZ47Eh1w82QSOzwX5lTfxfjfS0THfp7Z4L9S02zf9xZOrREUsHUJuM Ui2BGZQy+df0vtemRyXAYEqYQRD0CHpWd2urmai9bDp8+bcxvH6Y8HgXXQt0LQFCIidUSk Xy3ugE57fOWkjy6Vk81ocq706LX3j7A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712847222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F+Y75ibT1ndwaiBJEwPbOU3uqRpuSdxgwNoZOEX+cYY=; b=xwyWh5GBIpEV2tZL6m9Z6FMj8SggqKMBTs5Dnp5ChonH5GgdKiNA/y56V0h+dT9vV4M2hL G3evu1JRx+DJAPDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C6F6F13685; Thu, 11 Apr 2024 14:53:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 7MuLMHb5F2YVTwAAD6G6ig (envelope-from ); Thu, 11 Apr 2024 14:53:42 +0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: Combine patch ping Date: Thu, 11 Apr 2024 16:53:31 +0200 Message-Id: <2054CAD0-748D-4B24-9F2B-733A525DE127@suse.de> References: <20240411140002.GO19790@gate.crashing.org> Cc: Uros Bizjak , gcc-patches@gcc.gnu.org, Jeff Law In-Reply-To: <20240411140002.GO19790@gate.crashing.org> To: Segher Boessenkool X-Mailer: iPhone Mail (21E236) X-Spam-Score: -4.51 X-Rspamd-Action: no action X-Rspamd-Queue-Id: E9E595CEC6 X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gmail.com,gcc.gnu.org]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; APPLE_IOS_MAILER_COMMON(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim] X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 11.04.2024 um 16:03 schrieb Segher Boessenkool : >=20 > =EF=BB=BFOn Wed, Apr 10, 2024 at 08:32:39PM +0200, Uros Bizjak wrote: >>> On Wed, Apr 10, 2024 at 7:56=E2=80=AFPM Segher Boessenkool >>> wrote: >>> This is never okay. You cannot commit a patch without approval, *ever*.= >=20 > This is the biggest issue, to start with. It is fundamental. I have approved the patch as you might have noticed. Richard=20 >>> That patch is also obvious -- obviously *wrong*, that is. There are >>> big assumptions everywhere in the compiler how a CC reg can be used. >>> This violates that, as explained elsewhere. >>=20 >> Can you please elaborate what is wrong with this concrete patch. >=20 > The explanation of the patch is contradictory to how RTL works at all, > so it is just wrong. It might even do something sane, but I didn't get > that far at all! >=20 > Write good email explanations, and a good proposed commit message. > Please. It is the only one people can judge a patch. Well, apart > from doing everything myself from first principles, ignoring everything > you said, just looking at the patch itself, but that is a hundred times > more work. I don't do that. >=20 >> The >> part that the patch touches has several wrong assumptions, and the >> fixed "???" comment just emphasizes that. I don't see what is wrong >> with: >>=20 >> (define_insn "@pushfl2" >> [(set (match_operand:W 0 "push_operand" "=3D<") >> (unspec:W [(match_operand 1 "flags_reg_operand")] >> UNSPEC_PUSHFL))] >> "GET_MODE_CLASS (GET_MODE (operands[1])) =3D=3D MODE_CC" >> "pushf{}" >> [(set_attr "type" "push") >> (set_attr "mode" "")]) >=20 > What does it even mean? What is a flags:CC? You always always always > need to say what is *in* the flags, if you want to use it as input > (which is what unspec does). CC is weird like this. Most targets do > not have distinct physical flags for every condition, only a few > conditions are "alive" at any point in the program! >=20 >> it is just a push of the flags reg to the stack. If the push can't be >> described in this way, then it is the middle end at fault, we can't >> just change modes at will. >=20 > But that is not what this describes: it operates on the flags register > in some unspecified way, and pushes the result of *that* to the stack. >=20 > (Stack pointer modification is not described here btw, should it be? Is > that magically implemented by the backend some way, via type=3Dpush > perhaps?) >=20 >=20 > Segher