From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 59FBB3870891 for ; Fri, 24 Mar 2023 17:58:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 59FBB3870891 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679680713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9mqQy3LOWgFoaeMv+9msiUDNSNlir2c7z8wFnnLHpu4=; b=ccNAfKp27zgE5fp/Oc/16UD2JnMHxyw+HrlEgW0aFwQ8UrToeaGQQC8mco78YB8S/FBRug zhQX6yOg3JXV9eSNVOoxdPUpUyLHoHYBqhW5TvQrbHnBccDazR3I+07DE5W1KKIbjW0PnB 6ySu8dgRE2amRdskBp7bCpNEeteZ1Qs= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-rxHi12ZrPTKITK7UYbmRoQ-1; Fri, 24 Mar 2023 13:58:29 -0400 X-MC-Unique: rxHi12ZrPTKITK7UYbmRoQ-1 Received: by mail-qv1-f69.google.com with SMTP id z14-20020a0cd78e000000b005adc8684170so1377693qvi.3 for ; Fri, 24 Mar 2023 10:58:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679680709; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9mqQy3LOWgFoaeMv+9msiUDNSNlir2c7z8wFnnLHpu4=; b=vNfc0Pez95hbWaeURZzGjIaWnqaj2/pOjPrwmR/G2LkHSdV0aFr2PQaiQyMC1m3M14 X+LGPGmV2cp7n2kfhq4teVBYsdr1N+CnwYiUHl1iCBim4x6Yjz84A4D78yLV9lqhOJtK cac9U4y7r1nn7IYp8RoHn1qDFgesfh/H9MGYnrPREV/GP4llH8n8mX9QyudD3y51CRl2 EnNWvtxJ0m1XIhppaolv6nHIzvs9fwdhZjxmwFVQumuEYZlHLFiWQoJ5/yr+w+PH3bhq rhdFqF5DAAhp44qR39UaZXalqP328Sk8DeZiwPNqhZK7VLPuB69yk48IquO8VdwybhVZ ypAw== X-Gm-Message-State: AAQBX9dYBJHTiIfAP1BwdTriIyFuGKsR2bOgtDZe2/oRvVSg2ZcXLxI/ Rt07GVd5VSdALJeZzGm+S7x9nkOgagx/zmNj0PYZVAZNK2+WWZaUVCQMK7F92I4Ibh0b175W4aW vXcoE6F1j4BqAn2j0Sw== X-Received: by 2002:a05:6214:4012:b0:5c1:b700:2caa with SMTP id kd18-20020a056214401200b005c1b7002caamr5184640qvb.26.1679680709329; Fri, 24 Mar 2023 10:58:29 -0700 (PDT) X-Google-Smtp-Source: AKy350YgYiStVO8eH5hozI4ysfkqgV4/SnCpZa4nrhtrbWoV29++HmJvEYWPpE5sTWZOPPkth6rj0A== X-Received: by 2002:a05:6214:4012:b0:5c1:b700:2caa with SMTP id kd18-20020a056214401200b005c1b7002caamr5184617qvb.26.1679680709105; Fri, 24 Mar 2023 10:58:29 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id pe6-20020a056214494600b005dd8b9345a4sm834776qvb.60.2023.03.24.10.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 10:58:28 -0700 (PDT) Message-ID: <2061ea8e2d95d4904db84de34b7b25a0f426a4d9.camel@redhat.com> Subject: Re: [PATCH v2] C, ObjC: Add -Wunterminated-string-initialization From: David Malcolm To: Alejandro Colomar , gcc-patches@gcc.gnu.org Cc: Alejandro Colomar , Doug McIlroy , "G. Branden Robinson" , Ralph Corderoy , Dave Kemper , Larry McVoy , Andrew Pinski , Jonathan Wakely , Andrew Clayton , Martin Uecker Date: Fri, 24 Mar 2023 13:58:27 -0400 In-Reply-To: <4ba61ffe-2322-728f-871f-930216b6a128@gmail.com> References: <20230324133928.14753-1-alx@kernel.org> <7d57dcfbc21caa2c6d9ac1118f4f6a34a8fb341c.camel@redhat.com> <4ba61ffe-2322-728f-871f-930216b6a128@gmail.com> User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2023-03-24 at 18:45 +0100, Alejandro Colomar wrote: > Hi David, >=20 > On 3/24/23 15:53, David Malcolm wrote: > > On Fri, 2023-03-24 at 14:39 +0100, Alejandro Colomar via Gcc- > > patches > > wrote: > > > Warn about the following: > > >=20 > > > =C2=A0=C2=A0=C2=A0 char=C2=A0 s[3] =3D "foo"; > > >=20 > [...] >=20 > > > --- > > >=20 > > > Hi, > >=20 > > Hi Alex, thanks for the patch. >=20 > :) >=20 > >=20 > > >=20 > > > I sent v1 to the wrong list.=C2=A0 This time I've made sure to write > > > to > > > gcc-patches@. > >=20 > > Note that right now we're deep in bug-fixing/stabilization for GCC > > 13 > > (and trunk is still tracking that effort), so your patch might be > > more > > suitable for GCC 14. >=20 > Sure, no problem.=C2=A0 Do you have a "next" branch where you pick patche= s > for after the release, or should I resend after the release?=C2=A0=C2=A0 We don't; resending it after release is probably best. > Is > discussion of a patch reasonable now, or is it too much distracting > from your stabilization efforts? FWIW I'd prefer to postpone the discussion until after we branch for the release. >=20 > >=20 > > >=20 > > > v2 adds some draft of a test, as suggested by Martin.=C2=A0 However, = I > > > don't > > > know yet how to write those, so the test is just a draft.=C2=A0 But I > > > did > > > test the feature, by compiling GCC and compiling some small > > > program > > > with > > > it. > >=20 > > Unfortunately the answer to the question "how do I run just one > > testcase in GCC's testsuite" is rather non-trivial; FWIW I've > > written > > up some notes on working with the GCC testsuite here: > > https://gcc-newbies-guide.readthedocs.io/en/latest/working-with-the-tes= tsuite.html >=20 > Hmm, I'll try following that; thanks!=C2=A0 Is there anything obvious tha= t > I might have missed, at first glance? The main thing is that there's a difference between compiling the test case "by hand", versus doing it through the test harness - the latter sets up the environment in a particular way, injects a particular set of flags, etc etc. Dave