From: Gabriel Dos Reis <dosreis@gmail.com>
To: Marco Poletti <poletti.marco@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: gcc/cp/pt.c: use ngettext() when needed
Date: Wed, 17 Feb 2010 17:06:00 -0000 [thread overview]
Message-ID: <206fcf961002170906l1bdca005h3833890d35d7db5c@mail.gmail.com> (raw)
In-Reply-To: <ae2276fe1002170723oc5b5d12y74ada84ecc3b026e@mail.gmail.com>
On Wed, Feb 17, 2010 at 9:23 AM, Marco Poletti <poletti.marco@gmail.com> wrote:
> In the file pt.c, there were translatable strings like "redeclared
> with %d template parameter(s)" that are hard to translate.
> Instead, it should use the ngettext() function to allow more flexible
> translations.
> I've added two functions inform_translated() and error_translated() to
> diagnostic.c, that are called by pt.c.
> This is my second patch to GCC, I could have done something wrong.
> Critics are very appreciated.
I'm uncomfortable with adding these two functions.
It is possible to just call a preprocessor ngettext() first and give the
result to error() or inform()?
next prev parent reply other threads:[~2010-02-17 17:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 15:23 Marco Poletti
2010-02-17 15:25 ` Marco Poletti
2010-02-17 17:06 ` Gabriel Dos Reis [this message]
2010-02-17 18:02 ` Marco Poletti
2010-02-17 18:29 ` Paolo Bonzini
2010-02-17 20:07 ` Marco Poletti
2010-02-17 21:26 ` Joseph S. Myers
2010-02-17 21:32 ` Marco Poletti
2010-02-17 23:23 ` Paolo Bonzini
2010-02-18 14:33 ` Marco Poletti
2010-02-18 14:40 ` Jakub Jelinek
2010-02-18 14:49 ` Marco Poletti
2010-02-22 9:38 ` Marco Poletti
2010-02-24 6:47 ` Shujing Zhao
2010-02-24 6:57 ` Paolo Bonzini
2010-02-24 8:55 ` Shujing Zhao
2010-02-24 10:22 ` Paolo Bonzini
2010-02-26 7:30 ` Gabriel Dos Reis
2010-02-26 7:31 ` Marco Poletti
2010-02-26 9:32 ` Gabriel Dos Reis
2010-02-26 9:43 ` Paolo Bonzini
2010-02-26 9:56 ` Gabriel Dos Reis
2010-02-26 10:03 ` Jakub Jelinek
2010-02-26 10:04 ` Gabriel Dos Reis
2010-02-26 10:09 ` Shujing Zhao
2010-02-26 10:42 ` Paolo Bonzini
2010-02-26 10:43 ` Jakub Jelinek
2010-03-01 10:00 ` Shujing Zhao
2010-03-01 10:16 ` Shujing Zhao
2010-03-01 15:12 ` Gabriel Dos Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=206fcf961002170906l1bdca005h3833890d35d7db5c@mail.gmail.com \
--to=dosreis@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdr@integrable-solutions.net \
--cc=poletti.marco@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).