From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-257674-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 28795 invoked by alias); 26 Feb 2010 07:31:47 -0000
Received: (qmail 28774 invoked by uid 22791); 26 Feb 2010 07:31:45 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40
X-Spam-Check-By: sourceware.org
Received: from qw-out-1920.google.com (HELO qw-out-1920.google.com) (74.125.92.145)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Feb 2010 07:31:41 +0000
Received: by qw-out-1920.google.com with SMTP id 14so164864qwa.14         for <gcc-patches@gcc.gnu.org>; Thu, 25 Feb 2010 23:31:39 -0800 (PST)
MIME-Version: 1.0
Received: by 10.229.130.206 with SMTP id u14mr226538qcs.74.1267169499652; Thu,  	25 Feb 2010 23:31:39 -0800 (PST)
In-Reply-To: <ae2276fe1002252313w3d435534ge5f22627b898225a@mail.gmail.com>
References: <ae2276fe1002170723oc5b5d12y74ada84ecc3b026e@mail.gmail.com> 	 <ae2276fe1002171332i74fd4224k7f41d97e0bf0a4f8@mail.gmail.com> 	 <f865508f1002171522q1f58844bve8b0fbbde5f431df@mail.gmail.com> 	 <ae2276fe1002180633t255a4356oe325e14154224ce1@mail.gmail.com> 	 <20100218144545.GV2817@tyan-ft48-01.lab.bos.redhat.com> 	 <ae2276fe1002180649v5d717bf6t28a8c98c458a130d@mail.gmail.com> 	 <ae2276fe1002220125m9189b02g98e6279a381fd4b3@mail.gmail.com> 	 <4B84A60B.5020709@oracle.com> 	 <206fcf961002252308t3883270bpb5d7cd0fd02bf2d@mail.gmail.com> 	 <ae2276fe1002252313w3d435534ge5f22627b898225a@mail.gmail.com>
Date: Fri, 26 Feb 2010 09:32:00 -0000
Message-ID: <206fcf961002252331k7f390be1jc96a7025bc34d410@mail.gmail.com>
Subject: Re: gcc/cp/pt.c: use ngettext() when needed
From: Gabriel Dos Reis <gdr@integrable-solutions.net>
To: Marco Poletti <poletti.marco@gmail.com>
Cc: Shujing Zhao <pearly.zhao@oracle.com>, Jakub Jelinek <jakub@redhat.com>,  	Paolo Bonzini <bonzini@gnu.org>, "Joseph S. Myers" <joseph@codesourcery.com>, gcc-patches@gcc.gnu.org,  	Paolo Carlini <paolo.carlini@oracle.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2010-02/txt/msg01121.txt.bz2

On Fri, Feb 26, 2010 at 1:13 AM, Marco Poletti <poletti.marco@gmail.com> wr=
ote:
> 2010/2/26 Gabriel Dos Reis <gdr@integrable-solutions.net>:
>> On Tue, Feb 23, 2010 at 10:07 PM, Shujing Zhao <pearly.zhao@oracle.com> =
wrote:
>>> On 02/22/2010 05:25 PM, Marco Poletti wrote:
>>>>>
>>>>> @@ -112,6 +112,8 @@ function keyword_option(line) {
>>>>> =A0 =A0else if (args ~ /c$/)
>>>>> =A0 =A0 =A0 format=3D"c-format"
>>>>>
>>>>> + =A0 =A0if (name ~ /_n$/) n =3D n "," (n + 1)
>>>>> +
>>>>> =A0 =A0if (n =3D=3D 1) { keyword =3D "--keyword=3D" name }
>>>>> =A0 =A0else { keyword =3D "--keyword=3D" name ":" n }
>>>>> =A0 =A0if (format) {
>>>>>
>>>>
>>> Marco, xgettext can't accept the --flag argument that have more than one
>>> argnums. It will have the argnums like 2,3 if the above code added.
>>>
>>> How about to only use the conditional expression like
>>>
>>> =A0 =A0 =A0error (TREE_VEC_LENGTH (parms) > 1
>>> =A0 =A0 =A0 =A0 =A0 =A0 ? G_("redeclared with %d template parameters")
>>> =A0 =A0 =A0 =A0 =A0 =A0 : G_("redeclared with %d template parameter"),
>>> =A0 =A0 =A0 =A0 =A0 =A0 TREE_VEC_LENGTH (parms));
>>>
>>> it changed less to fix this problem.
>>
>> this is close to what I originally had in mind
>>
>>>
>>> Pearly
>>>
>>
>
> So, can this be committed?

by "this", do you mean the suggestion of error() with the G_
translation?