From: Eric Botcazou <ebotcazou@adacore.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix PR55882
Date: Thu, 10 Jan 2013 12:23:00 -0000 [thread overview]
Message-ID: <2077311.nCd1FQqJgT@polaris> (raw)
In-Reply-To: <alpine.LNX.2.00.1301101033550.6889@zhemvz.fhfr.qr>
> Going over this what's strange as well is that we adjust MEM_SIZE
> with bitpos, too. At least when the MEM has non-BLKmode this
> means that MEMs mode and MEM_SIZE is inconsistent? Or how do
> a MEMs mode and MEM_SIZE relate?
Yes, the MEM attributes are incomplete/inconsistent between the call to
set_mem_attributes_minus_bitpos and the subsequent adjustment by bitpos.
That's why only the final result should matter and need be correct.
Let me try to forge my own opinion on the PR before answering further.
--
Eric Botcazou
next prev parent reply other threads:[~2013-01-10 12:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 12:00 Richard Biener
2013-01-09 20:47 ` Eric Botcazou
2013-01-10 9:18 ` Richard Biener
2013-01-10 10:05 ` Richard Biener
2013-01-10 10:54 ` Richard Biener
2013-01-10 12:23 ` Eric Botcazou [this message]
2013-01-10 13:24 ` Michael Matz
2013-01-10 13:55 ` Richard Biener
2013-01-10 18:53 ` Eric Botcazou
2013-01-11 10:25 ` Richard Biener
2013-01-15 12:49 ` Richard Biener
2013-01-15 14:44 ` Eric Botcazou
2013-01-15 14:50 ` Richard Biener
2013-01-15 23:35 ` Eric Botcazou
2013-01-16 9:27 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2077311.nCd1FQqJgT@polaris \
--to=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).