From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19146 invoked by alias); 10 Jan 2013 12:23:19 -0000 Received: (qmail 19136 invoked by uid 22791); 10 Jan 2013 12:23:19 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Jan 2013 12:23:15 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 6237D290060; Thu, 10 Jan 2013 13:23:23 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OCI4dY45J3oa; Thu, 10 Jan 2013 13:23:23 +0100 (CET) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 2D43A290006; Thu, 10 Jan 2013 13:23:23 +0100 (CET) From: Eric Botcazou To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix PR55882 Date: Thu, 10 Jan 2013 12:23:00 -0000 Message-ID: <2077311.nCd1FQqJgT@polaris> User-Agent: KMail/4.7.2 (Linux/3.1.10-1.16-desktop; KDE/4.7.2; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00534.txt.bz2 > Going over this what's strange as well is that we adjust MEM_SIZE > with bitpos, too. At least when the MEM has non-BLKmode this > means that MEMs mode and MEM_SIZE is inconsistent? Or how do > a MEMs mode and MEM_SIZE relate? Yes, the MEM attributes are incomplete/inconsistent between the call to set_mem_attributes_minus_bitpos and the subsequent adjustment by bitpos. That's why only the final result should matter and need be correct. Let me try to forge my own opinion on the PR before answering further. -- Eric Botcazou