From: Eric Botcazou <ebotcazou@adacore.com>
To: John Marino <gnugcc@marino.st>
Cc: gcc-patches@gcc.gnu.org, Thomas Quinot <quinot@adacore.com>
Subject: Re: [patch] Implement Ada support for DragonFly, improve it for FreeBSD
Date: Wed, 03 Jun 2015 07:30:00 -0000 [thread overview]
Message-ID: <20777268.lEEs1vboLO@polaris> (raw)
In-Reply-To: <5568E37B.3050401@marino.st>
> This patch set is a subset of the GNAT patches I've maintained
> separately for a few years. I have limited it adding support for
> x86-64-*-dragonfly* and improving support for i[34567]86-*-freebsd and
> x86_64-*-freebsd*.
Thanks for posting it.
> I've added the attached patch to the gcc trunk as it was on May 29,
> built GNAT and ran the testsuite. The results are linked here:
>
> 1. http://leaf.dragonflybsd.org/~marino/freebsd/dfly64.concise.log.txt
> 2. http://leaf.dragonflybsd.org/~marino/freebsd/fbsd64.concise.log.txt
> 3. http://leaf.dragonflybsd.org/~marino/freebsd/fbsd32.concise.log.txt
>
> There is one regression in the gnat.dg tests on all platforms, but I
> believe this is caused by recent commits to GNAT and not by these patches.
Right.
> Note 1) All TOOL_TARGET_PAIRS in gcc/ada/gcc-interface/Makefile.in
> should be removed for most (if not all) platforms as they were moved to
> gnattools/configure and are now no-ops. However, for this patch set I
> only removed them for FreeBSD.
They are actually used if you configure with --disable-libada so should be
preserved. You don't need to add new ones though.
> Note 2) I removed reference to FreeBSD 6 and earlier. These platforms
> have been EOL for years (FreeBSD 8 is EOL in 4 weeks)
>
> Note 3) FreeBSD should have switched to use errno years ago, this patch
> does that now.
>
> Note 4) For all BSD except DragonFly (which doesn't support i386
> anymore), the GCC_UNWINDER is specified for i386 platforms. It wasn't
> specified before.
>
> Note 5) All the ce/cxa/cxg tests that failed on i386-FreeBSD are related
> to the 53-bit float mantissa issue on FreeBSD. This is resolved by my
> GNAT-AUX repository changes so the tests pass without compromising other
> compilers, but those patches are out of scope of this set.
I'm not a specialist of FreeBSD so Thomas is Cced. The original message is:
https://gcc.gnu.org/ml/gcc-patches/2015-05/msg02830.html
> copy of patch:
> http://leaf.dragonflybsd.org/~marino/freebsd/gnat-dragonfly-support.diff
> copy of suggested commit message:
> http://leaf.dragonflybsd.org/~marino/freebsd/gnat-dragonfly-support.msg.txt
> (both attached to this email)
This looks good to me modulo the TOOL_TARGET_PAIRS thing. But ChangeLog lines
must all start with a capital letter and end with a period.
Please leave a couple of more days for Thomas or Arno to comment though.
--
Eric Botcazou
next prev parent reply other threads:[~2015-06-03 7:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 23:36 John Marino
2015-06-03 7:30 ` Eric Botcazou [this message]
2015-06-03 7:33 ` Arnaud Charlet
2015-06-03 8:25 ` John Marino
2015-06-03 9:14 ` Arnaud Charlet
2015-06-04 18:24 ` John Marino
2015-06-04 21:04 ` Arnaud Charlet
[not found] ` <5570AE5B.9090804@marino.st>
2015-06-08 7:31 ` Eric Botcazou
2015-06-05 13:08 ` Arnaud Charlet
2015-06-03 9:41 ` Thomas Quinot
2015-06-03 10:46 ` John Marino
2015-06-03 11:17 ` Thomas Quinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20777268.lEEs1vboLO@polaris \
--to=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnugcc@marino.st \
--cc=quinot@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).