From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95189 invoked by alias); 3 Jun 2015 07:23:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 95177 invoked by uid 89); 3 Jun 2015 07:23:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_20,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 03 Jun 2015 07:23:16 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 63B4E2852F14; Wed, 3 Jun 2015 09:23:12 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BjkJ3SOYzBTa; Wed, 3 Jun 2015 09:23:12 +0200 (CEST) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 40BA62852F12; Wed, 3 Jun 2015 09:23:12 +0200 (CEST) From: Eric Botcazou To: John Marino Cc: gcc-patches@gcc.gnu.org, Thomas Quinot Subject: Re: [patch] Implement Ada support for DragonFly, improve it for FreeBSD Date: Wed, 03 Jun 2015 07:30:00 -0000 Message-ID: <20777268.lEEs1vboLO@polaris> User-Agent: KMail/4.7.2 (Linux/3.1.10-1.29-desktop; KDE/4.7.2; x86_64; ; ) In-Reply-To: <5568E37B.3050401@marino.st> References: <5568E37B.3050401@marino.st> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2015-06/txt/msg00272.txt.bz2 > This patch set is a subset of the GNAT patches I've maintained > separately for a few years. I have limited it adding support for > x86-64-*-dragonfly* and improving support for i[34567]86-*-freebsd and > x86_64-*-freebsd*. Thanks for posting it. > I've added the attached patch to the gcc trunk as it was on May 29, > built GNAT and ran the testsuite. The results are linked here: > > 1. http://leaf.dragonflybsd.org/~marino/freebsd/dfly64.concise.log.txt > 2. http://leaf.dragonflybsd.org/~marino/freebsd/fbsd64.concise.log.txt > 3. http://leaf.dragonflybsd.org/~marino/freebsd/fbsd32.concise.log.txt > > There is one regression in the gnat.dg tests on all platforms, but I > believe this is caused by recent commits to GNAT and not by these patches. Right. > Note 1) All TOOL_TARGET_PAIRS in gcc/ada/gcc-interface/Makefile.in > should be removed for most (if not all) platforms as they were moved to > gnattools/configure and are now no-ops. However, for this patch set I > only removed them for FreeBSD. They are actually used if you configure with --disable-libada so should be preserved. You don't need to add new ones though. > Note 2) I removed reference to FreeBSD 6 and earlier. These platforms > have been EOL for years (FreeBSD 8 is EOL in 4 weeks) > > Note 3) FreeBSD should have switched to use errno years ago, this patch > does that now. > > Note 4) For all BSD except DragonFly (which doesn't support i386 > anymore), the GCC_UNWINDER is specified for i386 platforms. It wasn't > specified before. > > Note 5) All the ce/cxa/cxg tests that failed on i386-FreeBSD are related > to the 53-bit float mantissa issue on FreeBSD. This is resolved by my > GNAT-AUX repository changes so the tests pass without compromising other > compilers, but those patches are out of scope of this set. I'm not a specialist of FreeBSD so Thomas is Cced. The original message is: https://gcc.gnu.org/ml/gcc-patches/2015-05/msg02830.html > copy of patch: > http://leaf.dragonflybsd.org/~marino/freebsd/gnat-dragonfly-support.diff > copy of suggested commit message: > http://leaf.dragonflybsd.org/~marino/freebsd/gnat-dragonfly-support.msg.txt > (both attached to this email) This looks good to me modulo the TOOL_TARGET_PAIRS thing. But ChangeLog lines must all start with a capital letter and end with a period. Please leave a couple of more days for Thomas or Arno to comment though. -- Eric Botcazou