From: Eric Botcazou <ebotcazou@adacore.com>
To: Richard Sandiford <richard.sandiford@arm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Mostly rewrite genrecog
Date: Thu, 30 Apr 2015 10:44:00 -0000 [thread overview]
Message-ID: <2086417.otp1qkEs0S@polaris> (raw)
In-Reply-To: <87bni7vyio.fsf@e105548-lin.cambridge.arm.com>
> The generated code. genrecog.c itself isn't bad. :-)
Nice work then.
> OK. I'd left the head comment alone because it just described the
> interface, which hasn't changed. But I suppose past lack of commentary
> doesn't justify future lack of commentary. Here's what I added:
> [...]
> BTW, hope at least part of the doubling in size is due to more commentary
> in the code itself.
I see. Thanks a lot for writing down the description of the algorithm!
> I'd rather leave stuff like that to someone who wants it rather than try
> to write routines speculatively in the hope that someone would find them
> useful.
OK.
--
Eric Botcazou
next prev parent reply other threads:[~2015-04-30 10:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 10:20 Richard Sandiford
2015-04-28 23:18 ` Jeff Law
2015-04-29 13:59 ` Richard Sandiford
2015-04-29 8:52 ` Eric Botcazou
2015-04-29 13:51 ` Richard Sandiford
2015-04-30 10:44 ` Eric Botcazou [this message]
2015-04-30 6:54 ` Bin.Cheng
2015-04-30 11:58 ` Richard Sandiford
2015-04-30 7:17 ` Andreas Schwab
2015-04-30 7:58 ` Richard Sandiford
2015-04-30 12:10 ` Andreas Schwab
2015-04-30 12:33 ` Richard Biener
2015-04-30 16:27 ` Richard Sandiford
2015-05-01 12:42 ` Richard Sandiford
2015-05-01 13:57 ` Jeff Law
2015-05-07 8:59 ` [nvptx] " Thomas Schwinge
2015-05-07 9:14 ` Jakub Jelinek
2015-05-21 8:09 ` Thomas Schwinge
2015-05-21 11:57 ` Bernd Schmidt
2015-05-08 9:10 ` genrecog: Address -Wsign-compare diagnostics (was: Mostly rewrite genrecog) Thomas Schwinge
2015-05-08 14:43 ` genrecog: Address -Wsign-compare diagnostics Richard Sandiford
2015-05-08 18:39 ` Jeff Law
2015-05-16 8:13 ` Mostly rewrite genrecog Andreas Krebbel
2015-05-17 22:05 ` Richard Sandiford
2015-05-22 16:14 ` Andreas Krebbel
2015-05-22 16:32 ` Richard Sandiford
2015-05-29 17:39 ` RFA: Fix mode checks for possibly-constant predicates Richard Sandiford
2015-05-29 19:27 ` Richard Henderson
2015-06-03 7:23 ` Richard Sandiford
2015-06-03 9:39 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2086417.otp1qkEs0S@polaris \
--to=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).