From: Eric Botcazou <ebotcazou@adacore.com>
To: Alan Modra <amodra@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Fix PR libffi/60073
Date: Fri, 14 Feb 2014 10:33:00 -0000 [thread overview]
Message-ID: <2088440.84iN7cr20D@polaris> (raw)
In-Reply-To: <20140214095504.GS3386@bubble.grove.modra.org>
> Eric, sorry to rain on your parade, but you're making the same mistake
> I did at first when adding powerpc64le support to libffi. libffi is
> built as a shared library. You can't add a field to ffi_cif like this
> and uncondionally write to it: An application linked against an older
> version of libffi will only allocate the old size ffi_cif. Your new
> shared library will trash some random location in the old user app..
OK, I didn't realize that libffi was built as a shared library. That seems a
little strange and inconvenient for a glue library.
> I worked around this problem on powerpc by defining new enum ffi_abi
> values so that you can recognize an old app.
I see, thanks for the heads up and the hint!
--
Eric Botcazou
next prev parent reply other threads:[~2014-02-14 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 16:19 Eric Botcazou
2014-02-14 9:55 ` Alan Modra
2014-02-14 10:33 ` Eric Botcazou [this message]
2014-02-17 12:00 ` Eric Botcazou
-- strict thread matches above, loose matches on Subject: below --
2014-02-13 16:19 Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2088440.84iN7cr20D@polaris \
--to=ebotcazou@adacore.com \
--cc=amodra@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).