From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C23113858D32 for ; Sat, 4 Nov 2023 17:36:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C23113858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C23113858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699119390; cv=none; b=w7/JOfcc9oIkVKur6oPf7H0BSXoz0zkRVn+uxECCP8nr0MZG0rkaZnKlXmW3/Gd4YG9CAcZmfx0iuldETxZdw8m08ry1iPZLzOH3/dHnv1czRCZBy/aY0uuXBBlsrePpKGQUh/AceOisRl5IlL0sqqm+xr5cy02Ksij/JCR/a/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699119390; c=relaxed/simple; bh=Z9tVcXk6nPwumjyvlyWOXrPkXsb0HO0ROiO148r5eE0=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=tY09D51OWSgCYQxVXwCUa3dDXibB/o/v/kxjuYmwtiT+GRmpCHXXYk9q8md3Fsa+UkMg1KdJBwCE1W8SZqUC7EqKMfCCzlWsTNJuZIEHrvS1Mx4x5dvNqKgK3UpgStfghU5J1C08Tqtbf5UXEsGR2MTHFIlV1kCid2382lcz/C8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699119389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z9tVcXk6nPwumjyvlyWOXrPkXsb0HO0ROiO148r5eE0=; b=fgKefdQuxLAN5IZwAPo8RDyWf+AX595ZmjXEqASJ1mLiQO6XgGjzKiQt8ZX4iIsuyFphzk Z6mzF9pfkf4vqhyPWCxnCRFZT/AuQe4oDNh42oGL7liywRnpKu4IsKvi+IoTi1YoaW6KM0 2G/kw+PpKqSimwm0R4T1sROPDqrWtyY= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-370-FW9P2HLTPmKuvi9p7m4gaA-1; Sat, 04 Nov 2023 13:36:28 -0400 X-MC-Unique: FW9P2HLTPmKuvi9p7m4gaA-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-66d12b547e2so39493936d6.0 for ; Sat, 04 Nov 2023 10:36:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699119387; x=1699724187; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Z9tVcXk6nPwumjyvlyWOXrPkXsb0HO0ROiO148r5eE0=; b=WhJvbHvjPbP8V5cn8Xq1ozIRXo08uTyKJNpWTpG+3x6LGFIiqTRqd/alX/nUkswV7C 5GlOa8hsKixwDO9JIBJh/o6VPtDxKiy4ryQiiegmOmmRCywVCKaSN02CtITw3Zcpi5o4 7FCFbsAo3k8f7Bd7XF7jLYAnNTRFpfusVW9sN18xrMpAHkHJEqv5q2fYVFPX5p35Q5aP QHjWn9JvEqWjaVkVQeC4B/0PYhY0XsDVEoIpI0Plruq1BtQaSU1yyH9mh8gaXBMZDUFE jiO5h347J0UoGBPK32ODil3myWZ6Y6iTYXDCCIV4dPVWSwiOeyN1jY+zvD4C4OD3jvta Trsg== X-Gm-Message-State: AOJu0YytZIunO6kWBuhwdLrM/rXJ1REVe8u7Y8soanem/S2YxGTYthfV Wsdqd0X9OecFems3JkomlSsyCmejvakuC8bqH2yKpSHjLK3uc4NSJHusZf3mJccdBGogte8+XDb e/zjCgn9qTu3gwk55sA== X-Received: by 2002:a05:6214:c44:b0:672:ab2:d9d9 with SMTP id r4-20020a0562140c4400b006720ab2d9d9mr20263425qvj.29.1699119387537; Sat, 04 Nov 2023 10:36:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3t3tXlL1+KvHuJtJ30zTgm7g4wgZmNKP17bU8ii7/vCwkvQoQUkSL0TzFJXil8iJ5prm1nA== X-Received: by 2002:a05:6214:c44:b0:672:ab2:d9d9 with SMTP id r4-20020a0562140c4400b006720ab2d9d9mr20263409qvj.29.1699119387298; Sat, 04 Nov 2023 10:36:27 -0700 (PDT) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id eh7-20020a056214186700b006564afc5908sm1813619qvb.111.2023.11.04.10.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Nov 2023 10:36:26 -0700 (PDT) Message-ID: <2098c9ef6452c81d4f13c8a3b11a93a304c8d8db.camel@redhat.com> Subject: Re: [PATCH] diagnostics: fix gcc-urlifier.cc bootstrap failure [PR112379] From: David Malcolm To: Sergei Trofimovich , gcc-patches@gcc.gnu.org Cc: Sergei Trofimovich Date: Sat, 04 Nov 2023 13:36:25 -0400 In-Reply-To: <20231104162318.4142088-1-slyich@gmail.com> References: <20231104162318.4142088-1-slyich@gmail.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 2023-11-04 at 16:23 +0000, Sergei Trofimovich wrote: > From: Sergei Trofimovich >=20 > Without the change `./configure --enable-checking=3Drelease` bootstrap > fails as: >=20 > =C2=A0=C2=A0=C2=A0 gcc/gcc-urlifier.cc:100:1: error: > 'get_url_suffix_for_quoted_text()' > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 defined but not used [-Werror= =3Dunused-function] >=20 > This happens because the helper is used only in `ASSERT` macros which > don't always get expanded to executable code. >=20 > The fix marks helper function with `ATTRIBUTE_UNUSED`. Sorry for the breakage. Patch looks good to me; thanks Dave >=20 > gcc/ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0PR bootstrap/112379 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* gcc-urlifier.cc (get_ur= l_suffix_for_quoted_text): Mark as > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ATTRIBUTE_UNUSED. > --- > =C2=A0gcc/gcc-urlifier.cc | 3 ++- > =C2=A01 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/gcc/gcc-urlifier.cc b/gcc/gcc-urlifier.cc > index 269246bc703..0dbff985313 100644 > --- a/gcc/gcc-urlifier.cc > +++ b/gcc/gcc-urlifier.cc > @@ -37,7 +37,8 @@ public: > =C2=A0=C2=A0 char *get_url_for_quoted_text (const char *p, size_t sz) con= st > final override; > =C2=A0 > =C2=A0=C2=A0 const char *get_url_suffix_for_quoted_text (const char *p, s= ize_t > sz) const; > -=C2=A0 const char *get_url_suffix_for_quoted_text (const char *p) const; > +=C2=A0 /* We use ATTRIBUTE_UNUSED as this helper is called only from > ASSERTs.=C2=A0 */ > +=C2=A0 const char *get_url_suffix_for_quoted_text (const char *p) const > ATTRIBUTE_UNUSED; > =C2=A0 > =C2=A0private: > =C2=A0=C2=A0 static char *