From: 钟居哲 <juzhe.zhong@rivai.ai>
To: patrick <patrick@rivosinc.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Cc: jakub <jakub@redhat.com>, pinskia <pinskia@gcc.gnu.org>,
"Jeff Law" <JeffreyALaw@gmail.com>,
gnu-toolchain <gnu-toolchain@rivosinc.com>,
patrick <patrick@rivosinc.com>
Subject: Re: [PATCH] RISC-V: Use safe_grow_cleared for vector info [PR111469]
Date: Sun, 1 Oct 2023 07:03:51 +0800 [thread overview]
Message-ID: <20DBB04A235265AE+202310010703506641526@rivai.ai> (raw)
In-Reply-To: <20230930230019.865326-1-patrick@rivosinc.com>
[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]
LGTM.
juzhe.zhong@rivai.ai
From: Patrick O'Neill
Date: 2023-10-01 07:00
To: gcc-patches; juzhe.zhong
CC: jakub; pinskia; JeffreyALaw; gnu-toolchain; Patrick O'Neill
Subject: [PATCH] RISC-V: Use safe_grow_cleared for vector info [PR111469]
Resolves a riscv*-*-* bootstrap failure due to a newly-turned-on assert.
2023-09-30 Jakub Jelinek <jakub@redhat.com>
PR target/111649
gcc/ChangeLog:
* config/riscv/riscv-vsetvl.cc (vector_infos_manager::vector_infos_manager):
Replace safe_grow with safe_grow_cleared.
---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111649
Fix authored by Jakub Jelinek.
Tested for regressions using multilib riscv glibc rv32gcv, rv64gcv
---
gcc/config/riscv/riscv-vsetvl.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/riscv-vsetvl.cc b/gcc/config/riscv/riscv-vsetvl.cc
index af8c31d873c..4b06d93e7f9 100644
--- a/gcc/config/riscv/riscv-vsetvl.cc
+++ b/gcc/config/riscv/riscv-vsetvl.cc
@@ -2417,8 +2417,8 @@ vector_infos_manager::vector_infos_manager ()
vector_antin = nullptr;
vector_antout = nullptr;
vector_earliest = nullptr;
- vector_insn_infos.safe_grow (get_max_uid ());
- vector_block_infos.safe_grow (last_basic_block_for_fn (cfun));
+ vector_insn_infos.safe_grow_cleared (get_max_uid ());
+ vector_block_infos.safe_grow_cleared (last_basic_block_for_fn (cfun));
if (!optimize)
{
basic_block cfg_bb;
--
2.34.1
next prev parent reply other threads:[~2023-09-30 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 23:00 Patrick O'Neill
2023-09-30 23:03 ` 钟居哲 [this message]
2023-09-30 23:13 ` [Committed] " Patrick O'Neill
2023-10-02 7:12 ` [PATCH] " Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20DBB04A235265AE+202310010703506641526@rivai.ai \
--to=juzhe.zhong@rivai.ai \
--cc=JeffreyALaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=jakub@redhat.com \
--cc=patrick@rivosinc.com \
--cc=pinskia@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).