From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9928 invoked by alias); 13 Apr 2011 18:17:48 -0000 Received: (qmail 9919 invoked by uid 22791); 13 Apr 2011 18:17:48 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Apr 2011 18:17:43 +0000 Received: from wpaz1.hot.corp.google.com (wpaz1.hot.corp.google.com [172.24.198.65]) by smtp-out.google.com with ESMTP id p3DIHfuL010352 for ; Wed, 13 Apr 2011 11:17:41 -0700 Received: from iwn10 (iwn10.prod.google.com [10.241.68.74]) by wpaz1.hot.corp.google.com with ESMTP id p3DIGsTA010742 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Wed, 13 Apr 2011 11:17:40 -0700 Received: by iwn10 with SMTP id 10so1595270iwn.5 for ; Wed, 13 Apr 2011 11:17:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.42.247.202 with SMTP id md10mr2080312icb.44.1302718659956; Wed, 13 Apr 2011 11:17:39 -0700 (PDT) Reply-To: crowl@google.com, dnovillo@google.com, gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com X-Google-Appengine-App-Id: codereview Message-ID: <20cf3005ddf8f811b504a0d0d2c9@google.com> Date: Wed, 13 Apr 2011 18:17:00 -0000 Subject: Re: [pph] Test PPH include at global scope. (issue4399041) From: dnovillo@google.com To: crowl@google.com Cc: gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg01021.txt.bz2 On 2011/04/12 21:40:10, Lawrence Crowl wrote: > Add a test to ensure that PPH files are #included at global scope. > Initially, this test is XFAIL, as it's a low priority error. > Index: gcc/testsuite/ChangeLog.pph > 2011-04-12 Lawrence Crowl > * g++.dg/pph/y2smother.cc: New. OK. Diego. http://codereview.appspot.com/4399041/