From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28320 invoked by alias); 28 Apr 2011 14:08:25 -0000 Received: (qmail 28292 invoked by uid 22791); 28 Apr 2011 14:08:24 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_20,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Apr 2011 14:08:09 +0000 Received: from hpaq6.eem.corp.google.com (hpaq6.eem.corp.google.com [172.25.149.6]) by smtp-out.google.com with ESMTP id p3SE87fk016212 for ; Thu, 28 Apr 2011 07:08:07 -0700 Received: from iyn35 (iyn35.prod.google.com [10.241.52.99]) by hpaq6.eem.corp.google.com with ESMTP id p3SE85id003924 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 28 Apr 2011 07:08:06 -0700 Received: by iyn35 with SMTP id 35so6001592iyn.0 for ; Thu, 28 Apr 2011 07:08:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.42.62.209 with SMTP id z17mr1163193ich.88.1303999685218; Thu, 28 Apr 2011 07:08:05 -0700 (PDT) Reply-To: carrot@google.com, davidxl@google.com, iant@google.com, dougkwan@google.com, dnovillo@google.com, gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com X-Google-Appengine-App-Id: codereview Message-ID: <20cf30223cc506526a04a1fb16f8@google.com> Date: Thu, 28 Apr 2011 14:30:00 -0000 Subject: Re: [google] Use R_ARM_GOT_PREL to simplify global address loading from GOT (issue4433079) From: dnovillo@google.com To: carrot@google.com, davidxl@google.com, iant@google.com, dougkwan@google.com Cc: gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg02224.txt.bz2 I only have some stylistic comments for this patch. The new pass looks OK to me, but I do not know this area well enough to do a good review. In your ChangeLog entries, please remove the directory prefix from the file names. http://codereview.appspot.com/4433079/diff/1/gcc/hooks.c File gcc/hooks.c (right): http://codereview.appspot.com/4433079/diff/1/gcc/hooks.c#newcode287 gcc/hooks.c:287: return NULL; +hook_rtx_void_null (void) +{ + return NULL; s/NULL/NULL_RTX/ http://codereview.appspot.com/4433079/diff/1/gcc/simplify-got.c File gcc/simplify-got.c (right): http://codereview.appspot.com/4433079/diff/1/gcc/simplify-got.c#newcode83 gcc/simplify-got.c:83: return (optimize > 0) && targetm.got_access.get_pic_reg (); +{ + return (optimize > 0) && targetm.got_access.get_pic_reg (); s/(optimize > 0)/optimize/ http://codereview.appspot.com/4433079/diff/1/gcc/simplify-got.c#newcode118 gcc/simplify-got.c:118: if (!(set && (SET_DEST (set) == pic_reg))) + /* If an insn both set and use pic_reg, it is in the process of + constructing the value of pic_reg. We should also ignore it. */ + rtx set = single_set (insn); + if (!(set && (SET_DEST (set) == pic_reg))) Extra ( ) around SET_DEST are not needed. http://codereview.appspot.com/4433079/