* Re: [PATCH][google] Fix parallel make issue exposed by recent gcda change (issue 7426043)
@ 2013-02-28 6:33 davidxl
0 siblings, 0 replies; 2+ messages in thread
From: davidxl @ 2013-02-28 6:33 UTC (permalink / raw)
To: tejohnson; +Cc: matt.hargett, gcc-patches, reply
Looks good to me.
https://codereview.appspot.com/7426043/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][google] Fix parallel make issue exposed by recent gcda change (issue 7426043)
@ 2013-02-28 1:10 davidxl
0 siblings, 0 replies; 2+ messages in thread
From: davidxl @ 2013-02-28 1:10 UTC (permalink / raw)
To: tejohnson; +Cc: matt.hargett, gcc-patches, reply
https://codereview.appspot.com/7426043/diff/1/gcc/gcov-io.h
File gcc/gcov-io.h (right):
https://codereview.appspot.com/7426043/diff/1/gcc/gcov-io.h#newcode1013
gcc/gcov-io.h:1013: GCOV_LINKAGE void gcov_seek (gcov_position_t
/*position*/, int /* from_end */)
I think it is better to create a new interface for seek_from_end instead
of changing the existing interface.
https://codereview.appspot.com/7426043/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-28 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-28 6:33 [PATCH][google] Fix parallel make issue exposed by recent gcda change (issue 7426043) davidxl
-- strict thread matches above, loose matches on Subject: below --
2013-02-28 1:10 davidxl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).