From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8F69F3858C00 for ; Wed, 7 Sep 2022 21:13:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8F69F3858C00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662585206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0vqXzhO5r00rOzuxAXSGkEA9Cc8+9HyjgjNgA3iQGqc=; b=Fq1LI1BqI3yk56wPBpD7Pz82KxIbd+HPAQYggONLHDUwUlS3WIuRXPxFK7ucgyZmFM8gCt qqHsbyJaWju2en+8CsaRD4b7bze3lcVCDs3/DUgNnVn9eNluIu6qwnSIM4wn2e3enH/EDt Ccg5EIRo3lcCq07WvCUeghkzTOslQ7E= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-410-f_jup4HaPBmVqW77l4grkQ-1; Wed, 07 Sep 2022 17:13:25 -0400 X-MC-Unique: f_jup4HaPBmVqW77l4grkQ-1 Received: by mail-qk1-f198.google.com with SMTP id bq19-20020a05620a469300b006c097741d3dso12834494qkb.2 for ; Wed, 07 Sep 2022 14:13:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date; bh=0vqXzhO5r00rOzuxAXSGkEA9Cc8+9HyjgjNgA3iQGqc=; b=00w+eovs2vq5QkrzTuLR6R8CxjmPvUQ0NPDSuOX4tqjIE8iTg1cX4Q4O1P08MYt7SN ioMvRonPqtjTlDGNA7wwZe0riEZ9gGQhJcv5cGBf/ikTI3p+/M2tJ6phGFc+AOSc5sfn itTXsoKy/J9/RTzKcZin1gSDe0JasxrYAG4oUwaKuMwgfgYyz2NGHT9WCXLmBq42iQHU /nkOdj2hozA8QBf3YaLH/iKvMZwyvWdXqIrlsgSX2utYcgaJR2sE1FFHyaupFrU7WPql 83ONKMasqUfPNTRf3Z6wCdXJrLM57TBt/Gl1wRYzsFGfKFCHQe7+9KexERpIDN7oXcqb 8vfA== X-Gm-Message-State: ACgBeo1vJJljZSlS4tnl2wlH7pjtbl2NPsvkVauVsZwOA0q1wCNWA0MF 89vyP3iGk0L2teJcFQdhzKxh0S0T8xUPZo0Hw4q4pGVILcqFgBM88oTVSa2gT8fX+bzxjAvTJNe BqaA7OjavvZAqhIsLYQ== X-Received: by 2002:a05:620a:27ce:b0:6be:59d8:f727 with SMTP id i14-20020a05620a27ce00b006be59d8f727mr4308097qkp.737.1662585204237; Wed, 07 Sep 2022 14:13:24 -0700 (PDT) X-Google-Smtp-Source: AA6agR4vDtaqdx5Hj1qZLswwG1cf6s96AmZqOrsTFeVlYRQGw+bDDo223SYNEMoXVbEkaX7J5v0rfw== X-Received: by 2002:a05:620a:27ce:b0:6be:59d8:f727 with SMTP id i14-20020a05620a27ce00b006be59d8f727mr4308081qkp.737.1662585203927; Wed, 07 Sep 2022 14:13:23 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id n3-20020a05620a294300b006b953a7929csm16043809qkp.73.2022.09.07.14.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 14:13:23 -0700 (PDT) Message-ID: <20f04485e335a7d56019d5301d5c3a6b76ef40e9.camel@redhat.com> Subject: Re: [PATCH v2] analyzer: support for symbolic values in the out-of-bounds checker [PR106625] From: David Malcolm To: Tim Lange Cc: gcc-patches@gcc.gnu.org Date: Wed, 07 Sep 2022 17:13:22 -0400 In-Reply-To: <20220907155107.31300-1-mail@tim-lange.me> References: <294db6f8bc85a6d15ec267eb4bbd0d354210e186.camel@redhat.com> <20220907155107.31300-1-mail@tim-lange.me> User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2022-09-07 at 17:51 +0200, Tim Lange wrote: > Hi Dave, >=20 > while re-reading that patch, I noticed a small mistake. I accidently > did > not move the op =3D=3D PLUS_EXPR or MULT_EXPR guard in > symbolic_greater_than > when implementing the "eliminate operands on both sides" feature, > which > lead to the old patch also eliminating operands on both sides if the > operator decreases the value, which is obviously wrong. >=20 > I moved the guard outside and added test coverage for this in > symbolic-gt-1.c. The patch passed the regrtests with the fix > included. >=20 > I assume it is still okay for trunk? Yes it is - thanks for the updated patch. Dave