From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 4954F3858432 for ; Tue, 14 May 2024 02:59:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4954F3858432 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4954F3858432 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715655596; cv=none; b=TF7ONhOEmhTzrIl4e2dbazNNhWn04e6qJJtnBr6OL73k1hLvJ2LrRS21VG7H446SRBnAx867+mQZ5cgLxexHn2Xb3lgfUwQ9pZdf6zNK9/1BOx76YAHSvy7b+uCcUsjFWGV1s3hZYyg2+nk5RJ3L/7d/+y1Iqyh+Pnq2pyE79uQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715655596; c=relaxed/simple; bh=pv8cXdXUcjQsHQr2ErxjTRMR/LirhV2GJxiQrVsqOP0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xKEN2JKFRW0as7s2HYWctuIIwHIsvwy6oY9Xqww8LB9NtB+x7rnIoaxasjQ3/PhbT4hg4eRCQHnFRkd694JSyFsWxNQ85bh81LntXXe1TeGYTskcg/75R6hPfLCYKmZQ51nhOrGD9dlKe1il66wE2CkFzze7nypSH7OAmkEPSNE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 44E1MghB025391; Tue, 14 May 2024 02:59:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : cc : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=F8NiLglq+9ADy7NGJ9e/uwkCPSYIKcdi6zEOJCu1yro=; b=GhndbQDKG4dd/Hg86RmazeSWGOGQpX/6X6GWDvn5FUE0zvw50cmw5GjajthnGuaFiV8H QK2VbLmJHe0qWmM3F4ZIde5yIzpSKhjDEPPaQsyhjd8SPGxqkMJ6Gt6ROogPK95BOtNR Y/Y1uurqKBx3ARyDW00gb1HyK0SjPmSn0K+OLjJaYBeLtBnpAqdpSN/dMGrmFAk5GgD9 YFC4y5l3zgrc/2xKnuozxxTf4NoFvrZgc5fRKGuR2lQYHvBAOOkj1I7UU4jfbKCJEx8s dKvo+zGtyzHfUF9vpC6+PcZuZNDq8EytcvsBDNpA7/qu9/Fz5u0c3irtTIK8PV54jkpK 1A== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3y3x7w0589-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2024 02:59:51 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 44E0jm79005998; Tue, 14 May 2024 02:59:50 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3y2mgmayer-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2024 02:59:50 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 44E2xikm51118554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 May 2024 02:59:47 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CD71720043; Tue, 14 May 2024 02:59:44 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 52DD520040; Tue, 14 May 2024 02:59:43 +0000 (GMT) Received: from [9.200.158.244] (unknown [9.200.158.244]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 14 May 2024 02:59:43 +0000 (GMT) Message-ID: <21116cb6-663a-0f86-4c25-471757c7238f@linux.ibm.com> Date: Tue, 14 May 2024 10:59:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 8/13] rs6000, remove __builtin_vsx_vperm_* built-ins Content-Language: en-US To: Carl Love References: <6378d560-df55-4b75-be7b-93dc6b85d81a@linux.ibm.com> <71c38f83-59d2-484d-acf7-e74c6f561a7e@linux.ibm.com> Cc: gcc-patches@gcc.gnu.org, "bergner@linux.ibm.com" , Segher Boessenkool From: "Kewen.Lin" In-Reply-To: <71c38f83-59d2-484d-acf7-e74c6f561a7e@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 3lFx-LkGw2QHdR6Wkr5Zkd-irGrbNfU8 X-Proofpoint-ORIG-GUID: 3lFx-LkGw2QHdR6Wkr5Zkd-irGrbNfU8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-13_17,2024-05-10_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 clxscore=1015 malwarescore=0 mlxscore=0 priorityscore=1501 spamscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2405140020 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, on 2024/4/20 05:18, Carl Love wrote: > rs6000, remove __builtin_vsx_vperm_* built-ins > > The undocumented built-ins: > __builtin_vsx_vperm_16qi_uns, > __builtin_vsx_vperm_1ti, > __builtin_vsx_vperm_1ti_uns, > __builtin_vsx_vperm_2df, > __builtin_vsx_vperm_2di, > __builtin_vsx_vperm_2di_uns, > __builtin_vsx_vperm_4sf, > __builtin_vsx_vperm_4si, > __builtin_vsx_vperm_4si_uns > > are duplicats of the __builtin_altivec_* builtins that are used by > the overloaded vec_perm built-in that is documented in the PVIPR. > > gcc/ChangeLog: > * config/rs6000/rs6000-builtins.def (__builtin_vsx_vperm_16qi_uns, > __builtin_vsx_vperm_1ti, __builtin_vsx_vperm_1ti_uns, > __builtin_vsx_vperm_2df, __builtin_vsx_vperm_2di, > __builtin_vsx_vperm_2di_uns, __builtin_vsx_vperm_4sf, > __builtin_vsx_vperm_4si, __builtin_vsx_vperm_4si_uns): Remove > built-in definitions and comments. > > gcc/testsuite/ChangeLog: > * gcc.target/powerpc/vsx-builtin-3.c (__builtin_vsx_vperm_16qi_uns, > __builtin_vsx_vperm_1ti, __builtin_vsx_vperm_1ti_uns, > __builtin_vsx_vperm_2df, __builtin_vsx_vperm_2di, > __builtin_vsx_vperm_2di_uns, __builtin_vsx_vperm_4sf, > __builtin_vsx_vperm_4si, __builtin_vsx_vperm_4si_uns): Remove > test cases. > --- > gcc/config/rs6000/rs6000-builtins.def | 33 ------------------- > .../gcc.target/powerpc/vsx-builtin-3.c | 20 ----------- > 2 files changed, 53 deletions(-) > > diff --git a/gcc/config/rs6000/rs6000-builtins.def b/gcc/config/rs6000/rs6000-builtins.def > index 3c409d729ea..f33564d3d9c 100644 > --- a/gcc/config/rs6000/rs6000-builtins.def > +++ b/gcc/config/rs6000/rs6000-builtins.def > @@ -1529,39 +1529,6 @@ > const vf __builtin_vsx_uns_floato_v2di (vsll); > UNS_FLOATO_V2DI unsfloatov2di {} > > -; These are duplicates of __builtin_altivec_* counterparts, and are being > -; kept for backwards compatibility. The reason for their existence is > -; unclear. TODO: Consider deprecation/removal at some point. > - const vsc __builtin_vsx_vperm_16qi (vsc, vsc, vuc); > - VPERM_16QI_X altivec_vperm_v16qi {} > - > - const vuc __builtin_vsx_vperm_16qi_uns (vuc, vuc, vuc); > - VPERM_16QI_UNS_X altivec_vperm_v16qi_uns {} > - > - const vsq __builtin_vsx_vperm_1ti (vsq, vsq, vsc); > - VPERM_1TI_X altivec_vperm_v1ti {} > - > - const vsq __builtin_vsx_vperm_1ti_uns (vsq, vsq, vsc); > - VPERM_1TI_UNS_X altivec_vperm_v1ti_uns {} > - > - const vd __builtin_vsx_vperm_2df (vd, vd, vuc); > - VPERM_2DF_X altivec_vperm_v2df {} > - > - const vsll __builtin_vsx_vperm_2di (vsll, vsll, vuc); > - VPERM_2DI_X altivec_vperm_v2di {} > - > - const vull __builtin_vsx_vperm_2di_uns (vull, vull, vuc); > - VPERM_2DI_UNS_X altivec_vperm_v2di_uns {} > - > - const vf __builtin_vsx_vperm_4sf (vf, vf, vuc); > - VPERM_4SF_X altivec_vperm_v4sf {} > - > - const vsi __builtin_vsx_vperm_4si (vsi, vsi, vuc); > - VPERM_4SI_X altivec_vperm_v4si {} > - > - const vui __builtin_vsx_vperm_4si_uns (vui, vui, vuc); > - VPERM_4SI_UNS_X altivec_vperm_v4si_uns {} > - > const vss __builtin_vsx_vperm_8hi (vss, vss, vuc); > VPERM_8HI_X altivec_vperm_v8hi {} > > diff --git a/gcc/testsuite/gcc.target/powerpc/vsx-builtin-3.c b/gcc/testsuite/gcc.target/powerpc/vsx-builtin-3.c > index 01f35dad713..35ea31b2616 100644 > --- a/gcc/testsuite/gcc.target/powerpc/vsx-builtin-3.c > +++ b/gcc/testsuite/gcc.target/powerpc/vsx-builtin-3.c > @@ -2,7 +2,6 @@ > /* { dg-skip-if "" { powerpc*-*-darwin* } } */ > /* { dg-require-effective-target powerpc_vsx_ok } */ > /* { dg-options "-O2 -mdejagnu-cpu=power7" } */ > -/* { dg-final { scan-assembler "vperm" } } */ > /* { dg-final { scan-assembler "xvrdpi" } } */ > /* { dg-final { scan-assembler "xvrdpic" } } */ > /* { dg-final { scan-assembler "xvrdpim" } } */ > @@ -56,25 +55,6 @@ extern __vector unsigned long long ull[][4]; > extern __vector __bool long bl[][4]; > #endif > > -int do_perm(void) > -{ > - int i = 0; > - > - si[i][0] = __builtin_vsx_vperm_4si (si[i][1], si[i][2], uc[i][3]); i++; > - ss[i][0] = __builtin_vsx_vperm_8hi (ss[i][1], ss[i][2], uc[i][3]); i++; > - sc[i][0] = __builtin_vsx_vperm_16qi (sc[i][1], sc[i][2], uc[i][3]); i++; > - f[i][0] = __builtin_vsx_vperm_4sf (f[i][1], f[i][2], uc[i][3]); i++; > - d[i][0] = __builtin_vsx_vperm_2df (d[i][1], d[i][2], uc[i][3]); i++; > - > - si[i][0] = __builtin_vsx_vperm (si[i][1], si[i][2], uc[i][3]); i++; > - ss[i][0] = __builtin_vsx_vperm (ss[i][1], ss[i][2], uc[i][3]); i++; > - sc[i][0] = __builtin_vsx_vperm (sc[i][1], sc[i][2], uc[i][3]); i++; > - f[i][0] = __builtin_vsx_vperm (f[i][1], f[i][2], uc[i][3]); i++; > - d[i][0] = __builtin_vsx_vperm (d[i][1], d[i][2], uc[i][3]); i++; > - > - return i; > -} > - I prefer to just relace these __builtin_vsx_vperm with vec_perm, OK with this tweaked (also keep the above removed vperm scan), thanks! BR, Kewen > int do_xxperm (void) > { > int i = 0;