From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42854 invoked by alias); 28 Jul 2017 07:37:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 42791 invoked by uid 89); 28 Jul 2017 07:37:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:391 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Jul 2017 07:37:30 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 1DFD2813B2; Fri, 28 Jul 2017 09:37:28 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id md0QtgnpSgaj; Fri, 28 Jul 2017 09:37:28 +0200 (CEST) Received: from arcturus.home (ADijon-653-1-158-213.w92-148.abo.wanadoo.fr [92.148.141.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id D6749813B1; Fri, 28 Jul 2017 09:37:27 +0200 (CEST) From: Eric Botcazou To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: Fix thinko in gimple_assign_set_rhs_with_ops Date: Fri, 28 Jul 2017 07:37:00 -0000 Message-ID: <2146728.iQtoQDy8Ds@arcturus.home> User-Agent: KMail/4.14.10 (Linux/3.16.7-53-desktop; KDE/4.14.9; x86_64; ; ) In-Reply-To: References: <2663014.h6Leadj67V@arcturus.home> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2017-07/txt/msg01880.txt.bz2 > I think we should get rid of that update-EH-info flag, always assuming > false. This is IMHO a too low-level interface to do this (and we lack a > gsi_replace_without_update) This looks doable (there is only one call to gsi_replace that tests the return value) but the current interface is probably the most convenient. -- Eric Botcazou