From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id A4FC738207F5 for ; Wed, 8 Jun 2022 14:13:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4FC738207F5 Received: by mail-wm1-x333.google.com with SMTP id h62-20020a1c2141000000b0039aa4d054e2so13463776wmh.1 for ; Wed, 08 Jun 2022 07:13:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yBzGTZQitONJDGsL1IGElzTfiR7sdhNinj1mAFonQHQ=; b=B2eB9AdUBp/cAoJJKkg4sC5DV9YQSRdzOc5IRH4ZLxy3frG3GeLnvW/vtd/ae00rwB 0WrzMDaaD9OxOfAnD5+bGMBsEzopnpdVF+F1Cu1jM4p4vP4D7PT96JdJUELIcph0oPJ6 FIveIIIG7xr79s1bkjI0X2CMmUAH/URxjnJ5hs1Ohyzf0Lt55ioixkrTggGbTCTJ69th J5/L0fygK5Iu7O2R+u+jGc83J74+Ob4F9YjO/D5UGyA3CvOOD/RYsoIR7ObrFzSM0LMU +TtPp+/omUo6Yw3lwtsKOXhs2Qwesi/XnaGDZuIXnCITfuB7fz7rg+0YVv/yJU+seO8t JrBg== X-Gm-Message-State: AOAM5304b7XLDn89SRcl4c/SHjNbfd0ZVuQ2IDgJ2KJTOLZ/OOjj60Rt yscm0TeD1rLO+nAmQPnQuZN8aA== X-Google-Smtp-Source: ABdhPJxVHusB2rnnpM0jTJWPIxIbR3NxXKvplDZycRVIUfFmFeHfzwjiXm8mW9TnpJGY4rzCaUYU5w== X-Received: by 2002:a05:600c:1d19:b0:39c:4aee:fe3a with SMTP id l25-20020a05600c1d1900b0039c4aeefe3amr21439603wms.89.1654697602383; Wed, 08 Jun 2022 07:13:22 -0700 (PDT) Received: from fomalhaut.localnet ([2a01:e0a:8d5:d990:bf38:f508:6f40:de1d]) by smtp.gmail.com with ESMTPSA id n22-20020a05600c3b9600b00397342e3830sm32295497wms.0.2022.06.08.07.13.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 07:13:21 -0700 (PDT) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: Roger Sayle Cc: gcc-patches@gcc.gnu.org, 'Jeff Law' , 'Tamar Christina' Subject: Re: [PATCH] PR middle-end/105874: Use EXPAND_MEMORY to fix ada bootstrap. Date: Wed, 08 Jun 2022 16:13:20 +0200 Message-ID: <21519641.EfDdHjke4D@fomalhaut> In-Reply-To: <07f101d87b38$8c2b42a0$a481c7e0$@nextmovesoftware.com> References: <07f101d87b38$8c2b42a0$a481c7e0$@nextmovesoftware.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 14:13:26 -0000 > The fix is to ensure that we call expand_expr with EXPAND_MEMORY > when processing the VAR_DECL's returned by get_inner_reference. > > This patch has been tested on x86_64-pc-linux-gnu with make bootstrap > and make -k check (with no new failures), but also with > --enable-languages="ada" where it allows the bootstrap to finish, > and with no unexpected failures in the acats and gnat testsuites. > Ok for mainline? Yes, thanks (modulo the nit in the ChangeLog). > 2022-06-08 Roger Sayle > > gcc/ChangeLog > PR middle-end/105874 > * gcc/expr.cc (expand_expr_real_1) : New local > variable tem_modifier for calculating the expand_modifier enum to > use for expanding tem. If tem is a VAR_DECL, use EXPAND_MEMORY. gcc/ prefix to be stripped -- Eric Botcazou