public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Record that -gtoggle is already used in gcc_options.
Date: Tue, 2 Nov 2021 16:11:52 +0100	[thread overview]
Message-ID: <21589cd9-b57e-d0db-937b-230ce4626ea3@suse.cz> (raw)
In-Reply-To: <CAFiYyc1ETPrO=snp1QM1xq=L_WONtmx4JN-ydE4itbaGaZpf-w@mail.gmail.com>

On 11/2/21 15:33, Richard Biener wrote:
> I think -gtoggle matches a Defered option and thus should be processed
> in handle_common_deferred_options.

Well, that's quite problematic as I handle_common_deferred_options is called
after decode_options (that calls finish_options).

Note there's direct dependency at very end of finish_options in between -gtoggle
and debug_nonbind_markers_p:


   if (flag_gtoggle)
     {
       if (debug_info_level == DINFO_LEVEL_NONE)
	{
	  debug_info_level = DINFO_LEVEL_NORMAL;

	  if (write_symbols == NO_DEBUG)
	    write_symbols = PREFERRED_DEBUGGING_TYPE;
	}
       else
	debug_info_level = DINFO_LEVEL_NONE;
     }

   if (!OPTION_SET_P (debug_nonbind_markers_p))
     debug_nonbind_markers_p
       = (optimize
	 && debug_info_level >= DINFO_LEVEL_NORMAL
	 && dwarf_debuginfo_p ()
	 && !(flag_selective_scheduling || flag_selective_scheduling2));

I don't see who you mean the possible fix?

Martin

  reply	other threads:[~2021-11-02 15:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 14:10 Martin Liška
2021-11-02 14:33 ` Richard Biener
2021-11-02 15:11   ` Martin Liška [this message]
2021-11-02 16:45     ` Richard Biener
2021-11-04 12:51       ` Martin Liška
2021-11-04 13:09         ` Richard Biener
2021-11-04 15:11           ` Martin Liška
2021-11-05 10:23             ` Richard Biener
2021-11-05 12:01               ` Martin Liška
2021-11-02 22:49 ` Andrew Pinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21589cd9-b57e-d0db-937b-230ce4626ea3@suse.cz \
    --to=mliska@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).