From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id 66D303858D38 for ; Wed, 9 Nov 2022 09:49:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 66D303858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x42e.google.com with SMTP id l14so24935967wrw.2 for ; Wed, 09 Nov 2022 01:49:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uVPGZuI67mPQI3sDvEzFSw9CTHVWChnpys/+HJeVVWs=; b=dDlSICpqHqfMxB7JOB88o4LGTZwI5iE9OgoiCXqS4edxjkCHCXs4wMMzGS+Hz+lnZl pSWLck8PQqfdA+8rorGpPiDlcsA6wfxmRT6sLwrJke5TJ18eLtok9K0L5nBYUd5BzIQR X5iUxlX6tgqXs1jASFeIjgxxbEUVk3kN71KdP6Z9QCJpg83Tgt0NtiFBgR2wctx38rdj jp0eSImJL+T7MqIhBQhenFmF4D9ea5ymq92fINbcXjU4tkDf3+E+5D/0kiUN1DBSBfwL Z+zWKquwppUAz68A7hfVE3Ni40/2T3KrvMtz4YX3SZ/F+XTgisPQPpEi8pd8b9GTx562 gP6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uVPGZuI67mPQI3sDvEzFSw9CTHVWChnpys/+HJeVVWs=; b=4jChRjrCApndQDAtdiZ+Sq8p35SvNwUUrYiKzNiOxZXr4sSPab8uJPhgr+Rj+88zE8 R+g+uCpRQ6S4TkqmOJ0rE/VoQYCOktg0CYEfRqL/35raQxEfVZn0cl9tTosTpuYv0gQO pVqybmUyrwhQ52l3FYyDYM4XK8tK6CCoNHIiGbvu/cwX41LeD0ScPrNpywpGVEy7rqpo 5lEcfQESXnLSR09hu83UfyxKyTe9ptYFatIPiU+JllIkNywMGe3t6q3N26PnsAIEGVNB 7qTceoSsFFafelUYePmuEES1SqtNu4XbDPPcvGvZ4yPlUh0m5muQmnB3kw+Ly4N5srhA ACWQ== X-Gm-Message-State: ACrzQf302TMQ7nFxtbMV40JdRfVefRh765/u4cey+hjhpcqj6pT/tdvG PpFpCKMveobVS+H85POHFBcmNg== X-Google-Smtp-Source: AMsMyM7gB94JpxzCAy5C07J0sivoA7CVUmi+h6IyR8P9xwnt3vyWTiWjIkSEnXoll560WHm//wtKUQ== X-Received: by 2002:adf:cd09:0:b0:236:659a:6902 with SMTP id w9-20020adfcd09000000b00236659a6902mr39205790wrm.574.1667987360436; Wed, 09 Nov 2022 01:49:20 -0800 (PST) Received: from fomalhaut.localnet ([2a01:e0a:8d5:d990:e654:e8ff:fe8f:2ce6]) by smtp.gmail.com with ESMTPSA id q11-20020a05600000cb00b00236e9755c02sm12690208wrx.111.2022.11.09.01.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 01:49:19 -0800 (PST) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Restore RTL alias analysis for hard frame pointer Date: Wed, 09 Nov 2022 10:47:10 +0100 Message-ID: <21665502.EfDdHjke4D@fomalhaut> In-Reply-To: References: <1930502.usQuhbGJ8B@fomalhaut> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart7449702.EvYhyI6sBW" Content-Transfer-Encoding: 7Bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --nextPart7449702.EvYhyI6sBW Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" > Oh, do you have a testcase suitable for the testsuite? C guality testcase attached, it fails on x86/Linux with -m32 on the gcc-12 branch (which does not have the fix): FAIL: gcc.dg/guality/param-6.c -O1 -DPREVENT_OPTIMIZATION line 15 i == 5 FAIL: gcc.dg/guality/param-6.c -O2 -DPREVENT_OPTIMIZATION line 15 i == 5 FAIL: gcc.dg/guality/param-6.c -O3 -g -DPREVENT_OPTIMIZATION line 15 i == 5 FAIL: gcc.dg/guality/param-6.c -Os -DPREVENT_OPTIMIZATION line 15 i == 5 FAIL: gcc.dg/guality/param-6.c -O2 -flto -fno-use-linker-plugin -flto- partition=none -DPREVENT_OPTIMIZATION line 15 i == 5 FAIL: gcc.dg/guality/param-6.c -O2 -flto -fuse-linker-plugin -fno-fat-lto- objects -DPREVENT_OPTIMIZATION line 15 i == 5 but passes on the mainline (which has the fix) and on the gcc-11 branch (which does not have the issue). The fix also eliminates other regressions: -FAIL: gcc.dg/guality/drap.c -Os -DPREVENT_OPTIMIZATION line 21 a == 5 -FAIL: gcc.dg/guality/drap.c -Os -DPREVENT_OPTIMIZATION line 22 b == 6 -FAIL: gcc.dg/guality/pr43051-1.c -Os -DPREVENT_OPTIMIZATION line 35 v == 1 -FAIL: gcc.dg/guality/pr43051-1.c -Os -DPREVENT_OPTIMIZATION line 36 e == &a[1] -FAIL: gcc.dg/guality/pr43051-1.c -Os -DPREVENT_OPTIMIZATION line 40 v == 1 -FAIL: gcc.dg/guality/pr43051-1.c -Os -DPREVENT_OPTIMIZATION line 41 e == &a[1] -FAIL: gcc.dg/guality/pr43177.c -Os -DPREVENT_OPTIMIZATION line 15 x == 7 -FAIL: gcc.dg/guality/pr54519-3.c -Os -DPREVENT_OPTIMIZATION line 20 y == 25 -FAIL: gcc.dg/guality/pr54519-3.c -Os -DPREVENT_OPTIMIZATION line 20 z == 6 -FAIL: gcc.dg/guality/pr54519-3.c -Os -DPREVENT_OPTIMIZATION line 23 y == 117 -FAIL: gcc.dg/guality/pr54519-3.c -Os -DPREVENT_OPTIMIZATION line 23 z == 8 -FAIL: gcc.dg/guality/pr54519-4.c -Os -DPREVENT_OPTIMIZATION line 17 y == 25 -FAIL: gcc.dg/guality/pr54796.c -O1 -DPREVENT_OPTIMIZATION line 17 a == 5 -FAIL: gcc.dg/guality/pr54796.c -O1 -DPREVENT_OPTIMIZATION line 17 b == 6 -FAIL: gcc.dg/guality/pr54796.c -O1 -DPREVENT_OPTIMIZATION line 17 c == 5 -FAIL: gcc.dg/guality/pr54796.c -O2 -DPREVENT_OPTIMIZATION line 17 a == 5 -FAIL: gcc.dg/guality/pr54796.c -O2 -DPREVENT_OPTIMIZATION line 17 b == 6 -FAIL: gcc.dg/guality/pr54796.c -O2 -DPREVENT_OPTIMIZATION line 17 c == 5 -FAIL: gcc.dg/guality/pr54796.c -O3 -g -DPREVENT_OPTIMIZATION line 17 a == 5 -FAIL: gcc.dg/guality/pr54796.c -O3 -g -DPREVENT_OPTIMIZATION line 17 b == 6 -FAIL: gcc.dg/guality/pr54796.c -O3 -g -DPREVENT_OPTIMIZATION line 17 c == 5 -FAIL: gcc.dg/guality/pr54796.c -Os -DPREVENT_OPTIMIZATION line 17 a == 5 -FAIL: gcc.dg/guality/pr54796.c -Os -DPREVENT_OPTIMIZATION line 17 b == 6 -FAIL: gcc.dg/guality/pr54796.c -Os -DPREVENT_OPTIMIZATION line 17 c == 5 -FAIL: gcc.dg/guality/pr54796.c -O2 -flto -fno-use-linker-plugin -flto- partition=none -DPREVENT_OPTIMIZATION line 17 a == 5 -FAIL: gcc.dg/guality/pr54796.c -O2 -flto -fno-use-linker-plugin -flto- partition=none -DPREVENT_OPTIMIZATION line 17 b == 6 -FAIL: gcc.dg/guality/pr54796.c -O2 -flto -fno-use-linker-plugin -flto- partition=none -DPREVENT_OPTIMIZATION line 17 c == 5 -FAIL: gcc.dg/guality/sra-1.c -Os -DPREVENT_OPTIMIZATION line 43 a.j == 14 -FAIL: gcc.dg/guality/vla-1.c -O1 -DPREVENT_OPTIMIZATION line 24 i == 5 -FAIL: gcc.dg/guality/vla-1.c -O2 -DPREVENT_OPTIMIZATION line 24 i == 5 -FAIL: gcc.dg/guality/vla-1.c -O3 -g -DPREVENT_OPTIMIZATION line 24 i == 5 -FAIL: gcc.dg/guality/vla-1.c -Os -DPREVENT_OPTIMIZATION line 24 i == 5 -FAIL: gcc.dg/guality/vla-1.c -O2 -flto -fno-use-linker-plugin -flto- partition=none -DPREVENT_OPTIMIZATION line 24 i == 5 present on the gcc-12 branch wrt the gcc-11 branch (apparently nobody really cares about the guality testsuite on x86/Linux). * gcc.dg/guality/param-6.c: New test. -- Eric Botcazou --nextPart7449702.EvYhyI6sBW Content-Disposition: attachment; filename="param-6.c" Content-Transfer-Encoding: 7Bit Content-Type: text/x-csrc; charset="UTF-8"; name="param-6.c" /* { dg-do run { target i?86-*-* x86_64-*-* } } */ /* { dg-options "-g" } */ void __attribute__((noipa)) bar (void *p) {} void __attribute__((noipa)) foo (int i) { void *p = __builtin_alloca (i); asm volatile ("" : : : "ebx"); bar (p); /* { dg-final { gdb-test . "i" "5" } } */ } int main (void) { foo (5); return 0; } --nextPart7449702.EvYhyI6sBW--