From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 2A0FA3858D28 for ; Mon, 6 Nov 2023 09:42:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A0FA3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2A0FA3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.137.180 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699263749; cv=none; b=MNeenS4+7wCJyOIQe1hDNcbIV+nYPz9bMKagF4Ao7tHxUed0il0vvgAUmB+BPKfccYMf86w06YmiXQggbK1Xs2m2VFtGTa3xQRfZQGwev+8u3EnvKRDkE349szVupxG5Ij/YUaUkqiJ0FBeilmpyMgmKtnkUSK9BmI3BSeYaUeE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699263749; c=relaxed/simple; bh=3XIAbYVXuQbwkJlVoC6hLnfxtL+AcnZNbjPQH37bbL0=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=Czr3GD7zSAXp/efFTeICFIYXvOR3KQjrvQIN2BZ7DxgDs0WHyLNkO3easkOf2jzXGnGIRBmpMmAUvaOMk9GeUqYikjH+phP1H49qkdEGz3tqTMxUoGnDun+bApEQLIUcT/MpDX74cXN8ks5FK7XFwSTDnPGZi5mzu5diNOz5vfU= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: k9Ck3syFQ4CK3CHtg+OGjw== X-CSE-MsgGUID: CcX2MFZ8RcG9vChnJE3kAg== X-IronPort-AV: E=Sophos;i="6.03,281,1694764800"; d="scan'208";a="22021064" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 06 Nov 2023 01:42:25 -0800 IronPort-SDR: OcaT7vn3VEoh7Tq9qv8uyCPWQs/F29WBRshS7TL7WKqjqMSczPRs/Cv2NfXNC0cQxbB0dGqBBF omOdxl4QtHvm2K1l4sw4efgShifeuqNGSmMQ3EO3nkHPpkxIRzfN+dkag4ZjFzQkZUi5F2nssc OMilHv+Rnsw1/gGOID7Aj/1FeX9CHurHdbGra0o+o2s9Y2z0BBf4y4Z48Og+bq8nNiMteSkly3 bRQgf+sjEmPs9tKVnK7KnyVOiH0VPP0RswtkjgnEGYQTL2svs3XBH82aU6o2RndolIhofUUjH2 DD0= Message-ID: <2172ef1b-7ea4-4250-8249-04b57c5f4a6e@codesourcery.com> Date: Mon, 6 Nov 2023 09:42:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] vect: disable multiple calls of poly simdclones To: Richard Biener , "Andre Vieira (lists)" CC: "gcc-patches@gcc.gnu.org" , Richard Sandiford , "jakub@redhat.com" References: <91d3f8ee-8b2c-4866-a3ed-beb2953b5438@arm.com> Content-Language: en-GB From: Andrew Stubbs In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06/11/2023 07:52, Richard Biener wrote: > On Fri, 3 Nov 2023, Andre Vieira (lists) wrote: > >> Hi, >> >> The current codegen code to support VF's that are multiples of a simdclone >> simdlen rely on BIT_FIELD_REF to create multiple input vectors. This does not >> work for non-constant simdclones, so we should disable using such clones when >> the VF is a multiple of the non-constant simdlen until we change the codegen >> to support those. >> >> Enabling SVE simdclone support will cause ICEs if the vectorizer decides to >> use a SVE simdclone with a VF that is larger than the simdlen. I'll be away >> for the next two weeks, so cant' really discuss this further. >> I initially tried to solve the problem, but the way >> vectorizable_simd_clone_call is structured doesn't make it easy to replace >> BIT_FIELD_REF with the poly-suitable solution right now of using >> unpack_{hi,lo}. > > I think it should be straight-forward to use unpack_{even,odd} (it's > even/odd for VLA, right? If lo/hi would be possible then doing > BIT_FIELD_REF would be, too? Also you need to have multiple stages > of unpack/pack when the factor is more than 2). > > There's plenty of time even during stage3 to address this. > > At least your patch should have come with a testcase (or two). > > Is there a bugreport tracking this issue? It should affect GCN as well > I guess. What does "non-constant simdclones" mean? I'm not sure if this is a thing that can happen on GCN, or not? Andrew