From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30834 invoked by alias); 10 Apr 2018 06:32:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30806 invoked by uid 89); 10 Apr 2018 06:32:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,SPF_PASS autolearn=ham version=3.3.2 spammy=H*u:6.1, H*UA:6.1 X-HELO: mail.ispras.ru Received: from mail.ispras.ru (HELO mail.ispras.ru) (83.149.199.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Apr 2018 06:32:48 +0000 Received: from [10.10.3.52] (pluton2.ispras.ru [83.149.199.44]) by mail.ispras.ru (Postfix) with ESMTPSA id 2F43954006A; Tue, 10 Apr 2018 09:32:46 +0300 (MSK) Subject: Re: Fix PRs 80463, 83972, 83480 To: Jakub Jelinek Cc: Alexander Monakov , GCC Patches References: <335f9422-2a51-ac54-691c-5ea099164afe@ispras.ru> <33b19bc3-a2fd-b4ff-4376-5bd93c7004d0@ispras.ru> <07578825-47c1-45e7-8750-327997b8ff69@ispras.ru> <20180409182350.GV8577@tucnak> From: Andrey Belevantsev Openpgp: preference=signencrypt Message-ID: <21979c0b-8af7-979d-5546-10424d3173bf@ispras.ru> Date: Tue, 10 Apr 2018 06:32:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180409182350.GV8577@tucnak> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00430.txt.bz2 On 09.04.2018 21:23, Jakub Jelinek wrote: > On Mon, Apr 09, 2018 at 01:30:12PM +0300, Andrey Belevantsev wrote: >> I think that should be fine, that is, as long as the insn moved up through >> all those debug insns, the copy will do that as well. It's that >> problematic conditional in sched-deps.c that we should take care of. >> >> I've reworded the comment and committed the attached patch. Thanks for >> your help. > > The C++ testcase FAILs everywhere: > FAIL: g++.dg/pr80463.C -std=gnu++98 (test for excess errors) > Excess errors: > cc1plus: warning: var-tracking-assignments changes selective scheduling > > The other testcases in the patch used -w probably to disable the same > warning, so I've committed following as obvious to trunk after regtesting it > on x86_64-linux and i686-linux: Thank you very much, I have missed this when committing. Sorry for the noise. Andrey > > 2018-04-09 Jakub Jelinek > > PR rtl-optimization/80463 > * g++.dg/pr80463.C: Add -w to dg-options. > > --- gcc/testsuite/g++.dg/pr80463.C.jj 2018-04-09 20:15:47.226631780 +0200 > +++ gcc/testsuite/g++.dg/pr80463.C 2018-04-09 20:19:43.783616136 +0200 > @@ -1,5 +1,5 @@ > /* { dg-do compile { target powerpc*-*-* ia64-*-* i?86-*-* x86_64-*-* } } */ > -/* { dg-options "-g -fselective-scheduling2 -O2 -fvar-tracking-assignments" } */ > +/* { dg-options "-g -fselective-scheduling2 -O2 -fvar-tracking-assignments -w" } */ > > int *a; > int b, c; > > > Jakub >