From: Jeff Law <jeffreyalaw@gmail.com>
To: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
"pan2.li" <pan2.li@intel.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Cc: "yanzhang.wang" <yanzhang.wang@intel.com>,
"kito.cheng" <kito.cheng@gmail.com>
Subject: Re: [PATCH v1] RISC-V: Bugfix for the const vector in single steps
Date: Tue, 19 Dec 2023 21:02:52 -0700 [thread overview]
Message-ID: <21b2deed-bae0-46fd-9c87-17482596ee8a@gmail.com> (raw)
In-Reply-To: <DDE84DC143D3B6FC+2023122010505500088414@rivai.ai>
On 12/19/23 19:50, juzhe.zhong@rivai.ai wrote:
>
> + if (known_eq (ele_0 - 0, ele_n - v.npatterns ()))
>
>
> ->
>
> for (i = 0; i < v.npatterns (); )
> check each nelt of npatterns is equal to vid.
Pan -- please indicate what testing was performed. The standard is to
test with and without the patch to verify there are no regressions. You
don't have to test every multilib or anything like that. Just pick a
configuration and test it.
No patch should be committed to the tree without this basic information.
We've been lax on that policy, but that really needs to change.
jeff
next prev parent reply other threads:[~2023-12-20 4:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 2:39 pan2.li
2023-12-20 2:50 ` juzhe.zhong
2023-12-20 4:02 ` Jeff Law [this message]
2023-12-20 4:29 ` Li, Pan2
2023-12-20 6:56 ` [PATCH v2] " pan2.li
2023-12-20 6:58 ` juzhe.zhong
2023-12-20 7:01 ` Li, Pan2
2023-12-20 9:35 ` [PATCH v3] " pan2.li
2023-12-20 9:36 ` juzhe.zhong
2023-12-20 9:39 ` Li, Pan2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21b2deed-bae0-46fd-9c87-17482596ee8a@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=pan2.li@intel.com \
--cc=yanzhang.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).