From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C28FE3882674 for ; Wed, 10 Jan 2024 22:20:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C28FE3882674 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C28FE3882674 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704925217; cv=none; b=BfszJKy9OwIRitHpgAkcQGQNKyT2leP41YFtXjh0Yx4cNg077D1AXZMfKafdPMyWVBxHFVrUdemPkDjb+xRBrmbIujkifZaq68SM/GpQe2B3Y3fIkEVUwLmm+9mKFAN8ur9mhYWcj8U0L+FZNcrdEVYhb41G9VkOeHdsh16+1Q8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704925217; c=relaxed/simple; bh=fW+obbskYtxlzj/Q7lEVFpC7FSWVr08y23It2IN1g+k=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=K+fFU3N9M3I+p991R4pK31B+5gXlqXvpRdnK5myrt7Ez92nsFqQKShTBtuUH/lPg7ACV5wsN5w659LNnVMLstFJo1mP9U8+n1YW1UIIooRAL1KmzNCxNiek1LYLRGRGG/R8l87Uc8Ffuz2nRje0sE9GhSbEsoojKdsoqaXhlEr0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704925215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ADZ9JUonsDlcCqycBHmK6b/CH84zhr58M3656z8MHA=; b=LM73FUL/A33YYxEtzvPB2uTvMqe40h4zFBM4MVtFl/V17VtPncZZETL5fhBQD5jF7t8iVq UyfBmr3jQ6T7JtWPfPT3pdBOLJmXNT55W0l+N0p5CPAwPrf4h5+KYVxgeBqQqUGrHxHNhQ kfZe+m5gMgECWhAdnGo8NhxuRRHpCkQ= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-o3u8r0NLPu6EXYvm2HrbFg-1; Wed, 10 Jan 2024 17:20:13 -0500 X-MC-Unique: o3u8r0NLPu6EXYvm2HrbFg-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6800e52d47aso104853086d6.1 for ; Wed, 10 Jan 2024 14:20:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704925212; x=1705530012; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2ADZ9JUonsDlcCqycBHmK6b/CH84zhr58M3656z8MHA=; b=h+X0aNIF557M9qf93MWPK/vIOIk+RglQE/9BPeNvEwQJyn01+MK45Hy62PtS8jvsOf Ty90zT6vNMOmA6yHrhil9KbabAA3V7b+GBah+dX3mYg9SQPTBjUFrh9boDJCuuTQ+fLr 70T2Lr0mznTzjrIttKPbdt7fVXHfveAF/fdsaxCTdlo3QAbmCMEQ2CjaU4nbsGwqFjsd eGGdPKAD2qUXLP8Wr68d/gBEoHI50OOIuYCHbazb4GL/LCwBz2iEuiukomHfRCML9cED 85yN4fHBcF6pwDtRa462eYr2tOfrFF0VT0T7SfaqV+gNvzYOFml8IxxSRNvHimke6VgM rpTQ== X-Gm-Message-State: AOJu0YwC1q4sJj4xfeXuXY3MDhwRudo5imk9xfA0QJa7sbu9hsLrulZe VV3PWe/lKcOEOlfJiIow8hQkmUKkfgo6+JXfSD5dAdLB9W0fAlub/xLF0Kg3ey6wkcPY4L4xBQ8 x5DpABajtxq8XYUPXthhg49pG+3w984vt4g== X-Received: by 2002:a05:6214:2aa6:b0:681:1897:18a4 with SMTP id js6-20020a0562142aa600b00681189718a4mr1150862qvb.5.1704925212314; Wed, 10 Jan 2024 14:20:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzhT8QDt4lgzjXV7qouRbbZEihM7nuYda0rXvdibliJjs0ofzjKMlTzkPoup/zz4z0rNtTcQ== X-Received: by 2002:a05:6214:2aa6:b0:681:1897:18a4 with SMTP id js6-20020a0562142aa600b00681189718a4mr1150853qvb.5.1704925211991; Wed, 10 Jan 2024 14:20:11 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id o7-20020a056214108700b0067f9bbd1689sm2014207qvr.76.2024.01.10.14.20.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 14:20:11 -0800 (PST) Message-ID: <21b3a93c05d3f651478df175f26ecfe31df566c8.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Fix GGC segfault when using -flto From: David Malcolm To: Antoni Boucher , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Wed, 10 Jan 2024 17:20:10 -0500 In-Reply-To: <6037582ce944fdc91327270c4f27a9d818fc6051.camel@zoho.com> References: <459954b377768b7a0d79dd9d99328b45c66e4fa0.camel@redhat.com> <9738ef0c44d5f5505607c6678d23683aaba2c72f.camel@redhat.com> <03e4a5d4e0b181a46f6c76e643503d54bf508b0c.camel@redhat.com> <6037582ce944fdc91327270c4f27a9d818fc6051.camel@zoho.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2024-01-10 at 10:27 -0500, Antoni Boucher wrote: > On Wed, 2024-01-10 at 10:19 -0500, David Malcolm wrote: > > On Mon, 2023-12-11 at 19:20 -0500, Antoni Boucher wrote: > > > I'm not sure how to do this. I tried the following commands, but > > > this > > > fails even on master: > > >=20 > > > ../../gcc/configure --enable-host-shared --enable- > > > languages=3Dc,jit,c++,fortran,objc,lto --enable-checking=3Drelease -- > > > disable-werror --prefix=3D/opt/gcc > > >=20 > > > make bootstrap -j24 > > > make -k check -j24 > > >=20 > > > From what I can understand, the unexpected failures are in g++: > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=3D=3D=3D g++ Summary =3D=3D=3D > > >=20 > > > # of expected passes=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A072790 > > > # of unexpected failures=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A01 > > > # of expected failures=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A01011 > > > # of unsupported tests=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A03503 > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=3D=3D=3D g++ Summary =3D=3D=3D > > >=20 > > > # of expected passes=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A04750 > > > # of unexpected failures=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A027 > > > # of expected failures=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A016 > > > # of unsupported tests=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A043 > > >=20 > > >=20 > > > Am I doing something wrong? > >=20 > > I normally do a pair of bootstrap/tests: a "control" build with a > > pristine copy of the source tree, and an "experiment" build > > containing > > the patch(s) of interest, then compare the results.=C2=A0 FWIW given > > that > > each one takes 2 hours on my machine, I normally just do one > > control > > build on a Monday, rebase all my working copies to that revision, > > and > > then use that control build throughout the week for comparison when > > testing patches. > >=20 > > I can have a go at testing an updated patch if you like; presumably > > the > > latest version is this one: > > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638841.html > > right? >=20 > Thanks. I would appreciate if you do it. > Yes, this is the latest patch. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu; the only change in results was jit.sum's # of PASS results increased by 15, as expected. No jit.sum failures, and no regressions elsewhere in the testsuites. I've pushed it to trunk as r14-7117-g8415bceea9d3ca. Dave >=20 > >=20 > > Dave > >=20 > >=20 > >=20 > > >=20 > > > On Fri, 2023-12-01 at 12:49 -0500, David Malcolm wrote: > > > > On Thu, 2023-11-30 at 17:13 -0500, Antoni Boucher wrote: > > > > > Here's the updated patch. > > > > > The failure was due to the test being in the test array while > > > > > it > > > > > should > > > > > not have been there since it changes the context. > > > >=20 > > > > Thanks for the updated patch. > > > >=20 > > > > Did you do a full bootstrap and regression test with this one, > > > > or > > > > do > > > > you want me to? > > > >=20 > > > > Dave > > > >=20 > > >=20 > >=20 >=20