From: Jeff Law <law@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, gcc-patches@gcc.gnu.org
Cc: Jakub Jelinek <jakub@redhat.com>, Jan Hubicka <hubicka@ucw.cz>,
Uros Bizjak <ubizjak@gmail.com>
Subject: Re: [PATCH 3/6] i386: Use ix86_output_ssemov for SImode TYPE_SSEMOV
Date: Wed, 11 Mar 2020 21:39:17 -0600 [thread overview]
Message-ID: <21b889c26d0506f6ce21a3eb3a3a705173b49f74.camel@redhat.com> (raw)
In-Reply-To: <20200229141608.88967-4-hjl.tools@gmail.com>
On Sat, 2020-02-29 at 06:16 -0800, H.J. Lu wrote:
> There is no need to set mode attribute to XImode since ix86_output_ssemov
> can properly encode xmm16-xmm31 registers with and without AVX512VL.
>
> gcc/
>
> PR target/89229
> * config/i386/i386.c (ix86_output_ssemov): Handle MODE_SI.
> * config/i386/i386.md (*movsi_internal): Call ix86_output_ssemov
> for TYPE_SSEMOV. Remove ext_sse_reg_operand and TARGET_AVX512VL
> check.
>
> gcc/testsuite/
>
> PR target/89229
> * gcc.target/i386/pr89229-5a.c: New test.
> * gcc.target/i386/pr89229-5b.c: Likewise.
> * gcc.target/i386/pr89229-5c.c: Likewise.
Similar to #2, can't we get insn_mode to be SFmode for alternatives 10,11 and
!TARGET_SSE2? Won't that cause us to hit the gcc_unreachable in
ix86_output_ssemov?
jeff
>
prev parent reply other threads:[~2020-03-12 3:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 14:16 V2 [PATCH 0/6] i386: Properly encode xmm16-xmm31/ymm16-ymm31 for vector move H.J. Lu
2020-02-29 14:16 ` [PATCH 6/6] i386: Use ix86_output_ssemov for MMX TYPE_SSEMOV H.J. Lu
2020-03-12 3:53 ` Jeff Law
2020-03-12 10:52 ` H.J. Lu
2020-02-29 14:16 ` [PATCH 5/6] i386: Use ix86_output_ssemov for SFmode TYPE_SSEMOV H.J. Lu
2020-03-12 3:46 ` Jeff Law
2020-02-29 14:16 ` [PATCH 2/6] i386: Use ix86_output_ssemov for DImode TYPE_SSEMOV H.J. Lu
2020-03-12 3:32 ` Jeff Law
2020-02-29 14:16 ` [PATCH 1/6] i386: Properly encode vector registers in vector move H.J. Lu
2020-03-05 23:47 ` Jeff Law
2020-03-08 12:04 ` [COMMITTED, PATCH] gcc.target/i386/pr89229-3c.c: Include "pr89229-3a.c" H.J. Lu
2020-03-10 12:35 ` [PATCH 1/6] i386: Properly encode vector registers in vector move H.J. Lu
2020-02-29 14:16 ` [PATCH 4/6] i386: Use ix86_output_ssemov for DFmode TYPE_SSEMOV H.J. Lu
2020-03-12 3:41 ` Jeff Law
2020-02-29 15:30 ` [PATCH 3/6] i386: Use ix86_output_ssemov for SImode TYPE_SSEMOV H.J. Lu
2020-03-12 3:39 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21b889c26d0506f6ce21a3eb3a3a705173b49f74.camel@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=hubicka@ucw.cz \
--cc=jakub@redhat.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).